diff options
| author | mav <mav@FreeBSD.org> | 2014-04-28 15:03:52 +0000 |
|---|---|---|
| committer | mav <mav@FreeBSD.org> | 2014-04-28 15:03:52 +0000 |
| commit | b384f8775fb9dac291a6c48827c9f7c4bd2bc455 (patch) | |
| tree | 8ef1dbcf0bf2748d8dd96a8f0489bf36ec905653 /sys/geom/raid/g_raid.c | |
| parent | 12ae7f74a071f0439763986026525094a7032dfd (diff) | |
| download | FreeBSD-src-b384f8775fb9dac291a6c48827c9f7c4bd2bc455.zip FreeBSD-src-b384f8775fb9dac291a6c48827c9f7c4bd2bc455.tar.gz | |
Reduce number of opens by REOM RAID during provider taste.
Instead opening/closing provider by each of metadata classes, do it only
once in core code. Since for SCSI disks open/close means sending some
SCSI commands to the device, this change reduces taste time.
MFC after: 2 weeks
Sponsored by: iXsystems, Inc.
Diffstat (limited to 'sys/geom/raid/g_raid.c')
| -rw-r--r-- | sys/geom/raid/g_raid.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/sys/geom/raid/g_raid.c b/sys/geom/raid/g_raid.c index a161f8a..858cf4c 100644 --- a/sys/geom/raid/g_raid.c +++ b/sys/geom/raid/g_raid.c @@ -2251,6 +2251,8 @@ g_raid_taste(struct g_class *mp, struct g_provider *pp, int flags __unused) return (NULL); G_RAID_DEBUG(2, "Tasting provider %s.", pp->name); + geom = NULL; + status = G_RAID_MD_TASTE_FAIL; gp = g_new_geomf(mp, "raid:taste"); /* * This orphan function should be never called. @@ -2259,8 +2261,9 @@ g_raid_taste(struct g_class *mp, struct g_provider *pp, int flags __unused) cp = g_new_consumer(gp); cp->flags |= G_CF_DIRECT_RECEIVE; g_attach(cp, pp); + if (g_access(cp, 1, 0, 0) != 0) + goto ofail; - geom = NULL; LIST_FOREACH(class, &g_raid_md_classes, mdc_list) { if (!class->mdc_enable) continue; @@ -2276,6 +2279,9 @@ g_raid_taste(struct g_class *mp, struct g_provider *pp, int flags __unused) break; } + if (status == G_RAID_MD_TASTE_FAIL) + (void)g_access(cp, -1, 0, 0); +ofail: g_detach(cp); g_destroy_consumer(cp); g_destroy_geom(gp); |
