diff options
author | jhb <jhb@FreeBSD.org> | 2011-05-14 01:10:57 +0000 |
---|---|---|
committer | jhb <jhb@FreeBSD.org> | 2011-05-14 01:10:57 +0000 |
commit | 730731c714018686d70f4e95137068854b5f706b (patch) | |
tree | f97444ef19d310ca7aa0b06b623898b81333936d /sys/fs | |
parent | 218a490daf8b252f463217c31e7bd4d4ee212a6d (diff) | |
download | FreeBSD-src-730731c714018686d70f4e95137068854b5f706b.zip FreeBSD-src-730731c714018686d70f4e95137068854b5f706b.tar.gz |
Merge comments about converting directory entries to be more direct and
concise.
Inspired by: Gleb Kurtsou
Diffstat (limited to 'sys/fs')
-rw-r--r-- | sys/fs/ext2fs/ext2_lookup.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/sys/fs/ext2fs/ext2_lookup.c b/sys/fs/ext2fs/ext2_lookup.c index 5e23b34..b293d7f 100644 --- a/sys/fs/ext2fs/ext2_lookup.c +++ b/sys/fs/ext2fs/ext2_lookup.c @@ -119,17 +119,11 @@ static int ext2_dirbadentry(struct vnode *dp, struct ext2fs_direct_2 *de, /* * Vnode op for reading directories. * - * The routine below assumes that the on-disk format of a directory - * is the same as that defined by <sys/dirent.h>. If the on-disk - * format changes, then it will be necessary to do a conversion - * from the on-disk format that read returns to the format defined - * by <sys/dirent.h>. - */ -/* - * this is exactly what we do here - the problem is that the conversion - * will blow up some entries by four bytes, so it can't be done in place. - * This is too bad. Right now the conversion is done entry by entry, the - * converted entry is sent via uiomove. + * This function has to convert directory entries from the on-disk + * format to the format defined by <sys/dirent.h>. Unfortunately, the + * conversion will blow up some entries by four bytes, so it can't be + * done in place. Instead, the conversion is done entry by entry and + * the converted entry is sent via uiomove. * * XXX allocate a buffer, convert as many entries as possible, then send * the whole buffer to uiomove |