summaryrefslogtreecommitdiffstats
path: root/sys/fs/fdescfs
diff options
context:
space:
mode:
authortegge <tegge@FreeBSD.org>2007-03-13 01:50:27 +0000
committertegge <tegge@FreeBSD.org>2007-03-13 01:50:27 +0000
commit214bc5723c38739a6060170f2c421e59d87b2c82 (patch)
tree6dca3f2c99e6dcb6402e1486118e56eb8d5e871b /sys/fs/fdescfs
parent76cbc46fe707603a2b4dde9cc8398128868b56ee (diff)
downloadFreeBSD-src-214bc5723c38739a6060170f2c421e59d87b2c82.zip
FreeBSD-src-214bc5723c38739a6060170f2c421e59d87b2c82.tar.gz
Make insmntque() externally visibile and allow it to fail (e.g. during
late stages of unmount). On failure, the vnode is recycled. Add insmntque1(), to allow for file system specific cleanup when recycling vnode on failure. Change getnewvnode() to no longer call insmntque(). Previously, embryonic vnodes were put onto the list of vnode belonging to a file system, which is unsafe for a file system marked MPSAFE. Change vfs_hash_insert() to no longer lock the vnode. The caller now has that responsibility. Change most file systems to lock the vnode and call insmntque() or insmntque1() after a new vnode has been sufficiently setup. Handle failed insmntque*() calls by propagating errors to callers, possibly after some file system specific cleanup. Approved by: re (kensmith) Reviewed by: kib In collaboration with: kib
Diffstat (limited to 'sys/fs/fdescfs')
-rw-r--r--sys/fs/fdescfs/fdesc_vnops.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c
index 90c4be0..c16c0a2 100644
--- a/sys/fs/fdescfs/fdesc_vnops.c
+++ b/sys/fs/fdescfs/fdesc_vnops.c
@@ -151,6 +151,13 @@ loop:
fd->fd_type = ftype;
fd->fd_fd = -1;
fd->fd_ix = ix;
+ /* XXX: vnode should be locked here */
+ error = insmntque(*vpp, mp); /* XXX: Too early for mpsafe fs */
+ if (error != 0) {
+ free(fd, M_TEMP);
+ *vpp = NULLVP;
+ goto out;
+ }
LIST_INSERT_HEAD(fc, fd, fd_hash);
out:
OpenPOWER on IntegriCloud