summaryrefslogtreecommitdiffstats
path: root/sys/dev/usb/serial
diff options
context:
space:
mode:
authorthompsa <thompsa@FreeBSD.org>2009-11-26 00:43:17 +0000
committerthompsa <thompsa@FreeBSD.org>2009-11-26 00:43:17 +0000
commit6745662f291e4a2ec843786b1a2278ae3c3ae675 (patch)
tree75f2e4cf4188e185060baa41ada36997b1b99d2d /sys/dev/usb/serial
parent62d1f26939126690c2bc23bbab214c4976da2647 (diff)
downloadFreeBSD-src-6745662f291e4a2ec843786b1a2278ae3c3ae675.zip
FreeBSD-src-6745662f291e4a2ec843786b1a2278ae3c3ae675.tar.gz
Remove overuse of exclamation marks in kernel printfs, there mere fact a
message has been printed is enough to get someones attention. Also remove the line number for DPRINTF/DPRINTFN, it already prints the funtion name and a unique message.
Diffstat (limited to 'sys/dev/usb/serial')
-rw-r--r--sys/dev/usb/serial/u3g.c4
-rw-r--r--sys/dev/usb/serial/uark.c2
-rw-r--r--sys/dev/usb/serial/ubser.c2
-rw-r--r--sys/dev/usb/serial/ucycom.c4
-rw-r--r--sys/dev/usb/serial/ufoma.c6
-rw-r--r--sys/dev/usb/serial/uftdi.c2
-rw-r--r--sys/dev/usb/serial/ugensa.c4
-rw-r--r--sys/dev/usb/serial/umct.c2
-rw-r--r--sys/dev/usb/serial/umodem.c4
-rw-r--r--sys/dev/usb/serial/uplcom.c4
10 files changed, 15 insertions, 19 deletions
diff --git a/sys/dev/usb/serial/u3g.c b/sys/dev/usb/serial/u3g.c
index e038b1a..ec54833 100644
--- a/sys/dev/usb/serial/u3g.c
+++ b/sys/dev/usb/serial/u3g.c
@@ -250,8 +250,6 @@ u3g_sierra_init(struct usb_device *udev)
{
struct usb_device_request req;
- DPRINTFN(0, "\n");
-
req.bmRequestType = UT_VENDOR;
req.bRequest = UR_SET_INTERFACE;
USETW(req.wValue, UF_DEVICE_REMOTE_WAKEUP);
@@ -270,8 +268,6 @@ u3g_huawei_init(struct usb_device *udev)
{
struct usb_device_request req;
- DPRINTFN(0, "\n");
-
req.bmRequestType = UT_WRITE_DEVICE;
req.bRequest = UR_SET_FEATURE;
USETW(req.wValue, UF_DEVICE_REMOTE_WAKEUP);
diff --git a/sys/dev/usb/serial/uark.c b/sys/dev/usb/serial/uark.c
index 492f68b..7dfb0f8 100644
--- a/sys/dev/usb/serial/uark.c
+++ b/sys/dev/usb/serial/uark.c
@@ -211,7 +211,7 @@ uark_attach(device_t dev)
if (error) {
device_printf(dev, "allocating control USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
/* clear stall at first run */
diff --git a/sys/dev/usb/serial/ubser.c b/sys/dev/usb/serial/ubser.c
index f95f464..06c96c0 100644
--- a/sys/dev/usb/serial/ubser.c
+++ b/sys/dev/usb/serial/ubser.c
@@ -282,7 +282,7 @@ ubser_attach(device_t dev)
sc->sc_tx_size = usbd_xfer_max_len(sc->sc_xfer[UBSER_BULK_DT_WR]);
if (sc->sc_tx_size == 0) {
- DPRINTFN(0, "invalid tx_size!\n");
+ DPRINTFN(0, "invalid tx_size\n");
goto detach;
}
/* initialize port numbers */
diff --git a/sys/dev/usb/serial/ucycom.c b/sys/dev/usb/serial/ucycom.c
index 0c1619d..1cce28e 100644
--- a/sys/dev/usb/serial/ucycom.c
+++ b/sys/dev/usb/serial/ucycom.c
@@ -266,7 +266,7 @@ ucycom_attach(device_t dev)
sc, &sc->sc_mtx);
if (error) {
device_printf(dev, "allocating USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
@@ -555,7 +555,7 @@ ucycom_intr_read_callback(struct usb_xfer *xfer, usb_error_t error)
break;
default:
- DPRINTFN(0, "unsupported model number!\n");
+ DPRINTFN(0, "unsupported model number\n");
goto tr_setup;
}
diff --git a/sys/dev/usb/serial/ufoma.c b/sys/dev/usb/serial/ufoma.c
index 3d015fd..b1a7349 100644
--- a/sys/dev/usb/serial/ufoma.c
+++ b/sys/dev/usb/serial/ufoma.c
@@ -401,7 +401,7 @@ ufoma_attach(device_t dev)
if (error) {
device_printf(dev, "allocating control USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
mad = ufoma_get_intconf(cd, id, UDESC_VS_INTERFACE, UDESCSUB_MCPC_ACM);
@@ -1060,7 +1060,7 @@ ufoma_modem_setup(device_t dev, struct ufoma_softc *sc,
break;
}
} else {
- device_printf(dev, "no data interface!\n");
+ device_printf(dev, "no data interface\n");
return (EINVAL);
}
}
@@ -1071,7 +1071,7 @@ ufoma_modem_setup(device_t dev, struct ufoma_softc *sc,
if (error) {
device_printf(dev, "allocating BULK USB "
- "transfers failed!\n");
+ "transfers failed\n");
return (EINVAL);
}
return (0);
diff --git a/sys/dev/usb/serial/uftdi.c b/sys/dev/usb/serial/uftdi.c
index c7442b6..ae0c939 100644
--- a/sys/dev/usb/serial/uftdi.c
+++ b/sys/dev/usb/serial/uftdi.c
@@ -307,7 +307,7 @@ uftdi_attach(device_t dev)
if (error) {
device_printf(dev, "allocating USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
sc->sc_ucom.sc_portno = FTDI_PIT_SIOA + uaa->info.bIfaceNum;
diff --git a/sys/dev/usb/serial/ugensa.c b/sys/dev/usb/serial/ugensa.c
index dd6b6f1..99656dd 100644
--- a/sys/dev/usb/serial/ugensa.c
+++ b/sys/dev/usb/serial/ugensa.c
@@ -210,7 +210,7 @@ ugensa_attach(device_t dev)
}
if (cnt == 0) {
- device_printf(dev, "No interfaces!\n");
+ device_printf(dev, "No interfaces\n");
goto detach;
}
for (x = 0; x < cnt; x++) {
@@ -229,7 +229,7 @@ ugensa_attach(device_t dev)
if (error) {
device_printf(dev, "allocating USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
/* clear stall at first run */
diff --git a/sys/dev/usb/serial/umct.c b/sys/dev/usb/serial/umct.c
index 7331a0b..524f8c4 100644
--- a/sys/dev/usb/serial/umct.c
+++ b/sys/dev/usb/serial/umct.c
@@ -263,7 +263,7 @@ umct_attach(device_t dev)
if (error) {
device_printf(dev, "allocating USB "
- "transfers failed!\n");
+ "transfers failed\n");
goto detach;
}
diff --git a/sys/dev/usb/serial/umodem.c b/sys/dev/usb/serial/umodem.c
index 9b8da42..6a6d395 100644
--- a/sys/dev/usb/serial/umodem.c
+++ b/sys/dev/usb/serial/umodem.c
@@ -311,7 +311,7 @@ umodem_attach(device_t dev)
0 - 1, UDESCSUB_CDC_UNION, 0 - 1);
if ((cud == NULL) || (cud->bLength < sizeof(*cud))) {
- device_printf(dev, "no CM or union descriptor!\n");
+ device_printf(dev, "no CM or union descriptor\n");
goto detach;
}
@@ -344,7 +344,7 @@ umodem_attach(device_t dev)
break;
}
} else {
- device_printf(dev, "no data interface!\n");
+ device_printf(dev, "no data interface\n");
goto detach;
}
}
diff --git a/sys/dev/usb/serial/uplcom.c b/sys/dev/usb/serial/uplcom.c
index af6bdba..ef5db40 100644
--- a/sys/dev/usb/serial/uplcom.c
+++ b/sys/dev/usb/serial/uplcom.c
@@ -377,7 +377,7 @@ uplcom_attach(device_t dev)
if (iface) {
id = usbd_get_interface_descriptor(iface);
if (id == NULL) {
- device_printf(dev, "no interface descriptor (2)!\n");
+ device_printf(dev, "no interface descriptor (2)\n");
goto detach;
}
sc->sc_data_iface_no = id->bInterfaceNumber;
@@ -420,7 +420,7 @@ uplcom_attach(device_t dev)
*/
if (sc->sc_chiptype == TYPE_PL2303X) {
if (uplcom_pl2303x_init(uaa->device)) {
- device_printf(dev, "init failed!\n");
+ device_printf(dev, "init failed\n");
goto detach;
}
}
OpenPOWER on IntegriCloud