summaryrefslogtreecommitdiffstats
path: root/sys/dev/uart/uart_bus.h
diff options
context:
space:
mode:
authormarcel <marcel@FreeBSD.org>2003-09-26 05:14:56 +0000
committermarcel <marcel@FreeBSD.org>2003-09-26 05:14:56 +0000
commit0653dc7b1be87204016d8f28fd861f3570fea0e9 (patch)
treed9aaac35b0191aeab19f23c33c5d34bb16d77724 /sys/dev/uart/uart_bus.h
parent728398b5c5d3b44e6f1c8ebecd6451c79b042c1a (diff)
downloadFreeBSD-src-0653dc7b1be87204016d8f28fd861f3570fea0e9.zip
FreeBSD-src-0653dc7b1be87204016d8f28fd861f3570fea0e9.tar.gz
Revert the introduction of iobase in struct uart_bas. Both the SAB82532
and the Z8530 drivers used the I/O address as a quick and dirty way to determine which channel they operated on, but formalizing this by introducing iobase is not a solution. How for example would a driver know which channel it controls for a multi-channel UART that only has a single I/O range? Instead, add an explicit field, called chan, to struct uart_bas that holds the channel within a device, or 0 otherwise. The chan field is initialized both by the system device probing (i.e. a system console) or it is passed down to uart_bus_probe() by any of the bus front-ends. As such, it impacts all platforms and bus drivers and makes it a rather large commit. Remove the use of iobase in uart_cpu_eqres() for pc98. It is expected that platforms have the capability to compare tag and handle pairs for equality; as to determine whether two pairs access the same device or not. The use of iobase for pc98 makes it impossible to formalize this and turn it into a real newbus function later. This commit reverts uart_cpu_eqres() for pc98 to an unimplemented function. It has to be reimplemented using only the tag and handle fields in struct uart_bas. Rewrite the SAB82532 and Z8530 drivers to use the chan field in struct uart_bas. Remove the IS_CHANNEL_A and IS_CHANNEL_B macros. We don't need to abstract anything anymore. Discussed with: nyan Tested on: i386, ia64, sparc64
Diffstat (limited to 'sys/dev/uart/uart_bus.h')
-rw-r--r--sys/dev/uart/uart_bus.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/uart/uart_bus.h b/sys/dev/uart/uart_bus.h
index dde9ff8..3c45199 100644
--- a/sys/dev/uart/uart_bus.h
+++ b/sys/dev/uart/uart_bus.h
@@ -172,7 +172,7 @@ extern char uart_driver_name[];
int uart_bus_attach(device_t dev);
int uart_bus_detach(device_t dev);
-int uart_bus_probe(device_t dev, int regshft, int rclk, int rid);
+int uart_bus_probe(device_t dev, int regshft, int rclk, int rid, int chan);
int uart_tty_attach(struct uart_softc *);
int uart_tty_detach(struct uart_softc *);
OpenPOWER on IntegriCloud