Alter the behavior of sys/kern/subr_bus.c:device_print_child()

	- device_print_child() either lets the BUS_PRINT_CHILD
	  method produce the entire device announcement message or
	  it prints "foo0: not found\n"

Alter sys/kern/subr_bus.c:bus_generic_print_child() to take on
the previous behavior of device_print_child() (printing the
"foo0: <FooDevice 1.1>" bit of the announce message.)

Provide bus_print_child_header() and bus_print_child_footer()
to actually print the output for bus_generic_print_child().
These functions should be used whenever possible (unless you can
just use bus_generic_print_child())

The BUS_PRINT_CHILD method now returns int instead of void.

Modify everything else that defines or uses a BUS_PRINT_CHILD
method to comply with the above changes.

	- Devices are 'on' a bus, not 'at' it.
	- If a custom BUS_PRINT_CHILD method does the same thing
	  as bus_generic_print_child(), use bus_generic_print_child()
	- Use device_get_nameunit() instead of both
	  device_get_name() and device_get_unit()
	- All BUS_PRINT_CHILD methods return the number of
	  characters output.

Reviewed by: dfr, peter

1 files changed, 2 insertions, 11 deletions

diff --git a/sys/dev/ppbus/lpbb.c b/sys/dev/ppbus/lpbb.c
index e3ce6f0..08f4540 100644
--- a/sys/dev/ppbus/lpbb.c
+++ b/sys/dev/ppbus/lpbb.c
@@ -23,7 +23,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- *	$Id: lpbb.c,v 1.4 1999/01/10 12:04:54 nsouch Exp $
+ *	$Id: lpbb.c,v 1.5 1999/05/08 21:59:06 dfr Exp $
  *
  */
 
@@ -62,7 +62,6 @@ static int lpbb_detect(struct lpbb_softc *);
 
 static int lpbb_probe(device_t);
 static int lpbb_attach(device_t);
-static void lpbb_print_child(device_t, device_t);
 
 static int lpbb_callback(device_t, int, caddr_t *);
 static void lpbb_setlines(device_t, int, int);
@@ -77,7 +76,7 @@ static device_method_t lpbb_methods[] = {
 	DEVMETHOD(device_attach,	lpbb_attach),
 
 	/* bus interface */
-	DEVMETHOD(bus_print_child,	lpbb_print_child),
+	DEVMETHOD(bus_print_child,	bus_generic_print_child),
 
 	/* iicbb interface */
 	DEVMETHOD(iicbb_callback,	lpbb_callback),
@@ -307,12 +306,4 @@ lpbb_getdataline(device_t dev)
 	return (getSDA(sc));
 }
 
-static void
-lpbb_print_child(device_t bus, device_t dev)
-{
-	printf(" on %s%d", device_get_name(bus), device_get_unit(bus));
-
-	return;
-}
-
 DRIVER_MODULE(lpbb, root, lpbb_driver, lpbb_devclass, 0, 0);