diff options
| author | rwatson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
| commit | 9918d13b80941400bfab87834b1e2f1eea58c7c7 (patch) | |
| tree | 9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/dev/nve | |
| parent | efa13b9da9fc80838e2c73140ae27393b3660da4 (diff) | |
| download | FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.zip FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.tar.gz | |
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the
hardware address filter with the network stack-maintained list.
Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca>
MFC after: 1 week
Diffstat (limited to 'sys/dev/nve')
| -rw-r--r-- | sys/dev/nve/if_nve.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/dev/nve/if_nve.c b/sys/dev/nve/if_nve.c index 31031f5..d0f2872 100644 --- a/sys/dev/nve/if_nve.c +++ b/sys/dev/nve/if_nve.c @@ -1073,6 +1073,7 @@ nve_setmulti(struct nve_softc *sc) return; } /* Setup multicast filter */ + IF_ADDR_LOCK(ifp); TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) { u_char *addrp; @@ -1086,6 +1087,7 @@ nve_setmulti(struct nve_softc *sc) oraddr[i] |= mcaddr; } } + IF_ADDR_UNLOCK(ifp); for (i = 0; i < 6; i++) { hwfilter.acMulticastAddress[i] = andaddr[i] & oraddr[i]; hwfilter.acMulticastMask[i] = andaddr[i] | (~oraddr[i]); |
