diff options
author | jlemon <jlemon@FreeBSD.org> | 2001-09-29 19:18:52 +0000 |
---|---|---|
committer | jlemon <jlemon@FreeBSD.org> | 2001-09-29 19:18:52 +0000 |
commit | 6689cad44720247770c3439271c41126ceb5476e (patch) | |
tree | e747bfa7e8d363f3c895759cfbfa10fc7ec0841e /sys/dev/mii/ukphy.c | |
parent | 8bad7ad549c81c7741eb484b254cbe6200cba4c3 (diff) | |
download | FreeBSD-src-6689cad44720247770c3439271c41126ceb5476e.zip FreeBSD-src-6689cad44720247770c3439271c41126ceb5476e.tar.gz |
Cleanup pass for mii drivers.
. Make internal service routines static.
. Use a consistent ordering of checks in MII_TICK. Do the work in the
mii_phy_tick() subroutine if appropriate.
. Call mii_phy_update() to trigger the callbacks.
Diffstat (limited to 'sys/dev/mii/ukphy.c')
-rw-r--r-- | sys/dev/mii/ukphy.c | 42 |
1 files changed, 4 insertions, 38 deletions
diff --git a/sys/dev/mii/ukphy.c b/sys/dev/mii/ukphy.c index bdc47b4..1385135 100644 --- a/sys/dev/mii/ukphy.c +++ b/sys/dev/mii/ukphy.c @@ -115,7 +115,7 @@ static driver_t ukphy_driver = { DRIVER_MODULE(ukphy, miibus, ukphy_driver, ukphy_devclass, 0, 0); -int ukphy_service __P((struct mii_softc *, struct mii_data *, int)); +static int ukphy_service __P((struct mii_softc *, struct mii_data *, int)); static int ukphy_probe(dev) @@ -199,7 +199,7 @@ static int ukphy_detach(dev) return(0); } -int +static int ukphy_service(sc, mii, cmd) struct mii_softc *sc; struct mii_data *mii; @@ -264,38 +264,7 @@ ukphy_service(sc, mii, cmd) */ if (IFM_INST(ife->ifm_media) != sc->mii_inst) return (0); - - /* - * Only used for autonegotiation. - */ - if (IFM_SUBTYPE(ife->ifm_media) != IFM_AUTO) - return (0); - - /* - * Is the interface even up? - */ - if ((mii->mii_ifp->if_flags & IFF_UP) == 0) - return (0); - - /* - * Check to see if we have link. If we do, we don't - * need to restart the autonegotiation process. Read - * the BMSR twice in case it's latched. - */ - reg = PHY_READ(sc, MII_BMSR) | - PHY_READ(sc, MII_BMSR); - if (reg & BMSR_LINK) - return (0); - - /* - * Only retry autonegotiation every 5 seconds. - */ - if (++sc->mii_ticks != 5) - return (0); - - sc->mii_ticks = 0; - mii_phy_reset(sc); - if (mii_phy_auto(sc, 0) == EJUSTRETURN) + if (mii_phy_tick(sc) == EJUSTRETURN) return (0); break; } @@ -304,9 +273,6 @@ ukphy_service(sc, mii, cmd) ukphy_status(sc); /* Callback if something changed. */ - if (sc->mii_active != mii->mii_media_active || cmd == MII_MEDIACHG) { - MIIBUS_STATCHG(sc->mii_dev); - sc->mii_active = mii->mii_media_active; - } + mii_phy_update(sc, cmd); return (0); } |