diff options
author | erj <erj@FreeBSD.org> | 2015-07-21 21:07:18 +0000 |
---|---|---|
committer | erj <erj@FreeBSD.org> | 2015-07-21 21:07:18 +0000 |
commit | ca4bbb4933eb858bf49c6df64d47de0848fcc924 (patch) | |
tree | acc5c77d9eabdd71d59ca2c0e1c0fc7b25ea3da1 /sys/dev/ixl | |
parent | 174d03197671f21a94c5b36c8b46545725169456 (diff) | |
download | FreeBSD-src-ca4bbb4933eb858bf49c6df64d47de0848fcc924.zip FreeBSD-src-ca4bbb4933eb858bf49c6df64d47de0848fcc924.tar.gz |
Fix for a customer issue with ixl(4):
- Add required MAC/VLAN filter when adding an LAA
- Fix bug where code did not check for I40E_SUCCESS from a successful
i40e_validate_mac_address() call in ixl_init_locked(), when setting
an LAA.
PR: 201240
Differential Revision: https://reviews.freebsd.org/D3111
Submitted by: Gregory Rose <gregory.v.rose@intel.com>
Reviewed by: gnn, rstone
Approved by: gnn
MFC after: 2 weeks
Diffstat (limited to 'sys/dev/ixl')
-rw-r--r-- | sys/dev/ixl/if_ixl.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/dev/ixl/if_ixl.c b/sys/dev/ixl/if_ixl.c index 1a36c2a..f4f0704 100644 --- a/sys/dev/ixl/if_ixl.c +++ b/sys/dev/ixl/if_ixl.c @@ -1141,7 +1141,8 @@ ixl_init_locked(struct ixl_pf *pf) bcopy(IF_LLADDR(vsi->ifp), tmpaddr, I40E_ETH_LENGTH_OF_ADDRESS); if (!cmp_etheraddr(hw->mac.addr, tmpaddr) && - i40e_validate_mac_addr(tmpaddr)) { + (i40e_validate_mac_addr(tmpaddr) == I40E_SUCCESS)) { + ixl_del_filter(vsi, hw->mac.addr, IXL_VLAN_ANY); bcopy(tmpaddr, hw->mac.addr, I40E_ETH_LENGTH_OF_ADDRESS); ret = i40e_aq_mac_address_write(hw, @@ -1151,6 +1152,8 @@ ixl_init_locked(struct ixl_pf *pf) device_printf(dev, "LLA address" "change failed!!\n"); return; + } else { + ixl_add_filter(vsi, hw->mac.addr, IXL_VLAN_ANY); } } |