diff options
| author | eadler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
|---|---|---|
| committer | eadler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
| commit | 44c01df17391f4429ee371e8039ae4fd802c2a8e (patch) | |
| tree | 050fb3b68519f6ef7d59051550fa29cdd79d6dac /sys/dev/hatm | |
| parent | 5bcb8c5f4293579e5f8aba6f33f85246b7b70e5d (diff) | |
| download | FreeBSD-src-44c01df17391f4429ee371e8039ae4fd802c2a8e.zip FreeBSD-src-44c01df17391f4429ee371e8039ae4fd802c2a8e.tar.gz | |
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.
This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.
A similar change was made in OpenBSD.
Discussed with: -arch, rdivacky
Reviewed by: cperciva
Diffstat (limited to 'sys/dev/hatm')
| -rw-r--r-- | sys/dev/hatm/if_hatmreg.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/hatm/if_hatmreg.h b/sys/dev/hatm/if_hatmreg.h index dd72126..4014998 100644 --- a/sys/dev/hatm/if_hatmreg.h +++ b/sys/dev/hatm/if_hatmreg.h @@ -444,7 +444,7 @@ #define HE_REGM_TSR3_CRM (0xff << 0) #define HE_REGS_TSR3_CRM 0 -#define HE_REGM_TSR4_FLUSH (1 << 31) +#define HE_REGM_TSR4_FLUSH (1U << 31) #define HE_REGM_TSR4_SESS_END (1 << 30) #define HE_REGM_TSR4_OAM_CRC10 (1 << 28) #define HE_REGM_TSR4_NULL_CRC10 (1 << 27) @@ -475,7 +475,7 @@ #define HE_REGM_TSR13_CRM 0xffff #define HE_REGS_TSR13_CRM 0 -#define HE_REGM_TSR14_CBR_DELETE (1 << 31) +#define HE_REGM_TSR14_CBR_DELETE (1U << 31) #define HE_REGM_TSR14_ABR_CLOSE (1 << 16) /* |
