diff options
author | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
---|---|---|
committer | marius <marius@FreeBSD.org> | 2011-11-22 21:28:20 +0000 |
commit | 17e14c6132be998c8e8d0c2fc89ff0b66d24999c (patch) | |
tree | 4941db3a873a5f9b2ccc4a64c23bf5cd65516206 /sys/dev/gem | |
parent | 6479d45e1526c99672febf3a29a6a99305871131 (diff) | |
download | FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.zip FreeBSD-src-17e14c6132be998c8e8d0c2fc89ff0b66d24999c.tar.gz |
- There's no need to overwrite the default device method with the default
one. Interestingly, these are actually the default for quite some time
(bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9)
since r52045) but even recently added device drivers do this unnecessarily.
Discussed with: jhb, marcel
- While at it, use DEVMETHOD_END.
Discussed with: jhb
- Also while at it, use __FBSDID.
Diffstat (limited to 'sys/dev/gem')
-rw-r--r-- | sys/dev/gem/if_gem_pci.c | 6 | ||||
-rw-r--r-- | sys/dev/gem/if_gem_sbus.c | 6 |
2 files changed, 2 insertions, 10 deletions
diff --git a/sys/dev/gem/if_gem_pci.c b/sys/dev/gem/if_gem_pci.c index c5e1acd..a3376fd 100644 --- a/sys/dev/gem/if_gem_pci.c +++ b/sys/dev/gem/if_gem_pci.c @@ -82,16 +82,12 @@ static device_method_t gem_pci_methods[] = { /* Use the suspend handler here, it is all that is required. */ DEVMETHOD(device_shutdown, gem_pci_suspend), - /* bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - DEVMETHOD(bus_driver_added, bus_generic_driver_added), - /* MII interface */ DEVMETHOD(miibus_readreg, gem_mii_readreg), DEVMETHOD(miibus_writereg, gem_mii_writereg), DEVMETHOD(miibus_statchg, gem_mii_statchg), - KOBJMETHOD_END + DEVMETHOD_END }; static driver_t gem_pci_driver = { diff --git a/sys/dev/gem/if_gem_sbus.c b/sys/dev/gem/if_gem_sbus.c index 205285d..4265b8c 100644 --- a/sys/dev/gem/if_gem_sbus.c +++ b/sys/dev/gem/if_gem_sbus.c @@ -78,16 +78,12 @@ static device_method_t gem_sbus_methods[] = { /* Use the suspend handler here, it is all that is required. */ DEVMETHOD(device_shutdown, gem_sbus_suspend), - /* bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - DEVMETHOD(bus_driver_added, bus_generic_driver_added), - /* MII interface */ DEVMETHOD(miibus_readreg, gem_mii_readreg), DEVMETHOD(miibus_writereg, gem_mii_writereg), DEVMETHOD(miibus_statchg, gem_mii_statchg), - KOBJMETHOD_END + DEVMETHOD_END }; static driver_t gem_sbus_driver = { |