summaryrefslogtreecommitdiffstats
path: root/sys/dev/fdt/fdt_powerpc.c
diff options
context:
space:
mode:
authorjchandra <jchandra@FreeBSD.org>2011-12-02 15:24:39 +0000
committerjchandra <jchandra@FreeBSD.org>2011-12-02 15:24:39 +0000
commite5b89f2d70c0092ae178473393348aa3de7e2745 (patch)
tree282cdd7ec20de7056adfd64b8aed0bd16d32eb50 /sys/dev/fdt/fdt_powerpc.c
parent9be1bfa322fff9a906d73bb1d09940d86d489415 (diff)
downloadFreeBSD-src-e5b89f2d70c0092ae178473393348aa3de7e2745.zip
FreeBSD-src-e5b89f2d70c0092ae178473393348aa3de7e2745.tar.gz
Fix OF_finddevice error return value in case of FDT.
According to the open firmware standard, finddevice call has to return a phandle with value of -1 in case of error. This commit is to: - Fix the FDT implementation of this interface (ofw_fdt_finddevice) to return (phandle_t)-1 in case of error, instead of 0 as it does now. - Fix up the callers of OF_finddevice() to compare the return value with -1 instead of 0 to check for errors. - Since phandle_t is unsigned, the return value of OF_finddevice should be checked with '== -1' rather than '<= 0' or '> 0', fix up these cases as well. Reported by: nwhitehorn Reviewed by: raj Approved by: raj, nwhitehorn
Diffstat (limited to 'sys/dev/fdt/fdt_powerpc.c')
-rw-r--r--sys/dev/fdt/fdt_powerpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/fdt/fdt_powerpc.c b/sys/dev/fdt/fdt_powerpc.c
index ea614db..ac81c08 100644
--- a/sys/dev/fdt/fdt_powerpc.c
+++ b/sys/dev/fdt/fdt_powerpc.c
@@ -62,7 +62,7 @@ fdt_fixup_busfreq(phandle_t root)
* This fixup uses /cpus/ bus-frequency prop value to set simple-bus
* bus-frequency property.
*/
- if ((cpus = OF_finddevice("/cpus")) == 0)
+ if ((cpus = OF_finddevice("/cpus")) == -1)
return;
if ((child = OF_child(cpus)) == 0)
OpenPOWER on IntegriCloud