summaryrefslogtreecommitdiffstats
path: root/sys/dev/ata/ata-all.h
diff options
context:
space:
mode:
authormav <mav@FreeBSD.org>2009-02-26 21:33:48 +0000
committermav <mav@FreeBSD.org>2009-02-26 21:33:48 +0000
commitbb22735cfd8d9750d7d63bbe7a69bb5e7f68060c (patch)
tree0fcc3922c3bc54621b1ead87fd3a5fb83ffad5d5 /sys/dev/ata/ata-all.h
parente2be17ec8c033846c60a3c3371e6709f46d8efcb (diff)
downloadFreeBSD-src-bb22735cfd8d9750d7d63bbe7a69bb5e7f68060c.zip
FreeBSD-src-bb22735cfd8d9750d7d63bbe7a69bb5e7f68060c.tar.gz
Remove direct ata_completed() call options from ata_finish(), except for the
kernel dumping case. ata_completed() may initiate ata_reinit() on error, that may lead to drives attach or detach. Attach and detach are sending requests to drives and sleep waiting for results. But ata_finish() can be called directly from interrupt handler where sleeping is prohibited, so we must break this chain somewhere. This place seems to fit best.
Diffstat (limited to 'sys/dev/ata/ata-all.h')
-rw-r--r--sys/dev/ata/ata-all.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/sys/dev/ata/ata-all.h b/sys/dev/ata/ata-all.h
index a721d80..c00bb1c 100644
--- a/sys/dev/ata/ata-all.h
+++ b/sys/dev/ata/ata-all.h
@@ -367,7 +367,6 @@ struct ata_request {
#define ATA_R_AT_HEAD 0x00000200
#define ATA_R_REQUEUE 0x00000400
#define ATA_R_THREAD 0x00000800
-#define ATA_R_DIRECT 0x00001000
#define ATA_R_DEBUG 0x10000000
#define ATA_R_DANGER1 0x20000000
OpenPOWER on IntegriCloud