summaryrefslogtreecommitdiffstats
path: root/sys/dev/aha
diff options
context:
space:
mode:
authormdodd <mdodd@FreeBSD.org>2003-03-29 09:46:10 +0000
committermdodd <mdodd@FreeBSD.org>2003-03-29 09:46:10 +0000
commit04e6064fe970390a9363780e9c15d5fba762ca44 (patch)
treef31998e10af8e27e734ada82aa7170e33e1c2719 /sys/dev/aha
parent98b3db7ecaedf32ca9c418f3d2e1b18d911b8864 (diff)
downloadFreeBSD-src-04e6064fe970390a9363780e9c15d5fba762ca44.zip
FreeBSD-src-04e6064fe970390a9363780e9c15d5fba762ca44.tar.gz
Clean up argument comments for bus_dma_tag_create() calls.
Diffstat (limited to 'sys/dev/aha')
-rw-r--r--sys/dev/aha/aha.c83
-rw-r--r--sys/dev/aha/aha_isa.c19
-rw-r--r--sys/dev/aha/aha_mca.c25
3 files changed, 76 insertions, 51 deletions
diff --git a/sys/dev/aha/aha.c b/sys/dev/aha/aha.c
index 4ba7cea..7fe6f25 100644
--- a/sys/dev/aha/aha.c
+++ b/sys/dev/aha/aha.c
@@ -481,28 +481,37 @@ aha_init(struct aha_softc* aha)
*/
/* DMA tag for mapping buffers into device visible space. */
- if (bus_dma_tag_create(aha->parent_dmat, /*alignment*/1, /*boundary*/0,
- /*lowaddr*/BUS_SPACE_MAXADDR,
- /*highaddr*/BUS_SPACE_MAXADDR,
- /*filter*/NULL, /*filterarg*/NULL,
- /*maxsize*/MAXBSIZE, /*nsegments*/AHA_NSEG,
- /*maxsegsz*/BUS_SPACE_MAXSIZE_24BIT,
- /*flags*/BUS_DMA_ALLOCNOW,
- &aha->buffer_dmat) != 0) {
+ if (bus_dma_tag_create( /* parent */ aha->parent_dmat,
+ /* alignment */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ BUS_SPACE_MAXADDR,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ NULL,
+ /* filterarg */ NULL,
+ /* maxsize */ MAXBSIZE,
+ /* nsegments */ AHA_NSEG,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ BUS_DMA_ALLOCNOW,
+ &aha->buffer_dmat) != 0) {
goto error_exit;
}
aha->init_level++;
/* DMA tag for our mailboxes */
- if (bus_dma_tag_create(aha->parent_dmat, /*alignment*/1, /*boundary*/0,
- /*lowaddr*/BUS_SPACE_MAXADDR,
- /*highaddr*/BUS_SPACE_MAXADDR,
- /*filter*/NULL, /*filterarg*/NULL,
- aha->num_boxes * (sizeof(aha_mbox_in_t)
- + sizeof(aha_mbox_out_t)),
- /*nsegments*/1,
- /*maxsegsz*/BUS_SPACE_MAXSIZE_24BIT,
- /*flags*/0, &aha->mailbox_dmat) != 0) {
+ if (bus_dma_tag_create( /* parent */ aha->parent_dmat,
+ /* alignment */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ BUS_SPACE_MAXADDR,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ NULL,
+ /* filterarg */ NULL,
+ /* maxsize */ aha->num_boxes *
+ (sizeof(aha_mbox_in_t) +
+ sizeof(aha_mbox_out_t)),
+ /* nsegments */ 1,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ 0,
+ &aha->mailbox_dmat) != 0) {
goto error_exit;
}
@@ -530,14 +539,19 @@ aha_init(struct aha_softc* aha)
ahainitmboxes(aha);
/* DMA tag for our ccb structures */
- if (bus_dma_tag_create(aha->parent_dmat, /*alignment*/1, /*boundary*/0,
- /*lowaddr*/BUS_SPACE_MAXADDR,
- /*highaddr*/BUS_SPACE_MAXADDR,
- /*filter*/NULL, /*filterarg*/NULL,
- aha->max_ccbs * sizeof(struct aha_ccb),
- /*nsegments*/1,
- /*maxsegsz*/BUS_SPACE_MAXSIZE_24BIT,
- /*flags*/0, &aha->ccb_dmat) != 0) {
+ if (bus_dma_tag_create( /* parent */ aha->parent_dmat,
+ /* alignment */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ BUS_SPACE_MAXADDR,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ NULL,
+ /* filterarg */ NULL,
+ /* maxsize */ aha->max_ccbs *
+ sizeof(struct aha_ccb),
+ /* nsegments */ 1,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ 0,
+ &aha->ccb_dmat) != 0) {
goto error_exit;
}
@@ -560,13 +574,18 @@ aha_init(struct aha_softc* aha)
aha->init_level++;
/* DMA tag for our S/G structures. We allocate in page sized chunks */
- if (bus_dma_tag_create(aha->parent_dmat, /*alignment*/1, /*boundary*/0,
- /*lowaddr*/BUS_SPACE_MAXADDR,
- /*highaddr*/BUS_SPACE_MAXADDR,
- /*filter*/NULL, /*filterarg*/NULL,
- PAGE_SIZE, /*nsegments*/1,
- /*maxsegsz*/BUS_SPACE_MAXSIZE_24BIT,
- /*flags*/0, &aha->sg_dmat) != 0) {
+ if (bus_dma_tag_create( /* parent */ aha->parent_dmat,
+ /* alignment */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ BUS_SPACE_MAXADDR,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ NULL,
+ /* filterarg */ NULL,
+ /* maxsize */ PAGE_SIZE,
+ /* nsegments */ 1,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ 0,
+ &aha->sg_dmat) != 0) {
goto error_exit;
}
diff --git a/sys/dev/aha/aha_isa.c b/sys/dev/aha/aha_isa.c
index 4703246..095bd1b 100644
--- a/sys/dev/aha/aha_isa.c
+++ b/sys/dev/aha/aha_isa.c
@@ -244,13 +244,18 @@ aha_isa_attach(device_t dev)
filter_arg = NULL;
lowaddr = BUS_SPACE_MAXADDR_24BIT;
- if (bus_dma_tag_create(/*parent*/NULL, /*alignemnt*/1, /*boundary*/0,
- lowaddr, /*highaddr*/BUS_SPACE_MAXADDR,
- filter, filter_arg,
- /*maxsize*/BUS_SPACE_MAXSIZE_24BIT,
- /*nsegments*/~0,
- /*maxsegsz*/BUS_SPACE_MAXSIZE_24BIT,
- /*flags*/0, &aha->parent_dmat) != 0) {
+ if (bus_dma_tag_create( /* parent */ NULL,
+ /* alignemnt */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ lowaddr,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ filter,
+ /* filterarg */ filter_arg,
+ /* maxsize */ BUS_SPACE_MAXSIZE_24BIT,
+ /* nsegments */ ~0,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ 0,
+ &aha->parent_dmat) != 0) {
aha_free(aha);
bus_release_resource(dev, SYS_RES_IOPORT, aha->portrid, aha->port);
bus_release_resource(dev, SYS_RES_IRQ, aha->irqrid, aha->irq);
diff --git a/sys/dev/aha/aha_mca.c b/sys/dev/aha/aha_mca.c
index ed1aea0..761504e 100644
--- a/sys/dev/aha/aha_mca.c
+++ b/sys/dev/aha/aha_mca.c
@@ -172,18 +172,19 @@ aha_mca_attach (device_t dev)
isa_dmacascade(rman_get_start(drq));
- error = bus_dma_tag_create(/* parent */ NULL,
- /* alignemnt */ 1,
- /* boundary */ 0,
- BUS_SPACE_MAXADDR_24BIT,
- /* highaddr */ BUS_SPACE_MAXADDR,
- NULL,
- NULL,
- /* maxsize */ BUS_SPACE_MAXSIZE_24BIT,
- /* nsegments */ ~0,
- /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
- /* flags */ 0,
- &sc->parent_dmat);
+ error = bus_dma_tag_create(
+ /* parent */ NULL,
+ /* alignemnt */ 1,
+ /* boundary */ 0,
+ /* lowaddr */ BUS_SPACE_MAXADDR_24BIT,
+ /* highaddr */ BUS_SPACE_MAXADDR,
+ /* filter */ NULL,
+ /* filterarg */ NULL,
+ /* maxsize */ BUS_SPACE_MAXSIZE_24BIT,
+ /* nsegments */ ~0,
+ /* maxsegsz */ BUS_SPACE_MAXSIZE_24BIT,
+ /* flags */ 0,
+ &sc->parent_dmat);
if (error) {
device_printf(dev, "bus_dma_tag_create() failed!\n");
goto bad;
OpenPOWER on IntegriCloud