summaryrefslogtreecommitdiffstats
path: root/sys/contrib
diff options
context:
space:
mode:
authorcy <cy@FreeBSD.org>2017-04-21 01:51:49 +0000
committercy <cy@FreeBSD.org>2017-04-21 01:51:49 +0000
commit0c2446dfd6a518406a545ff12c1c536f0e748ad1 (patch)
tree4fe272ad55d9f353d64e58d0be2cdacda50b3e18 /sys/contrib
parent3cf5b32278c1f90c768904c77318567294150318 (diff)
downloadFreeBSD-src-0c2446dfd6a518406a545ff12c1c536f0e748ad1.zip
FreeBSD-src-0c2446dfd6a518406a545ff12c1c536f0e748ad1.tar.gz
MFC r316809:
Fix a use after free panic in ipfilter's fragment processing. Memory is malloc'd, then a search for a match in the fragment table is made and if the fragment matches, the wrong fragment table is freed, causing a use after free panic. This commit fixes this. A symptom of the problem is a kernel page fault in bcopy() called by ipf_frag_lookup() at line 715 in ip_frag.c. Another symptom is a kernel page fault in ipf_frag_delete() when called by ipf_frag_expire() via ipf_slowtimer().
Diffstat (limited to 'sys/contrib')
-rw-r--r--sys/contrib/ipfilter/netinet/ip_frag.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/contrib/ipfilter/netinet/ip_frag.c b/sys/contrib/ipfilter/netinet/ip_frag.c
index abb3765..14b75e2 100644
--- a/sys/contrib/ipfilter/netinet/ip_frag.c
+++ b/sys/contrib/ipfilter/netinet/ip_frag.c
@@ -474,7 +474,7 @@ ipfr_frag_new(softc, softf, fin, pass, table
IPFR_CMPSZ)) {
RWLOCK_EXIT(lock);
FBUMPD(ifs_exists);
- KFREE(fra);
+ KFREE(fran);
return NULL;
}
OpenPOWER on IntegriCloud