diff options
| author | rwatson <rwatson@FreeBSD.org> | 2002-04-20 14:43:34 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2002-04-20 14:43:34 +0000 |
| commit | 6a296a3a5e37192936b39dfc5320254c9553181e (patch) | |
| tree | 01199fc11099410a6b32586b28e8ce129458a590 /sys/compat/linux/linux_misc.c | |
| parent | 180e7e5269da3118e3e86a54959a1ba69e0b8e89 (diff) | |
| download | FreeBSD-src-6a296a3a5e37192936b39dfc5320254c9553181e.zip FreeBSD-src-6a296a3a5e37192936b39dfc5320254c9553181e.tar.gz | |
Add an XXX: linux_uselib() should be using vn_open() rather than invoking
VOP_OPEN() and doing lots of manual checking. This would further
centralize use of the name functions, and once the MAC code is integrated,
meaning few extraneous MAC checks scattered all over the place. I don't
have time to fix this now, but want to make sure it doesn't get
forgotten. Anyone interested in fixing this should feel free.
Obtained from: TrustedBSD Project
Sponsored by: DARPA, NAI Labs
Diffstat (limited to 'sys/compat/linux/linux_misc.c')
| -rw-r--r-- | sys/compat/linux/linux_misc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index 2bb7b39..51cbd35 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -255,6 +255,10 @@ linux_uselib(struct thread *td, struct linux_uselib_args *args) locked = 0; vp = NULL; + /* + * XXX This code should make use of vn_open(), rather than doing + * all this stuff itself. + */ NDINIT(&ni, LOOKUP, FOLLOW|LOCKLEAF, UIO_USERSPACE, args->library, td); error = namei(&ni); if (error) |
