summaryrefslogtreecommitdiffstats
path: root/sys/cam/scsi
diff options
context:
space:
mode:
authorphk <phk@FreeBSD.org>2003-05-31 16:36:42 +0000
committerphk <phk@FreeBSD.org>2003-05-31 16:36:42 +0000
commitf838ed4668100a8d9c290e153c517b58302931f0 (patch)
treea832cd95eee0962ff4e48feab26926fb0084f921 /sys/cam/scsi
parent8b0354b4be205c23197a460ba9a0136411400dbc (diff)
downloadFreeBSD-src-f838ed4668100a8d9c290e153c517b58302931f0.zip
FreeBSD-src-f838ed4668100a8d9c290e153c517b58302931f0.tar.gz
Don't use return(foo(...)); in a function returning void.
Found by: FlexeLint
Diffstat (limited to 'sys/cam/scsi')
-rw-r--r--sys/cam/scsi/scsi_all.c14
1 files changed, 8 insertions, 6 deletions
diff --git a/sys/cam/scsi/scsi_all.c b/sys/cam/scsi/scsi_all.c
index fe581af..72601da 100644
--- a/sys/cam/scsi/scsi_all.c
+++ b/sys/cam/scsi/scsi_all.c
@@ -2453,10 +2453,12 @@ scsi_mode_sense(struct ccb_scsiio *csio, u_int32_t retries,
u_int8_t page, u_int8_t *param_buf, u_int32_t param_len,
u_int8_t sense_len, u_int32_t timeout)
{
- return(scsi_mode_sense_len(csio, retries, cbfcnp, tag_action, dbd,
- page_code, page, param_buf, param_len, 0,
- sense_len, timeout));
+
+ scsi_mode_sense_len(csio, retries, cbfcnp, tag_action, dbd,
+ page_code, page, param_buf, param_len, 0,
+ sense_len, timeout);
}
+
void
scsi_mode_sense_len(struct ccb_scsiio *csio, u_int32_t retries,
void (*cbfcnp)(struct cam_periph *, union ccb *),
@@ -2518,9 +2520,9 @@ scsi_mode_select(struct ccb_scsiio *csio, u_int32_t retries,
u_int8_t *param_buf, u_int32_t param_len, u_int8_t sense_len,
u_int32_t timeout)
{
- return(scsi_mode_select_len(csio, retries, cbfcnp, tag_action,
- scsi_page_fmt, save_pages, param_buf,
- param_len, 0, sense_len, timeout));
+ scsi_mode_select_len(csio, retries, cbfcnp, tag_action,
+ scsi_page_fmt, save_pages, param_buf,
+ param_len, 0, sense_len, timeout);
}
void
OpenPOWER on IntegriCloud