summaryrefslogtreecommitdiffstats
path: root/sbin
diff options
context:
space:
mode:
authorbdrewery <bdrewery@FreeBSD.org>2015-12-01 19:00:43 +0000
committerbdrewery <bdrewery@FreeBSD.org>2015-12-01 19:00:43 +0000
commitdb2cac2a60d91280013fd96a9b5c1587e032fe38 (patch)
tree62d850c91f2f56ba530c7d7df9067f763091079c /sbin
parent179e96016ad7ebaa44e955d6a0435cd2156c0d5c (diff)
downloadFreeBSD-src-db2cac2a60d91280013fd96a9b5c1587e032fe38.zip
FreeBSD-src-db2cac2a60d91280013fd96a9b5c1587e032fe38.tar.gz
Fix errors being ignored in many phases of the build since the bmake integration.
Say it with me, "I will not chain commands with && in Makefiles" This was originally fixed and explained quite well by bde@ in r36074. The initial bmake integration caused 'set -e' to stop being used which lead to r252419. Later 'set -e' expectations were fixed with bmake in r254980. Because of the && here, errors would be ignored when building in parallel and a dependency failed. Such as bootstrap-tools since it builds everything in parallel. If any tool failed in obj/depend/all, it would just ignore the error and continue to build. This later would result in cascaded errors that only confused the real issue. This could also cause commands after the failed command to still execute, leading to more confusion. This should be fine if the command is in a sub-shell such as: (cmd1 && cmd2) This reverts r252419. MFC after: 1 week Sponsored by: EMC / Isilon Storage Division
Diffstat (limited to 'sbin')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud