diff options
| author | marcel <marcel@FreeBSD.org> | 2003-10-08 07:37:11 +0000 |
|---|---|---|
| committer | marcel <marcel@FreeBSD.org> | 2003-10-08 07:37:11 +0000 |
| commit | aaca042e876b95c95b205d2b17cb0525ac6dfab2 (patch) | |
| tree | c380aa46b80936e65ba22a5e91626f4bca33aeb0 /sbin/savecore/savecore.c | |
| parent | 9a1f9ceacc3a89c938f7bb7aa413646e54e24864 (diff) | |
| download | FreeBSD-src-aaca042e876b95c95b205d2b17cb0525ac6dfab2.zip FreeBSD-src-aaca042e876b95c95b205d2b17cb0525ac6dfab2.tar.gz | |
Revision 1.61 changed the allocation of buffer 'buf' in DoFile() from
the stack to the heap to work around a problem on ia64. Now, roughly
16 months and two compiler updates later, it isn't an issue anymore
in the sense that putting a 1M buffer on the stack just works and we
don't actually need to work around anything anymore.
However, since there's no advantage or need to put the buffer on the
stack (again), this change merely removes the XXX comment describing
that there's an explicit reason for the heap allocation. Hence, this
change is a functional no-op.
PR: ia64/38677
Diffstat (limited to 'sbin/savecore/savecore.c')
| -rw-r--r-- | sbin/savecore/savecore.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/sbin/savecore/savecore.c b/sbin/savecore/savecore.c index c7b4f1f..c7e8a15 100644 --- a/sbin/savecore/savecore.c +++ b/sbin/savecore/savecore.c @@ -221,12 +221,6 @@ DoFile(char *savedir, const char *device) dmpcnt = 0; mediasize = 0; - /* - * XXX On ia64 something breaks when the buffer is put on the - * stack. When the buffer is roughly larger than 128K the read() - * below simply fails with errno=14 (EFAULT). We work around - * this by doing a one-time allocation... - */ if (buf == NULL) { buf = malloc(BUFFERSIZE); if (buf == NULL) { |
