Second of a series of cleanups to libfetch.

This commit introduces the following features:

 a) the fetchStat*() functions, which return meta-information for a
    document, such as size, modification time, etc.

 b) the use of the com_err(3) facilities to report errors.

It also fixes a bunch of style bugs and a few logic bugs and somewhat
improves the man page.

Changed files, in alphabetical order:

 Makefile:
  Don't generate macros in {ftp,http}err.c.

  Generate category fields for the error message lists.

  Compile the error table.

  Install fetch_err.h along with fetch.h.

 common.c:
  Remove the _netdb_errstring() macro, and add FETCH_ERR_NETDB to the
  error code in the _netdb_seterr() macro.

  Add categories to the _netdb_errlist table.

  Report errors through the Common Error library.

 common.h:
  Add the DEBUG macros.

  Add prototype for fetchConnect().

  Remove the prototype for _fetch_errstring(), which is local to common.c

  Add a categroy field to struct fetcherr, and define constants for
  error categories.

  Define macros for _{url,netdb,ftp,http}_seterr().

 errors.et: (new file)
  List error categories.

 fetch.3:
  Document the fetchStat*() functions.

  Move the "unimplemented functionality" comments from NOTES to BUGS.

  Document that applications which use libfetch must also use
  libcom_err, and list existing error codes.

  Undocument fetchLastErr{Code,String}.

  Remove the (empty) DIAGNOSTICS section.

  Mention Eugene Skepner in the AUTHORS section.

 fetch.c:
  Move the DEBUG macros to common.c

  Add fetchStat() and fetchStatURL().

  Generate error messages for URL parser errors, and fix a minor bug
  in the parser.

  Use 'struct url' instead of 'url_t'.

  Remove fetchLastErr{Code,String}.

 fetch.h:
  Use 'struct url' instead of 'url_t', and remove the typedef.

  Define struct url_stat (used by fetchStat()).

  Add prototypes for fetchStat*().

  Remove the declarations for fetchLastErr{Code,String}.

  Include fetch_err.h.

 fetch_err.et: (new file)
  Error table for libfetch.

 file.c:
  Add fetchStatFile().

  Use 'struct url' instead of 'url_t'.

 ftp.c:
  Add fetchStatFTP().

  Use 'struct url' instead of 'url_t'.

  Don't use fetchLastErrCode.

 ftp.errors:
  Add categories to all error messages.

 http.c:
  Add fetchStatHTTP().

  Use 'struct url' instead of 'url_t'.

  Don't use fetchLastErr{Code,Text}.

 http.errors:
  Add categories to all error messages.

Prompted by: jkh and Eugene Skepner
Numerous sugestions from: Garett Wollman and Eugene Skepner

1 files changed, 16 insertions, 7 deletions

diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c
index aea3d1d..973584c 100644
--- a/lib/libfetch/http.c
+++ b/lib/libfetch/http.c
@@ -25,7 +25,7 @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
- *	$Id: http.c,v 1.5 1998/08/17 09:30:19 des Exp $
+ *	$Id: http.c,v 1.6 1998/11/05 19:48:17 des Exp $
  */
 
 /*
@@ -78,7 +78,7 @@
 
 #include "fetch.h"
 #include "common.h"
-#include "httperr.c"
+#include "httperr.inc"
 
 #ifndef NDEBUG
 #define DEBUG(x) do x; while (0)
@@ -300,10 +300,10 @@ _http_auth(char *usr, char *pwd)
 }
 
 /*
- * retrieve a file by HTTP
+ * Retrieve a file by HTTP
  */
 FILE *
-fetchGetHTTP(url_t *URL, char *flags)
+fetchGetHTTP(struct url *URL, char *flags)
 {
     int sd = -1, err, i, enc = ENC_NONE;
     struct cookie *c;
@@ -389,8 +389,7 @@ fetchGetHTTP(url_t *URL, char *flags)
     
     /* add code to handle redirects later */
     if (err != 200) {
-	fetchLastErrCode = err;
-	fetchLastErrText = _http_errstring(err);
+	_http_seterr(err);
 	goto fouch;
     }
 
@@ -452,8 +451,18 @@ fouch:
 }
 
 FILE *
-fetchPutHTTP(url_t *URL, char *flags)
+fetchPutHTTP(struct url *URL, char *flags)
 {
     warnx("fetchPutHTTP(): not implemented");
     return NULL;
 }
+
+/*
+ * Get an HTTP document's metadata
+ */
+int
+fetchStatHTTP(struct url *url, struct url_stat *us, char *flags)
+{
+    warnx("fetchStatHTTP(): not implemented");
+    return -1;
+}