Second of a series of cleanups to libfetch.

This commit introduces the following features:

 a) the fetchStat*() functions, which return meta-information for a
    document, such as size, modification time, etc.

 b) the use of the com_err(3) facilities to report errors.

It also fixes a bunch of style bugs and a few logic bugs and somewhat
improves the man page.

Changed files, in alphabetical order:

 Makefile:
  Don't generate macros in {ftp,http}err.c.

  Generate category fields for the error message lists.

  Compile the error table.

  Install fetch_err.h along with fetch.h.

 common.c:
  Remove the _netdb_errstring() macro, and add FETCH_ERR_NETDB to the
  error code in the _netdb_seterr() macro.

  Add categories to the _netdb_errlist table.

  Report errors through the Common Error library.

 common.h:
  Add the DEBUG macros.

  Add prototype for fetchConnect().

  Remove the prototype for _fetch_errstring(), which is local to common.c

  Add a categroy field to struct fetcherr, and define constants for
  error categories.

  Define macros for _{url,netdb,ftp,http}_seterr().

 errors.et: (new file)
  List error categories.

 fetch.3:
  Document the fetchStat*() functions.

  Move the "unimplemented functionality" comments from NOTES to BUGS.

  Document that applications which use libfetch must also use
  libcom_err, and list existing error codes.

  Undocument fetchLastErr{Code,String}.

  Remove the (empty) DIAGNOSTICS section.

  Mention Eugene Skepner in the AUTHORS section.

 fetch.c:
  Move the DEBUG macros to common.c

  Add fetchStat() and fetchStatURL().

  Generate error messages for URL parser errors, and fix a minor bug
  in the parser.

  Use 'struct url' instead of 'url_t'.

  Remove fetchLastErr{Code,String}.

 fetch.h:
  Use 'struct url' instead of 'url_t', and remove the typedef.

  Define struct url_stat (used by fetchStat()).

  Add prototypes for fetchStat*().

  Remove the declarations for fetchLastErr{Code,String}.

  Include fetch_err.h.

 fetch_err.et: (new file)
  Error table for libfetch.

 file.c:
  Add fetchStatFile().

  Use 'struct url' instead of 'url_t'.

 ftp.c:
  Add fetchStatFTP().

  Use 'struct url' instead of 'url_t'.

  Don't use fetchLastErrCode.

 ftp.errors:
  Add categories to all error messages.

 http.c:
  Add fetchStatHTTP().

  Use 'struct url' instead of 'url_t'.

  Don't use fetchLastErr{Code,Text}.

 http.errors:
  Add categories to all error messages.

Prompted by: jkh and Eugene Skepner
Numerous sugestions from: Garett Wollman and Eugene Skepner

1 files changed, 22 insertions, 11 deletions

diff --git a/lib/libfetch/ftp.c b/lib/libfetch/ftp.c
index 1899d03..81da7f8 100644
--- a/lib/libfetch/ftp.c
+++ b/lib/libfetch/ftp.c
@@ -25,7 +25,7 @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
- *	$Id: ftp.c,v 1.5 1998/08/17 09:30:19 des Exp $
+ *	$Id: ftp.c,v 1.6 1998/11/05 19:48:17 des Exp $
  */
 
 /*
@@ -71,7 +71,7 @@
 
 #include "fetch.h"
 #include "common.h"
-#include "ftperr.c"
+#include "ftperr.inc"
 
 #define FTP_DEFAULT_TO_ANONYMOUS
 #define FTP_ANONYMOUS_USER	"ftp"
@@ -88,7 +88,7 @@
 
 #define ENDL "\r\n"
 
-static url_t cached_host;
+static struct url cached_host;
 static FILE *cached_socket;
 
 static char *_ftp_last_reply;
@@ -101,6 +101,7 @@ _ftp_chkerr(FILE *s, int *e)
 {
     char *line;
     size_t len;
+    int err;
 
     if (e)
 	*e = 0;
@@ -122,14 +123,15 @@ _ftp_chkerr(FILE *s, int *e)
     
     if (!isdigit(line[1]) || !isdigit(line[1])
 	|| !isdigit(line[2]) || (line[3] != ' ')) {
-	_ftp_seterr(-1);
+	_ftp_seterr(0);
 	return -1;
     }
 
-    _ftp_seterr((line[0] - '0') * 100 + (line[1] - '0') * 10 + (line[2] - '0'));
+    err = (line[0] - '0') * 100 + (line[1] - '0') * 10 + (line[2] - '0');
+    _ftp_seterr(err);
 
     if (e)
-	*e = fetchLastErrCode;
+	*e = err;
 
     return (line[0] == '2') - 1;
 }
@@ -365,7 +367,7 @@ _ftp_disconnect(FILE *f)
  * Check if we're already connected
  */
 static int
-_ftp_isconnected(url_t *url)
+_ftp_isconnected(struct url *url)
 {
     return (cached_socket
 	    && (strcmp(url->host, cached_host.host) == 0)
@@ -378,7 +380,7 @@ _ftp_isconnected(url_t *url)
  * FTP session
  */
 static FILE *
-fetchXxxFTP(url_t *url, char *oper, char *mode, char *flags)
+fetchXxxFTP(struct url *url, char *oper, char *mode, char *flags)
 {
     FILE *cf = NULL;
     int e;
@@ -402,7 +404,7 @@ fetchXxxFTP(url_t *url, char *oper, char *mode, char *flags)
 	if (cached_socket)
 	    _ftp_disconnect(cached_socket);
 	cached_socket = cf;
-	memcpy(&cached_host, url, sizeof(url_t));
+	memcpy(&cached_host, url, sizeof(struct url));
     }
 
     /* initiate the transfer */
@@ -413,15 +415,24 @@ fetchXxxFTP(url_t *url, char *oper, char *mode, char *flags)
  * Itsy bitsy teeny weenie
  */
 FILE *
-fetchGetFTP(url_t *url, char *flags)
+fetchGetFTP(struct url *url, char *flags)
 {
     return fetchXxxFTP(url, "RETR", "r", flags);
 }
 
 FILE *
-fetchPutFTP(url_t *url, char *flags)
+fetchPutFTP(struct url *url, char *flags)
 {
     if (flags && strchr(flags, 'a'))
 	return fetchXxxFTP(url, "APPE", "w", flags);
     else return fetchXxxFTP(url, "STOR", "w", flags);
 }
+
+extern void warnx(char *fmt, ...);
+int
+fetchStatFTP(struct url *url, struct url_stat *us, char *flags)
+{
+    warnx("fetchStatFTP(): not implemented");
+    return -1;
+}
+