First of a series of cleanups to libfetch. Changed files, in

alphabetical order:

 Makefile:
  Add common.c to SRCS.

  Make debugging easier by making 'CFLAGS += -DNDEBUG' conditional on DEBUG

  Don't declare struct {ftp,http}err in {ftp,http}err.c; use struct fetcherr
  instead.

 README:
  Remove the todo list, which is out of date anyway.

 common.c: (new file)
  Gather utility functions in this file.

  Merge the error reporting functions intp _fetch_errstring(),
  _fetch_seterr() and _fetch_syserr().

  Set fetchLastErrCode and fetchLastErrText appropriately when fetchConnect
  fails.

 common.h: (new file)
  Gather internal prototypes and structures in this files.

 fetch.3:
  Undocument fetchFreeURL().

  Document a few more known bugs.

  Document fetchLastErrCode and fetchLastErrText.

 fetch.c:
  Add descriptive comments to all functions that lacked them.

  Move fetchConnect() to common.c.

  Obviate the need for fetchFreeURL(), and remove it.

 fetch.h:
  Modify struct url_t so the document part is at the end.

 ftp.c:
  Remove code that is duplicated elsewhere.

 http.c:
  Remove code that is duplicated elsewhere.

Prompted by: jkh

1 files changed, 3 insertions, 14 deletions

diff --git a/lib/libfetch/README b/lib/libfetch/README
index ce50f56..7b85376 100644
--- a/lib/libfetch/README
+++ b/lib/libfetch/README
@@ -3,19 +3,8 @@ library and provide a new, unified backend for all fetch(1),
 pkg_add(1) and sysinstall(8).
 
 Note that this is very much work in progress. It compiles (with a few
-warnings), but there is much left to be implemented. Amongst other
-items:
-
-  * The man page needs work. Really. I mean it. Now.
-
-  * HTTP authentication doesn't work. I'm not sure if I bungled http.c
-    or fubared base64.c (which was ripped from MIT fetch(1)).
-
-  * The library needs a decent interface for reporting errors. I've
-    started on something (sending back an error code in the url_t that
-    was sent in) but we're Not There (tm) yet.
-
-Comments, patches etc. of all kinds are welcome, but please don't
-commit anything without talking to me first.
+warnings), but there is much left to be implemented. Comments, patches
+etc. of all kinds are welcome, but please don't commit anything
+without talking to me first.
 
 		-- Dag-Erling C. Smørgrav (des@FreeBSD.org)