summaryrefslogtreecommitdiffstats
path: root/lib/libdisk/disklabel.c
diff options
context:
space:
mode:
authorjkh <jkh@FreeBSD.org>2001-05-13 20:08:54 +0000
committerjkh <jkh@FreeBSD.org>2001-05-13 20:08:54 +0000
commit5b33a2af7cc4f8e49951b70e1fc5b616876450a6 (patch)
treeac04e3b0eea5f057863e3c3ee8b4637d07f2adb8 /lib/libdisk/disklabel.c
parentc6db5e77fc9682b938a8776c6e2c8cbda527cd2c (diff)
downloadFreeBSD-src-5b33a2af7cc4f8e49951b70e1fc5b616876450a6.zip
FreeBSD-src-5b33a2af7cc4f8e49951b70e1fc5b616876450a6.tar.gz
+ add u_long sector_size to struct disk (documented in libdisk.3)
+ make Open_Disk sense the sector size by trying 512, 1024 and 2048 in this order. This makes the kernel note that dscheck(cd1): bio_bcount 512 is not on a sector boundary (ssize 2048) dscheck(cd1): bio_bcount 1024 is not on a sector boundary (ssize 2048) if 2048 is the sector size. If this worries anyone: the message is from /usr/src/sys/kern/subr_diskslice.c and shutups are to be placed there. + Have read_block and write_block use an additional parameter, the sector size. + replace all barfout calls with return NULL, 0, __LINE__, etc. Note that this does NOT emit diagnostics. More often than not, you don't want library functions to scribble on stderr -- it may not even be available. The right thing is to propagate the error condition to upper management. The app should take care of errors. + use d1->sector_size instead of 512 in various places. I've left many places untouched, especially those writing MBRs. I simply added another arg hardcoded as 512. This is because I would not know what I'm doing... I felt this approach would be reasonably backward compatible and not introduce any new bugs in critical software. Famous last words. Messing with MBRs might soon put me in the same screwup meister category as, uh, never mind. :-) + bump the max no of disks from 20 to 32 (due to PR 24503). PR: 8434 / 8436 / 24503 Submitted by: Jens Schweikhardt <schweikh@schweikhardt.net>
Diffstat (limited to 'lib/libdisk/disklabel.c')
-rw-r--r--lib/libdisk/disklabel.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libdisk/disklabel.c b/lib/libdisk/disklabel.c
index 69dc2cc..80bd848 100644
--- a/lib/libdisk/disklabel.c
+++ b/lib/libdisk/disklabel.c
@@ -17,11 +17,11 @@
#include "libdisk.h"
struct disklabel *
-read_disklabel(int fd, daddr_t block)
+read_disklabel(int fd, daddr_t block, u_long sector_size)
{
struct disklabel *dp;
- dp = (struct disklabel *) read_block(fd, block);
+ dp = (struct disklabel *) read_block(fd, block, sector_size);
if (dp->d_magic != DISKMAGIC)
return 0;
if (dp->d_magic2 != DISKMAGIC)
OpenPOWER on IntegriCloud