diff options
| author | truckman <truckman@FreeBSD.org> | 2016-05-25 07:13:53 +0000 |
|---|---|---|
| committer | truckman <truckman@FreeBSD.org> | 2016-05-25 07:13:53 +0000 |
| commit | f3df1825c6c71de3469c478ce08eea56b01aa019 (patch) | |
| tree | c4b7bd3e0df35c338013b111eba33bd975ad3f72 /lib/libc | |
| parent | 82a3029754321218d2c91bf6c32481eb43251a5c (diff) | |
| download | FreeBSD-src-f3df1825c6c71de3469c478ce08eea56b01aa019.zip FreeBSD-src-f3df1825c6c71de3469c478ce08eea56b01aa019.tar.gz | |
Fix Coverity CID 1016714 Resource leak in process_file_actions_entry()
Don't leak a file descriptor of _dup2() fails (shouldn't happen).
Reported by: Coverity
CID: 1016714
MFC after: 1 week
Diffstat (limited to 'lib/libc')
| -rw-r--r-- | lib/libc/gen/posix_spawn.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/libc/gen/posix_spawn.c b/lib/libc/gen/posix_spawn.c index c65a730..2838c5c 100644 --- a/lib/libc/gen/posix_spawn.c +++ b/lib/libc/gen/posix_spawn.c @@ -140,7 +140,7 @@ process_spawnattr(const posix_spawnattr_t sa) static int process_file_actions_entry(posix_spawn_file_actions_entry_t *fae) { - int fd; + int fd, saved_errno; switch (fae->fae_action) { case FAE_OPEN: @@ -149,8 +149,11 @@ process_file_actions_entry(posix_spawn_file_actions_entry_t *fae) if (fd < 0) return (errno); if (fd != fae->fae_fildes) { - if (_dup2(fd, fae->fae_fildes) == -1) - return (errno); + if (_dup2(fd, fae->fae_fildes) == -1) { + saved_errno = errno; + (void)_close(fd); + return (saved_errno); + } if (_close(fd) != 0) { if (errno == EBADF) return (EBADF); |
