summaryrefslogtreecommitdiffstats
path: root/lib/libc/stdlib/getenv.c
diff options
context:
space:
mode:
authortruckman <truckman@FreeBSD.org>2016-06-08 02:14:05 +0000
committertruckman <truckman@FreeBSD.org>2016-06-08 02:14:05 +0000
commitb2dadb0e9ad395bb0a043e780c3c28bed51ae8ba (patch)
tree98cd09044716aaed8bc1f826abe09203c871f9c8 /lib/libc/stdlib/getenv.c
parent17ff1e5b262125b4d633e4d2f266a27e83cadb49 (diff)
downloadFreeBSD-src-b2dadb0e9ad395bb0a043e780c3c28bed51ae8ba.zip
FreeBSD-src-b2dadb0e9ad395bb0a043e780c3c28bed51ae8ba.tar.gz
Fix a (false positive?) Argument cannot be negative coverity defect.
Rather than guarding close(fd) with an fd >= 0 test and setting fd to -1 when it is closed to avoid a potential double-close, just move the close() call after the conditional "goto make_token". This moves the close() call totally outside the loop to avoid the possibility of calling it twice. This should also prevent a Coverity warning about checking fd for validity after it was previously passed to read(). Reported by: Coverity CID: 1355335 MFC after: 1 week X-MFC with: r299484
Diffstat (limited to 'lib/libc/stdlib/getenv.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud