diff options
author | brooks <brooks@FreeBSD.org> | 2016-06-22 21:11:27 +0000 |
---|---|---|
committer | brooks <brooks@FreeBSD.org> | 2016-06-22 21:11:27 +0000 |
commit | ecead64b414c307960363fbbb9925c7dd8a20fdd (patch) | |
tree | 140928f4a0a736777b084ada0a5c3d1ccc4401e4 /lib/libc/riscv/sys | |
parent | a8b2bf94923e9d19ec8834944663693093600a6b (diff) | |
download | FreeBSD-src-ecead64b414c307960363fbbb9925c7dd8a20fdd.zip FreeBSD-src-ecead64b414c307960363fbbb9925c7dd8a20fdd.tar.gz |
Replace use of the pipe(2) system call with pipe2(2) with a zero flags
value.
This eliminates the need for machine dependant assembly wrappers for
pipe(2).
It also make passing an invalid address to pipe(2) return EFAULT rather
than triggering a segfault. Document this behavior (which was already
true for pipe2(2), but undocumented).
Reviewed by: andrew
Approved by: re (gjb)
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D6815
Diffstat (limited to 'lib/libc/riscv/sys')
-rw-r--r-- | lib/libc/riscv/sys/Makefile.inc | 1 | ||||
-rw-r--r-- | lib/libc/riscv/sys/pipe.S | 57 |
2 files changed, 0 insertions, 58 deletions
diff --git a/lib/libc/riscv/sys/Makefile.inc b/lib/libc/riscv/sys/Makefile.inc index 4332596..cde78d5 100644 --- a/lib/libc/riscv/sys/Makefile.inc +++ b/lib/libc/riscv/sys/Makefile.inc @@ -4,7 +4,6 @@ SRCS+= trivial-vdso_tc.c #MDASM= ptrace.S MDASM= cerror.S \ - pipe.S \ shmat.S \ sigreturn.S \ syscall.S \ diff --git a/lib/libc/riscv/sys/pipe.S b/lib/libc/riscv/sys/pipe.S deleted file mode 100644 index b265a6a..0000000 --- a/lib/libc/riscv/sys/pipe.S +++ /dev/null @@ -1,57 +0,0 @@ -/*- - * Copyright (c) 2015 Ruslan Bukin <br@bsdpad.com> - * All rights reserved. - * - * Portions of this software were developed by SRI International and the - * University of Cambridge Computer Laboratory under DARPA/AFRL contract - * FA8750-10-C-0237 ("CTSRD"), as part of the DARPA CRASH research programme. - * - * Portions of this software were developed by the University of Cambridge - * Computer Laboratory as part of the CTSRD Project, with support from the - * UK Higher Education Innovation Fund (HEIF). - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#include <machine/asm.h> -__FBSDID("$FreeBSD$"); - -#include "SYS.h" - -ENTRY(__sys_pipe) - WEAK_REFERENCE(__sys_pipe, pipe) - - /* Backup the pointer passed to us */ - mv a2, a0 - - /* Make the syscall */ - _SYSCALL(pipe) - bnez t0, cerror - - /* Store the result */ - sw a0, 0(a2) - sw a1, 4(a2) - - /* Return */ - li a0, 0 - ret -END(__sys_pipe) |