diff options
author | rrs <rrs@FreeBSD.org> | 2015-02-15 13:57:44 +0000 |
---|---|---|
committer | rrs <rrs@FreeBSD.org> | 2015-02-15 13:57:44 +0000 |
commit | 3a3039379c4ae88bfbe7b15ad2c3f92f3e976f57 (patch) | |
tree | bd7dfda1515631e8e1f2de4b3f4b52a79075d78a /lib/libc/regex/regcomp.c | |
parent | a7664682b11a7ffb5e7daf71954e7b656e16c4ac (diff) | |
download | FreeBSD-src-3a3039379c4ae88bfbe7b15ad2c3f92f3e976f57.zip FreeBSD-src-3a3039379c4ae88bfbe7b15ad2c3f92f3e976f57.tar.gz |
MFC of r278472
This fixes a bug in the way that the LLE timers for nd6
and arp were being used. They basically would pass in the
mutex to the callout_init. Because they used this method
to the callout system, it was possible to "stop" the callout.
When flushing the table and you stopped the running callout, the
callout_stop code would return 1 indicating that it was going
to stop the callout (that was about to run on the callout_wheel blocked
by the function calling the stop). Now when 1 was returned, it would
lower the reference count one extra time for the stopped timer, then
a few lines later delete the memory. Of course the callout_wheel was
stuck in the lock code and would then crash since it was accessing
freed memory. By using callout_init(c, 1) we always get a 0 back
and the reference counting bug does not rear its head. We do have
to make a few adjustments to the callouts themselves though to make
sure it does the proper thing if rescheduled as well as gets the lock.
Sponsored by: Netflix Inc.
Diffstat (limited to 'lib/libc/regex/regcomp.c')
0 files changed, 0 insertions, 0 deletions