Sweep through the tree fixing mmap() usage:

  - Use MAP_FAILED instead of the constant -1 to indicate
    failure (required by POSIX).
  - Removed flag arguments of '0' (required by POSIX).
  - Fixed code which expected an error return of 0.
  - Fixed code which thought any address with the high bit set
    was an error.
  - Check for failure where no checks were present.

Discussed with:	bde

1 files changed, 2 insertions, 2 deletions

diff --git a/lib/libc/gen/nlist.c b/lib/libc/gen/nlist.c
index 7292452..7415cbe 100644
--- a/lib/libc/gen/nlist.c
+++ b/lib/libc/gen/nlist.c
@@ -99,8 +99,8 @@ __fdnlist(fd, list)
 	 * without making the memory allocation permanent as with
 	 * malloc/free (i.e., munmap will return it to the system).
 	 */
-	a_out_mmap = mmap(NULL, (size_t)st.st_size, PROT_READ, 0, fd, (off_t)0);
-	if (a_out_mmap == (char *)-1)
+	a_out_mmap = mmap(NULL, (size_t)st.st_size, PROT_READ, MAP_PRIVATE, fd, (off_t)0);
+	if (a_out_mmap == MAP_FAILED)
 		return (-1);
 
 	exec = (struct exec *)a_out_mmap;