libarchive 2.0

  * libarchive_test program exercises many of the core features
  * Refactored old "read_extract" into new "archive_write_disk", which
    uses archive_write methods to put entries onto disk.  In particular,
    you can now use archive_write_disk to create objects on disk
    without having an archive available.
  * Pushed some security checks from bsdtar down into libarchive, where
    they can be better optimized.
  * Rearchitected the logic for creating objects on disk to reduce
    the number of system calls.  Several common cases now use a
    minimum number of system calls.
  * Virtualized some internal interfaces to provide a clearer separation
    of read and write handling and make it simpler to override key
    methods.
  * New "empty" format reader.
  * Corrected return types (this ABI breakage required the "2.0" version bump)
  * Many bug fixes.

1 files changed, 39 insertions, 35 deletions

diff --git a/lib/libarchive/archive_read_support_compression_gzip.c b/lib/libarchive/archive_read_support_compression_gzip.c
index b64e1d2..49e209d 100644
--- a/lib/libarchive/archive_read_support_compression_gzip.c
+++ b/lib/libarchive/archive_read_support_compression_gzip.c
@@ -46,6 +46,7 @@ __FBSDID("$FreeBSD$");
 
 #include "archive.h"
 #include "archive_private.h"
+#include "archive_read_private.h"
 
 #ifdef HAVE_ZLIB_H
 struct private_data {
@@ -58,19 +59,20 @@ struct private_data {
 	char		 header_done;
 };
 
-static int	finish(struct archive *);
-static ssize_t	read_ahead(struct archive *, const void **, size_t);
-static ssize_t	read_consume(struct archive *, size_t);
-static int	drive_decompressor(struct archive *a, struct private_data *);
+static int	finish(struct archive_read *);
+static ssize_t	read_ahead(struct archive_read *, const void **, size_t);
+static ssize_t	read_consume(struct archive_read *, size_t);
+static int	drive_decompressor(struct archive_read *a, struct private_data *);
 #endif
 
 /* These two functions are defined even if we lack zlib.  See below. */
 static int	bid(const void *, size_t);
-static int	init(struct archive *, const void *, size_t);
+static int	init(struct archive_read *, const void *, size_t);
 
 int
-archive_read_support_compression_gzip(struct archive *a)
+archive_read_support_compression_gzip(struct archive *_a)
 {
+	struct archive_read *a = (struct archive_read *)_a;
 	return (__archive_read_register_compression(a, bid, init));
 }
 
@@ -135,7 +137,7 @@ bid(const void *buff, size_t len)
  * archives and emit a useful message.
  */
 static int
-init(struct archive *a, const void *buff, size_t n)
+init(struct archive_read *a, const void *buff, size_t n)
 {
 	(void)a;	/* UNUSED */
 	(void)buff;	/* UNUSED */
@@ -153,19 +155,19 @@ init(struct archive *a, const void *buff, size_t n)
  * Setup the callbacks.
  */
 static int
-init(struct archive *a, const void *buff, size_t n)
+init(struct archive_read *a, const void *buff, size_t n)
 {
 	struct private_data *state;
 	int ret;
 
-	a->compression_code = ARCHIVE_COMPRESSION_GZIP;
-	a->compression_name = "gzip";
+	a->archive.compression_code = ARCHIVE_COMPRESSION_GZIP;
+	a->archive.compression_name = "gzip";
 
 	state = (struct private_data *)malloc(sizeof(*state));
 	if (state == NULL) {
-		archive_set_error(a, ENOMEM,
+		archive_set_error(&a->archive, ENOMEM,
 		    "Can't allocate data for %s decompression",
-		    a->compression_name);
+		    a->archive.compression_name);
 		return (ARCHIVE_FATAL);
 	}
 	memset(state, 0, sizeof(*state));
@@ -180,9 +182,9 @@ init(struct archive *a, const void *buff, size_t n)
 	state->stream.avail_out = state->uncompressed_buffer_size;
 
 	if (state->uncompressed_buffer == NULL) {
-		archive_set_error(a, ENOMEM,
+		archive_set_error(&a->archive, ENOMEM,
 		    "Can't allocate %s decompression buffers",
-		    a->compression_name);
+		    a->archive.compression_name);
 		free(state);
 		return (ARCHIVE_FATAL);
 	}
@@ -220,25 +222,26 @@ init(struct archive *a, const void *buff, size_t n)
 	}
 
 	/* Library setup failed: Clean up. */
-	archive_set_error(a, ARCHIVE_ERRNO_MISC,
-	    "Internal error initializing %s library", a->compression_name);
+	archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
+	    "Internal error initializing %s library",
+	    a->archive.compression_name);
 	free(state->uncompressed_buffer);
 	free(state);
 
 	/* Override the error message if we know what really went wrong. */
 	switch (ret) {
 	case Z_STREAM_ERROR:
-		archive_set_error(a, ARCHIVE_ERRNO_MISC,
+		archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
 		    "Internal error initializing compression library: "
 		    "invalid setup parameter");
 		break;
 	case Z_MEM_ERROR:
-		archive_set_error(a, ENOMEM,
+		archive_set_error(&a->archive, ENOMEM,
 		    "Internal error initializing compression library: "
 		    "out of memory");
 		break;
 	case Z_VERSION_ERROR:
-		archive_set_error(a, ARCHIVE_ERRNO_MISC,
+		archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
 		    "Internal error initializing compression library: "
 		    "invalid library version");
 		break;
@@ -252,7 +255,7 @@ init(struct archive *a, const void *buff, size_t n)
  * as necessary.
  */
 static ssize_t
-read_ahead(struct archive *a, const void **p, size_t min)
+read_ahead(struct archive_read *a, const void **p, size_t min)
 {
 	struct private_data *state;
 	int read_avail, was_avail, ret;
@@ -260,7 +263,7 @@ read_ahead(struct archive *a, const void **p, size_t min)
 	state = (struct private_data *)a->compression_data;
 	was_avail = -1;
 	if (!a->client_reader) {
-		archive_set_error(a, ARCHIVE_ERRNO_PROGRAMMER,
+		archive_set_error(&a->archive, ARCHIVE_ERRNO_PROGRAMMER,
 		    "No read callback is registered?  "
 		    "This is probably an internal programming error.");
 		return (ARCHIVE_FATAL);
@@ -294,12 +297,12 @@ read_ahead(struct archive *a, const void **p, size_t min)
  * Mark a previously-returned block of data as read.
  */
 static ssize_t
-read_consume(struct archive *a, size_t n)
+read_consume(struct archive_read *a, size_t n)
 {
 	struct private_data *state;
 
 	state = (struct private_data *)a->compression_data;
-	a->file_position += n;
+	a->archive.file_position += n;
 	state->read_next += n;
 	if (state->read_next > state->stream.next_out)
 		__archive_errx(1, "Request to consume too many "
@@ -311,7 +314,7 @@ read_consume(struct archive *a, size_t n)
  * Clean up the decompressor.
  */
 static int
-finish(struct archive *a)
+finish(struct archive_read *a)
 {
 	struct private_data *state;
 	int ret;
@@ -322,8 +325,9 @@ finish(struct archive *a)
 	case Z_OK:
 		break;
 	default:
-		archive_set_error(a, ARCHIVE_ERRNO_MISC,
-		    "Failed to clean up %s compressor", a->compression_name);
+		archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
+		    "Failed to clean up %s compressor",
+		    a->archive.compression_name);
 		ret = ARCHIVE_FATAL;
 	}
 
@@ -332,7 +336,7 @@ finish(struct archive *a)
 
 	a->compression_data = NULL;
 	if (a->client_closer != NULL)
-		(a->client_closer)(a, a->client_data);
+		(a->client_closer)(&a->archive, a->client_data);
 
 	return (ret);
 }
@@ -342,7 +346,7 @@ finish(struct archive *a)
  * blocks as necessary.
  */
 static int
-drive_decompressor(struct archive *a, struct private_data *state)
+drive_decompressor(struct archive_read *a, struct private_data *state)
 {
 	ssize_t ret;
 	int decompressed, total_decompressed;
@@ -356,7 +360,7 @@ drive_decompressor(struct archive *a, struct private_data *state)
 	total_decompressed = 0;
 	for (;;) {
 		if (state->stream.avail_in == 0) {
-			ret = (a->client_reader)(a, a->client_data,
+			ret = (a->client_reader)(&a->archive, a->client_data,
 			    (const void **)&state->stream.next_in);
 			if (ret < 0) {
 				/*
@@ -366,12 +370,12 @@ drive_decompressor(struct archive *a, struct private_data *state)
 				goto fatal;
 			}
 			if (ret == 0  &&  total_decompressed == 0) {
-				archive_set_error(a, EIO,
+				archive_set_error(&a->archive, EIO,
 				    "Premature end of %s compressed data",
-				    a->compression_name);
+				    a->archive.compression_name);
 				return (ARCHIVE_FATAL);
 			}
-			a->raw_position += ret;
+			a->archive.raw_position += ret;
 			state->stream.avail_in = ret;
 		}
 
@@ -520,7 +524,7 @@ drive_decompressor(struct archive *a, struct private_data *state)
 				return (ARCHIVE_OK);
 			default:
 				/* Any other return value is an error. */
-				archive_set_error(a, ARCHIVE_ERRNO_MISC,
+				archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
 				    "gzip decompression failed (%s)",
 				    state->stream.msg);
 				goto fatal;
@@ -531,8 +535,8 @@ drive_decompressor(struct archive *a, struct private_data *state)
 
 	/* Return a fatal error. */
 fatal:
-	archive_set_error(a, ARCHIVE_ERRNO_MISC, "%s decompression failed",
-	    a->compression_name);
+	archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC,
+	    "%s decompression failed", a->archive.compression_name);
 	return (ARCHIVE_FATAL);
 }