summaryrefslogtreecommitdiffstats
path: root/etc
diff options
context:
space:
mode:
authorpeter <peter@FreeBSD.org>2001-07-27 16:23:53 +0000
committerpeter <peter@FreeBSD.org>2001-07-27 16:23:53 +0000
commit600c4d98710cfdb371f31b2c7b3cec66f6592ad0 (patch)
tree7357ced7c0cd182afdb1b15dae5c3ad3f9b46392 /etc
parent0774b50fdd3657530f23ba08438e7072c25f0f85 (diff)
downloadFreeBSD-src-600c4d98710cfdb371f31b2c7b3cec66f6592ad0.zip
FreeBSD-src-600c4d98710cfdb371f31b2c7b3cec66f6592ad0.tar.gz
Take -Wconversion out of BDECFLAGS. It is not particularly useful for
us anyway because it doesn't work right on the x86 and alpha. On K&R code, small ints would be promoted to int. ANSI-C doesn't require this and the small ints can be passed taking 8 or 16 bits of stack space. However, the x86 abi that we use *does* promote to 32 bit, and the alpha ABI passes them in 64 bit registers so we dont have that aspect of the problem here. Losing float precision by having it cast down to int because the funtion prototype specifies int is the least of our problems. -Wmissing-prototypes helps here anyway.
Diffstat (limited to 'etc')
-rw-r--r--etc/defaults/make.conf5
1 files changed, 3 insertions, 2 deletions
diff --git a/etc/defaults/make.conf b/etc/defaults/make.conf
index 3a0f1b4..1fd2ffa 100644
--- a/etc/defaults/make.conf
+++ b/etc/defaults/make.conf
@@ -50,10 +50,11 @@
#
# BDECFLAGS are a set of gcc warning settings that Bruce Evans has suggested
# for use in developing FreeBSD and testing changes. They can be used by
-# putting "CFLAGS+=${BDECFLAGS}" in /etc/make.conf.
+# putting "CFLAGS+=${BDECFLAGS}" in /etc/make.conf. -Wconversion is not
+# included here due to compiler bugs, eg: mkdir()'s mode_t argument.
#
BDECFLAGS= -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align \
- -Wcast-qual -Wchar-subscripts -Wconversion -Winline \
+ -Wcast-qual -Wchar-subscripts -Winline \
-Wmissing-prototypes -Wnested-externs -Wpointer-arith \
-Wredundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings
#
OpenPOWER on IntegriCloud