diff options
| author | ngie <ngie@FreeBSD.org> | 2016-04-20 20:43:05 +0000 |
|---|---|---|
| committer | ngie <ngie@FreeBSD.org> | 2016-04-20 20:43:05 +0000 |
| commit | 9ecbe9199d47cc80abff1123c80ed8384fa9a0ff (patch) | |
| tree | 1499b6d06d571847519b9d965a2f9e30bf200c3f /contrib/netbsd-tests | |
| parent | e3c8c9cbf79da3428e922ae6e6971645e1ff8bda (diff) | |
| download | FreeBSD-src-9ecbe9199d47cc80abff1123c80ed8384fa9a0ff.zip FreeBSD-src-9ecbe9199d47cc80abff1123c80ed8384fa9a0ff.tar.gz | |
Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c
- Ensure socket(2) calls succeed
- Don't leak slist allocated by earlier socket(2) call
MFC after: 2 weeks
CID: 976773, 1251405
Reported by: Coverity
Sponsored by: EMC / Isilon Storage Division
Diffstat (limited to 'contrib/netbsd-tests')
| -rw-r--r-- | contrib/netbsd-tests/lib/libc/sys/t_connect.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/contrib/netbsd-tests/lib/libc/sys/t_connect.c b/contrib/netbsd-tests/lib/libc/sys/t_connect.c index e492206..896b490 100644 --- a/contrib/netbsd-tests/lib/libc/sys/t_connect.c +++ b/contrib/netbsd-tests/lib/libc/sys/t_connect.c @@ -56,6 +56,11 @@ ATF_TC_BODY(connect_low_port, tc) slist = socket(AF_INET, SOCK_STREAM, 0); sd = socket(AF_INET, SOCK_STREAM, 0); +#ifdef __FreeBSD__ + ATF_REQUIRE(sd > 0); + ATF_REQUIRE(slist > 0); +#endif + /* bind listening socket */ memset(&sinlist, 0, sizeof(sinlist)); sinlist.sin_family = AF_INET; @@ -92,6 +97,9 @@ ATF_TC_BODY(connect_low_port, tc) ATF_REQUIRE(ntohs(sin.sin_port) <= IPPORT_RESERVEDMAX); close(sd); +#ifdef __FreeBSD__ + close(slist); +#endif } ATF_TP_ADD_TCS(tp) |
