Update clang, llvm, lld, lldb, compiler-rt and libc++ to 4.0.0 release:

MFC r309142 (by emaste):

Add WITH_LLD_AS_LD build knob

If set it installs LLD as /usr/bin/ld.  LLD (as of version 3.9) is not
capable of linking the world and kernel, but can self-host and link many
substantial applications. GNU ld continues to be used for the world and
kernel build, regardless of how this knob is set.

It is on by default for arm64, and off for all other CPU architectures.

Sponsored by:	The FreeBSD Foundation

MFC r310840:

Reapply 310775, now it also builds correctly if lldb is disabled:

Move llvm-objdump from CLANG_EXTRAS to installed by default

We currently install three tools from binutils 2.17.50: as, ld, and
objdump. Work is underway to migrate to a permissively-licensed
tool-chain, with one goal being the retirement of binutils 2.17.50.

LLVM's llvm-objdump is intended to be compatible with GNU objdump
although it is currently missing some options and may have formatting
differences. Enable it by default for testing and further investigation.
It may later be changed to install as /usr/bin/objdump, it becomes a
fully viable replacement.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D8879

MFC r312855 (by emaste):

Rename LLD_AS_LD to LLD_IS_LD, for consistency with CLANG_IS_CC

Reported by:	Dan McGregor <dan.mcgregor usask.ca>

MFC r313559 | glebius | 2017-02-10 18:34:48 +0100 (Fri, 10 Feb 2017) | 5 lines

Don't check struct rtentry on FreeBSD, it is an internal kernel structure.
On other systems it may be API structure for SIOCADDRT/SIOCDELRT.

Reviewed by:	emaste, dim

MFC r314152 (by jkim):

Remove an assembler flag, which is redundant since r309124.  The upstream
took care of it by introducing a macro NO_EXEC_STACK_DIRECTIVE.

http://llvm.org/viewvc/llvm-project?rev=273500&view=rev

Reviewed by:	dim

MFC r314564:

Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
4.0.0 (branches/release_40 296509).  The release will follow soon.

Please note that from 3.5.0 onwards, clang, llvm and lldb require C++11
support to build; see UPDATING for more information.

Also note that as of 4.0.0, lld should be able to link the base system
on amd64 and aarch64.  See the WITH_LLD_IS_LLD setting in src.conf(5).
Though please be aware that this is work in progress.

Release notes for llvm, clang and lld will be available here:
<http://releases.llvm.org/4.0.0/docs/ReleaseNotes.html>
<http://releases.llvm.org/4.0.0/tools/clang/docs/ReleaseNotes.html>
<http://releases.llvm.org/4.0.0/tools/lld/docs/ReleaseNotes.html>

Thanks to Ed Maste, Jan Beich, Antoine Brodin and Eric Fiselier for
their help.

Relnotes:	yes
Exp-run:	antoine
PR:		215969, 216008

MFC r314708:

For now, revert r287232 from upstream llvm trunk (by Daniil Fukalov):

  [SCEV] limit recursion depth of CompareSCEVComplexity

  Summary:
  CompareSCEVComplexity goes too deep (50+ on a quite a big unrolled
  loop) and runs almost infinite time.

  Added cache of "equal" SCEV pairs to earlier cutoff of further
  estimation. Recursion depth limit was also introduced as a parameter.

  Reviewers: sanjoy

  Subscribers: mzolotukhin, tstellarAMD, llvm-commits

  Differential Revision: https://reviews.llvm.org/D26389

This commit is the cause of excessive compile times on skein_block.c
(and possibly other files) during kernel builds on amd64.

We never saw the problematic behavior described in this upstream commit,
so for now it is better to revert it.  An upstream bug has been filed
here: https://bugs.llvm.org/show_bug.cgi?id=32142

Reported by:	mjg

MFC r314795:

Reapply r287232 from upstream llvm trunk (by Daniil Fukalov):

  [SCEV] limit recursion depth of CompareSCEVComplexity

  Summary:
  CompareSCEVComplexity goes too deep (50+ on a quite a big unrolled
  loop) and runs almost infinite time.

  Added cache of "equal" SCEV pairs to earlier cutoff of further
  estimation. Recursion depth limit was also introduced as a parameter.

  Reviewers: sanjoy

  Subscribers: mzolotukhin, tstellarAMD, llvm-commits

  Differential Revision: https://reviews.llvm.org/D26389

Pull in r296992 from upstream llvm trunk (by Sanjoy Das):

  [SCEV] Decrease the recursion threshold for CompareValueComplexity

  Fixes PR32142.

  r287232 accidentally increased the recursion threshold for
  CompareValueComplexity from 2 to 32.  This change reverses that
  change by introducing a separate flag for CompareValueComplexity's
  threshold.

The latter revision fixes the excessive compile times for skein_block.c.

MFC r314907 | mmel | 2017-03-08 12:40:27 +0100 (Wed, 08 Mar 2017) | 7 lines

Unbreak ARMv6 world.

The new compiler_rt library imported with clang 4.0.0 have several fatal
issues (non-functional __udivsi3 for example) with ARM specific instrict
functions. As temporary workaround, until upstream solve these problems,
disable all thumb[1][2] related feature.

MFC r315016:

Update clang, llvm, lld, lldb, compiler-rt and libc++ to 4.0.0 release.
We were already very close to the last release candidate, so this is a
pretty minor update.

Relnotes:	yes

MFC r316005:

Revert r314907, and pull in r298713 from upstream compiler-rt trunk (by
Weiming Zhao):

  builtins: Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.

  Summary:
  Value of __ARM_ARCH_ISA_THUMB isn't based on the actual compilation
  mode (-mthumb, -marm), it reflect's capability of given CPU.

  Due to this:
   - use  __tbumb__ and __thumb2__ insteand of __ARM_ARCH_ISA_THUMB
   - use '.thumb' directive consistently  in all affected files
   - decorate all thumb functions using
     DEFINE_COMPILERRT_THUMB_FUNCTION()

  ---------
  Note: This patch doesn't fix broken Thumb1 variant of __udivsi3 !

  Reviewers: weimingz, rengolin, compnerd

  Subscribers: aemerson, dim

  Differential Revision: https://reviews.llvm.org/D30938

Discussed with:	mmel

1 files changed, 265 insertions, 342 deletions

diff --git a/contrib/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp b/contrib/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp
index 625cce3..a3e8239 100644
--- a/contrib/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp
+++ b/contrib/llvm/tools/lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp
@@ -24,240 +24,201 @@ using namespace llvm::ELF;
 //
 // GetMaxU64 and GetMaxS64 wrap the similarly named methods from DataExtractor
 // with error handling code and provide for parsing a sequence of values.
-static bool
-GetMaxU64(const lldb_private::DataExtractor &data,
-          lldb::offset_t *offset,
-          uint64_t *value,
-          uint32_t byte_size)
-{
-    const lldb::offset_t saved_offset = *offset;
-    *value = data.GetMaxU64(offset, byte_size);
-    return *offset != saved_offset;
+static bool GetMaxU64(const lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset, uint64_t *value,
+                      uint32_t byte_size) {
+  const lldb::offset_t saved_offset = *offset;
+  *value = data.GetMaxU64(offset, byte_size);
+  return *offset != saved_offset;
 }
 
-static bool
-GetMaxU64(const lldb_private::DataExtractor &data, 
-          lldb::offset_t *offset,
-          uint64_t *value,
-          uint32_t byte_size,
-          uint32_t count) 
-{
-    lldb::offset_t saved_offset = *offset;
-
-    for (uint32_t i = 0; i < count; ++i, ++value)
-    {
-        if (GetMaxU64(data, offset, value, byte_size) == false) 
-        {
-            *offset = saved_offset;
-            return false;
-        }
+static bool GetMaxU64(const lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset, uint64_t *value,
+                      uint32_t byte_size, uint32_t count) {
+  lldb::offset_t saved_offset = *offset;
+
+  for (uint32_t i = 0; i < count; ++i, ++value) {
+    if (GetMaxU64(data, offset, value, byte_size) == false) {
+      *offset = saved_offset;
+      return false;
     }
-    return true;
+  }
+  return true;
 }
 
-static bool
-GetMaxS64(const lldb_private::DataExtractor &data, 
-          lldb::offset_t *offset,
-          int64_t *value,
-          uint32_t byte_size)
-{
-    const lldb::offset_t saved_offset = *offset;
-    *value = data.GetMaxS64(offset, byte_size);
-    return *offset != saved_offset;
+static bool GetMaxS64(const lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset, int64_t *value,
+                      uint32_t byte_size) {
+  const lldb::offset_t saved_offset = *offset;
+  *value = data.GetMaxS64(offset, byte_size);
+  return *offset != saved_offset;
 }
 
-static bool
-GetMaxS64(const lldb_private::DataExtractor &data, 
-          lldb::offset_t *offset,
-          int64_t *value,
-          uint32_t byte_size,
-          uint32_t count) 
-{
-    lldb::offset_t saved_offset = *offset;
-
-    for (uint32_t i = 0; i < count; ++i, ++value)
-    {
-        if (GetMaxS64(data, offset, value, byte_size) == false) 
-        {
-            *offset = saved_offset;
-            return false;
-        }
+static bool GetMaxS64(const lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset, int64_t *value,
+                      uint32_t byte_size, uint32_t count) {
+  lldb::offset_t saved_offset = *offset;
+
+  for (uint32_t i = 0; i < count; ++i, ++value) {
+    if (GetMaxS64(data, offset, value, byte_size) == false) {
+      *offset = saved_offset;
+      return false;
     }
-    return true;
+  }
+  return true;
 }
 
 //------------------------------------------------------------------------------
 // ELFHeader
 
-ELFHeader::ELFHeader()
-{
-    memset(this, 0, sizeof(ELFHeader)); 
-}
+ELFHeader::ELFHeader() { memset(this, 0, sizeof(ELFHeader)); }
 
-ByteOrder
-ELFHeader::GetByteOrder() const 
-{
-    if (e_ident[EI_DATA] == ELFDATA2MSB)
-        return eByteOrderBig;
-    if (e_ident[EI_DATA] == ELFDATA2LSB)
-        return eByteOrderLittle;
-    return eByteOrderInvalid;
+ByteOrder ELFHeader::GetByteOrder() const {
+  if (e_ident[EI_DATA] == ELFDATA2MSB)
+    return eByteOrderBig;
+  if (e_ident[EI_DATA] == ELFDATA2LSB)
+    return eByteOrderLittle;
+  return eByteOrderInvalid;
 }
 
-bool
-ELFHeader::Parse(lldb_private::DataExtractor &data, lldb::offset_t *offset) 
-{
-    // Read e_ident.  This provides byte order and address size info.
-    if (data.GetU8(offset, &e_ident, EI_NIDENT) == NULL)
-        return false;
+bool ELFHeader::Parse(lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset) {
+  // Read e_ident.  This provides byte order and address size info.
+  if (data.GetU8(offset, &e_ident, EI_NIDENT) == NULL)
+    return false;
 
-    const unsigned byte_size = Is32Bit() ? 4 : 8;
-    data.SetByteOrder(GetByteOrder());
-    data.SetAddressByteSize(byte_size);
+  const unsigned byte_size = Is32Bit() ? 4 : 8;
+  data.SetByteOrder(GetByteOrder());
+  data.SetAddressByteSize(byte_size);
 
-    // Read e_type and e_machine.
-    if (data.GetU16(offset, &e_type, 2) == NULL)
-        return false;
+  // Read e_type and e_machine.
+  if (data.GetU16(offset, &e_type, 2) == NULL)
+    return false;
 
-    // Read e_version.
-    if (data.GetU32(offset, &e_version, 1) == NULL)
-        return false;
+  // Read e_version.
+  if (data.GetU32(offset, &e_version, 1) == NULL)
+    return false;
 
-    // Read e_entry, e_phoff and e_shoff.
-    if (GetMaxU64(data, offset, &e_entry, byte_size, 3) == false)
-        return false;
+  // Read e_entry, e_phoff and e_shoff.
+  if (GetMaxU64(data, offset, &e_entry, byte_size, 3) == false)
+    return false;
 
-    // Read e_flags.
-    if (data.GetU32(offset, &e_flags, 1) == NULL)
-        return false;
+  // Read e_flags.
+  if (data.GetU32(offset, &e_flags, 1) == NULL)
+    return false;
 
-    // Read e_ehsize, e_phentsize, e_phnum, e_shentsize, e_shnum and
-    // e_shstrndx.
-    if (data.GetU16(offset, &e_ehsize, 6) == NULL)
-        return false;
+  // Read e_ehsize, e_phentsize, e_phnum, e_shentsize, e_shnum and
+  // e_shstrndx.
+  if (data.GetU16(offset, &e_ehsize, 6) == NULL)
+    return false;
 
-    return true;
+  return true;
 }
 
-bool
-ELFHeader::MagicBytesMatch(const uint8_t *magic)
-{
-    return memcmp(magic, ElfMagic, strlen(ElfMagic)) == 0;
+bool ELFHeader::MagicBytesMatch(const uint8_t *magic) {
+  return memcmp(magic, ElfMagic, strlen(ElfMagic)) == 0;
 }
 
-unsigned
-ELFHeader::AddressSizeInBytes(const uint8_t *magic)
-{
-    unsigned address_size = 0;
-
-    switch (magic[EI_CLASS]) 
-    {
-    case ELFCLASS32:
-        address_size = 4;
-        break;
-            
-    case ELFCLASS64:
-        address_size = 8;
-        break;
-    }
-    return address_size;
-}
+unsigned ELFHeader::AddressSizeInBytes(const uint8_t *magic) {
+  unsigned address_size = 0;
 
-unsigned
-ELFHeader::GetRelocationJumpSlotType() const
-{
-    unsigned slot = 0;
-
-    switch (e_machine)
-    {
-    default:
-        assert(false && "architecture not supported");
-        break;
-    case EM_PPC:
-        slot = R_PPC_JMP_SLOT;
-        break;
-    case EM_PPC64:
-        slot = R_PPC64_JMP_SLOT;
-        break;
-    case EM_386:
-    case EM_IAMCU: // FIXME: is this correct?
-        slot = R_386_JUMP_SLOT;
-        break;
-    case EM_X86_64:
-        slot = R_X86_64_JUMP_SLOT;
-        break;
-    case EM_ARM:
-        slot = R_ARM_JUMP_SLOT;
-        break;
-    case EM_HEXAGON:
-        slot = R_HEX_JMP_SLOT;
-        break;
-    case EM_AARCH64:
-        slot = R_AARCH64_JUMP_SLOT;
-        break;
-    case EM_MIPS:
-        slot = R_MIPS_JUMP_SLOT;
-        break;
-    case EM_S390:
-        slot = R_390_JMP_SLOT;
-        break;
-    }
+  switch (magic[EI_CLASS]) {
+  case ELFCLASS32:
+    address_size = 4;
+    break;
 
-    return slot;
+  case ELFCLASS64:
+    address_size = 8;
+    break;
+  }
+  return address_size;
+}
+
+unsigned ELFHeader::GetRelocationJumpSlotType() const {
+  unsigned slot = 0;
+
+  switch (e_machine) {
+  default:
+    assert(false && "architecture not supported");
+    break;
+  case EM_PPC:
+    slot = R_PPC_JMP_SLOT;
+    break;
+  case EM_PPC64:
+    slot = R_PPC64_JMP_SLOT;
+    break;
+  case EM_386:
+  case EM_IAMCU: // FIXME: is this correct?
+    slot = R_386_JUMP_SLOT;
+    break;
+  case EM_X86_64:
+    slot = R_X86_64_JUMP_SLOT;
+    break;
+  case EM_ARM:
+    slot = R_ARM_JUMP_SLOT;
+    break;
+  case EM_HEXAGON:
+    slot = R_HEX_JMP_SLOT;
+    break;
+  case EM_AARCH64:
+    slot = R_AARCH64_JUMP_SLOT;
+    break;
+  case EM_MIPS:
+    slot = R_MIPS_JUMP_SLOT;
+    break;
+  case EM_S390:
+    slot = R_390_JMP_SLOT;
+    break;
+  }
+
+  return slot;
 }
 
 //------------------------------------------------------------------------------
 // ELFSectionHeader
 
-ELFSectionHeader::ELFSectionHeader() 
-{
-    memset(this, 0, sizeof(ELFSectionHeader));
+ELFSectionHeader::ELFSectionHeader() {
+  memset(this, 0, sizeof(ELFSectionHeader));
 }
 
-bool
-ELFSectionHeader::Parse(const lldb_private::DataExtractor &data,
-                        lldb::offset_t *offset)
-{
-    const unsigned byte_size = data.GetAddressByteSize();
+bool ELFSectionHeader::Parse(const lldb_private::DataExtractor &data,
+                             lldb::offset_t *offset) {
+  const unsigned byte_size = data.GetAddressByteSize();
 
-    // Read sh_name and sh_type.
-    if (data.GetU32(offset, &sh_name, 2) == NULL)
-        return false;
+  // Read sh_name and sh_type.
+  if (data.GetU32(offset, &sh_name, 2) == NULL)
+    return false;
 
-    // Read sh_flags.
-    if (GetMaxU64(data, offset, &sh_flags, byte_size) == false)
-        return false;
+  // Read sh_flags.
+  if (GetMaxU64(data, offset, &sh_flags, byte_size) == false)
+    return false;
 
-    // Read sh_addr, sh_off and sh_size.
-    if (GetMaxU64(data, offset, &sh_addr, byte_size, 3) == false)
-        return false;
+  // Read sh_addr, sh_off and sh_size.
+  if (GetMaxU64(data, offset, &sh_addr, byte_size, 3) == false)
+    return false;
 
-    // Read sh_link and sh_info.
-    if (data.GetU32(offset, &sh_link, 2) == NULL)
-        return false;
+  // Read sh_link and sh_info.
+  if (data.GetU32(offset, &sh_link, 2) == NULL)
+    return false;
 
-    // Read sh_addralign and sh_entsize.
-    if (GetMaxU64(data, offset, &sh_addralign, byte_size, 2) == false)
-        return false;
+  // Read sh_addralign and sh_entsize.
+  if (GetMaxU64(data, offset, &sh_addralign, byte_size, 2) == false)
+    return false;
 
-    return true;
+  return true;
 }
 
 //------------------------------------------------------------------------------
 // ELFSymbol
 
-ELFSymbol::ELFSymbol() 
-{
-    memset(this, 0, sizeof(ELFSymbol));
-}
+ELFSymbol::ELFSymbol() { memset(this, 0, sizeof(ELFSymbol)); }
 
-#define ENUM_TO_CSTR(e) case e: return #e
+#define ENUM_TO_CSTR(e)                                                        \
+  case e:                                                                      \
+    return #e
 
-const char *
-ELFSymbol::bindingToCString(unsigned char binding)
-{
-    switch (binding)
-    {
+const char *ELFSymbol::bindingToCString(unsigned char binding) {
+  switch (binding) {
     ENUM_TO_CSTR(STB_LOCAL);
     ENUM_TO_CSTR(STB_GLOBAL);
     ENUM_TO_CSTR(STB_WEAK);
@@ -265,15 +226,12 @@ ELFSymbol::bindingToCString(unsigned char binding)
     ENUM_TO_CSTR(STB_HIOS);
     ENUM_TO_CSTR(STB_LOPROC);
     ENUM_TO_CSTR(STB_HIPROC);
-    }
-    return "";
+  }
+  return "";
 }
 
-const char *
-ELFSymbol::typeToCString(unsigned char type)
-{
-    switch (type)
-    {
+const char *ELFSymbol::typeToCString(unsigned char type) {
+  switch (type) {
     ENUM_TO_CSTR(STT_NOTYPE);
     ENUM_TO_CSTR(STT_OBJECT);
     ENUM_TO_CSTR(STT_FUNC);
@@ -285,16 +243,13 @@ ELFSymbol::typeToCString(unsigned char type)
     ENUM_TO_CSTR(STT_HIOS);
     ENUM_TO_CSTR(STT_LOPROC);
     ENUM_TO_CSTR(STT_HIPROC);
-    }
-    return "";
+  }
+  return "";
 }
 
-const char *
-ELFSymbol::sectionIndexToCString (elf_half shndx,
-                                  const lldb_private::SectionList *section_list)
-{
-    switch (shndx)
-    {
+const char *ELFSymbol::sectionIndexToCString(
+    elf_half shndx, const lldb_private::SectionList *section_list) {
+  switch (shndx) {
     ENUM_TO_CSTR(SHN_UNDEF);
     ENUM_TO_CSTR(SHN_LOPROC);
     ENUM_TO_CSTR(SHN_HIPROC);
@@ -303,180 +258,148 @@ ELFSymbol::sectionIndexToCString (elf_half shndx,
     ENUM_TO_CSTR(SHN_ABS);
     ENUM_TO_CSTR(SHN_COMMON);
     ENUM_TO_CSTR(SHN_XINDEX);
-    default:
-        {
-            const lldb_private::Section *section = section_list->GetSectionAtIndex(shndx).get();
-            if (section)
-                return section->GetName().AsCString("");
-        }
-        break;
-    }
-    return "";
+  default: {
+    const lldb_private::Section *section =
+        section_list->GetSectionAtIndex(shndx).get();
+    if (section)
+      return section->GetName().AsCString("");
+  } break;
+  }
+  return "";
 }
 
-void
-ELFSymbol::Dump (lldb_private::Stream *s,
-                 uint32_t idx,
-                 const lldb_private::DataExtractor *strtab_data,
-                 const lldb_private::SectionList *section_list)
-{
-    s->Printf("[%3u] 0x%16.16" PRIx64 " 0x%16.16" PRIx64 " 0x%8.8x 0x%2.2x (%-10s %-13s) 0x%2.2x 0x%4.4x (%-10s) %s\n",
-              idx,
-              st_value,
-              st_size,
-              st_name,
-              st_info,
-              bindingToCString (getBinding()),
-              typeToCString (getType()),
-              st_other,
-              st_shndx,
-              sectionIndexToCString (st_shndx, section_list),
-              strtab_data ? strtab_data->PeekCStr(st_name) : "");
+void ELFSymbol::Dump(lldb_private::Stream *s, uint32_t idx,
+                     const lldb_private::DataExtractor *strtab_data,
+                     const lldb_private::SectionList *section_list) {
+  s->Printf("[%3u] 0x%16.16" PRIx64 " 0x%16.16" PRIx64
+            " 0x%8.8x 0x%2.2x (%-10s %-13s) 0x%2.2x 0x%4.4x (%-10s) %s\n",
+            idx, st_value, st_size, st_name, st_info,
+            bindingToCString(getBinding()), typeToCString(getType()), st_other,
+            st_shndx, sectionIndexToCString(st_shndx, section_list),
+            strtab_data ? strtab_data->PeekCStr(st_name) : "");
 }
 
-bool
-ELFSymbol::Parse(const lldb_private::DataExtractor &data, lldb::offset_t *offset)
-{
-    const unsigned byte_size = data.GetAddressByteSize();
-    const bool parsing_32 = byte_size == 4;
-
-    // Read st_name.
-    if (data.GetU32(offset, &st_name, 1) == NULL)
-        return false;
-
-    if (parsing_32) 
-    {
-        // Read st_value and st_size.
-        if (GetMaxU64(data, offset, &st_value, byte_size, 2) == false)
-            return false;
-
-        // Read st_info and st_other.
-        if (data.GetU8(offset, &st_info, 2) == NULL)
-            return false;
-            
-        // Read st_shndx.
-        if (data.GetU16(offset, &st_shndx, 1) == NULL)
-            return false;
-    }
-    else 
-    {
-        // Read st_info and st_other.
-        if (data.GetU8(offset, &st_info, 2) == NULL)
-            return false;
-            
-        // Read st_shndx.
-        if (data.GetU16(offset, &st_shndx, 1) == NULL)
-            return false;
-
-        // Read st_value and st_size.
-        if (data.GetU64(offset, &st_value, 2) == NULL)
-            return false;
-    }
-    return true;
+bool ELFSymbol::Parse(const lldb_private::DataExtractor &data,
+                      lldb::offset_t *offset) {
+  const unsigned byte_size = data.GetAddressByteSize();
+  const bool parsing_32 = byte_size == 4;
+
+  // Read st_name.
+  if (data.GetU32(offset, &st_name, 1) == NULL)
+    return false;
+
+  if (parsing_32) {
+    // Read st_value and st_size.
+    if (GetMaxU64(data, offset, &st_value, byte_size, 2) == false)
+      return false;
+
+    // Read st_info and st_other.
+    if (data.GetU8(offset, &st_info, 2) == NULL)
+      return false;
+
+    // Read st_shndx.
+    if (data.GetU16(offset, &st_shndx, 1) == NULL)
+      return false;
+  } else {
+    // Read st_info and st_other.
+    if (data.GetU8(offset, &st_info, 2) == NULL)
+      return false;
+
+    // Read st_shndx.
+    if (data.GetU16(offset, &st_shndx, 1) == NULL)
+      return false;
+
+    // Read st_value and st_size.
+    if (data.GetU64(offset, &st_value, 2) == NULL)
+      return false;
+  }
+  return true;
 }
 
 //------------------------------------------------------------------------------
 // ELFProgramHeader
 
-ELFProgramHeader::ELFProgramHeader() 
-{
-    memset(this, 0, sizeof(ELFProgramHeader));
+ELFProgramHeader::ELFProgramHeader() {
+  memset(this, 0, sizeof(ELFProgramHeader));
 }
 
-bool
-ELFProgramHeader::Parse(const lldb_private::DataExtractor &data, 
-                        lldb::offset_t *offset)
-{
-    const uint32_t byte_size = data.GetAddressByteSize();
-    const bool parsing_32 = byte_size == 4;
-
-    // Read p_type;
-    if (data.GetU32(offset, &p_type, 1) == NULL)
-        return false;
-
-    if (parsing_32) {
-        // Read p_offset, p_vaddr, p_paddr, p_filesz and p_memsz.
-        if (GetMaxU64(data, offset, &p_offset, byte_size, 5) == false)
-            return false;
-
-        // Read p_flags.
-        if (data.GetU32(offset, &p_flags, 1) == NULL)
-            return false;
-
-        // Read p_align.
-        if (GetMaxU64(data, offset, &p_align, byte_size) == false)
-            return false;
-    }
-    else {
-        // Read p_flags.
-        if (data.GetU32(offset, &p_flags, 1) == NULL)
-            return false;
-
-        // Read p_offset, p_vaddr, p_paddr, p_filesz, p_memsz and p_align.
-        if (GetMaxU64(data, offset, &p_offset, byte_size, 6) == false)
-            return false;
-    }
-
-    return true;
+bool ELFProgramHeader::Parse(const lldb_private::DataExtractor &data,
+                             lldb::offset_t *offset) {
+  const uint32_t byte_size = data.GetAddressByteSize();
+  const bool parsing_32 = byte_size == 4;
+
+  // Read p_type;
+  if (data.GetU32(offset, &p_type, 1) == NULL)
+    return false;
+
+  if (parsing_32) {
+    // Read p_offset, p_vaddr, p_paddr, p_filesz and p_memsz.
+    if (GetMaxU64(data, offset, &p_offset, byte_size, 5) == false)
+      return false;
+
+    // Read p_flags.
+    if (data.GetU32(offset, &p_flags, 1) == NULL)
+      return false;
+
+    // Read p_align.
+    if (GetMaxU64(data, offset, &p_align, byte_size) == false)
+      return false;
+  } else {
+    // Read p_flags.
+    if (data.GetU32(offset, &p_flags, 1) == NULL)
+      return false;
+
+    // Read p_offset, p_vaddr, p_paddr, p_filesz, p_memsz and p_align.
+    if (GetMaxU64(data, offset, &p_offset, byte_size, 6) == false)
+      return false;
+  }
+
+  return true;
 }
 
 //------------------------------------------------------------------------------
 // ELFDynamic
 
-ELFDynamic::ELFDynamic() 
-{ 
-    memset(this, 0, sizeof(ELFDynamic)); 
-}
+ELFDynamic::ELFDynamic() { memset(this, 0, sizeof(ELFDynamic)); }
 
-bool
-ELFDynamic::Parse(const lldb_private::DataExtractor &data, lldb::offset_t *offset)
-{
-    const unsigned byte_size = data.GetAddressByteSize();
-    return GetMaxS64(data, offset, &d_tag, byte_size, 2);
+bool ELFDynamic::Parse(const lldb_private::DataExtractor &data,
+                       lldb::offset_t *offset) {
+  const unsigned byte_size = data.GetAddressByteSize();
+  return GetMaxS64(data, offset, &d_tag, byte_size, 2);
 }
 
 //------------------------------------------------------------------------------
 // ELFRel
 
-ELFRel::ELFRel()
-{
-    memset(this, 0, sizeof(ELFRel));
-}
+ELFRel::ELFRel() { memset(this, 0, sizeof(ELFRel)); }
 
-bool
-ELFRel::Parse(const lldb_private::DataExtractor &data, lldb::offset_t *offset)
-{
-    const unsigned byte_size = data.GetAddressByteSize();
+bool ELFRel::Parse(const lldb_private::DataExtractor &data,
+                   lldb::offset_t *offset) {
+  const unsigned byte_size = data.GetAddressByteSize();
 
-    // Read r_offset and r_info.
-    if (GetMaxU64(data, offset, &r_offset, byte_size, 2) == false)
-        return false;
+  // Read r_offset and r_info.
+  if (GetMaxU64(data, offset, &r_offset, byte_size, 2) == false)
+    return false;
 
-    return true;
+  return true;
 }
 
 //------------------------------------------------------------------------------
 // ELFRela
 
-ELFRela::ELFRela()
-{
-    memset(this, 0, sizeof(ELFRela));
-}
+ELFRela::ELFRela() { memset(this, 0, sizeof(ELFRela)); }
 
-bool
-ELFRela::Parse(const lldb_private::DataExtractor &data, lldb::offset_t *offset)
-{
-    const unsigned byte_size = data.GetAddressByteSize();
+bool ELFRela::Parse(const lldb_private::DataExtractor &data,
+                    lldb::offset_t *offset) {
+  const unsigned byte_size = data.GetAddressByteSize();
 
-    // Read r_offset and r_info.
-    if (GetMaxU64(data, offset, &r_offset, byte_size, 2) == false)
-        return false;
+  // Read r_offset and r_info.
+  if (GetMaxU64(data, offset, &r_offset, byte_size, 2) == false)
+    return false;
 
-    // Read r_addend;
-    if (GetMaxS64(data, offset, &r_addend, byte_size) == false)
-        return false;
+  // Read r_addend;
+  if (GetMaxS64(data, offset, &r_addend, byte_size) == false)
+    return false;
 
-    return true;
+  return true;
 }
-
-