Update clang, llvm, lld, lldb, compiler-rt and libc++ to 4.0.0 release:

MFC r309142 (by emaste):

Add WITH_LLD_AS_LD build knob

If set it installs LLD as /usr/bin/ld.  LLD (as of version 3.9) is not
capable of linking the world and kernel, but can self-host and link many
substantial applications. GNU ld continues to be used for the world and
kernel build, regardless of how this knob is set.

It is on by default for arm64, and off for all other CPU architectures.

Sponsored by:	The FreeBSD Foundation

MFC r310840:

Reapply 310775, now it also builds correctly if lldb is disabled:

Move llvm-objdump from CLANG_EXTRAS to installed by default

We currently install three tools from binutils 2.17.50: as, ld, and
objdump. Work is underway to migrate to a permissively-licensed
tool-chain, with one goal being the retirement of binutils 2.17.50.

LLVM's llvm-objdump is intended to be compatible with GNU objdump
although it is currently missing some options and may have formatting
differences. Enable it by default for testing and further investigation.
It may later be changed to install as /usr/bin/objdump, it becomes a
fully viable replacement.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D8879

MFC r312855 (by emaste):

Rename LLD_AS_LD to LLD_IS_LD, for consistency with CLANG_IS_CC

Reported by:	Dan McGregor <dan.mcgregor usask.ca>

MFC r313559 | glebius | 2017-02-10 18:34:48 +0100 (Fri, 10 Feb 2017) | 5 lines

Don't check struct rtentry on FreeBSD, it is an internal kernel structure.
On other systems it may be API structure for SIOCADDRT/SIOCDELRT.

Reviewed by:	emaste, dim

MFC r314152 (by jkim):

Remove an assembler flag, which is redundant since r309124.  The upstream
took care of it by introducing a macro NO_EXEC_STACK_DIRECTIVE.

http://llvm.org/viewvc/llvm-project?rev=273500&view=rev

Reviewed by:	dim

MFC r314564:

Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
4.0.0 (branches/release_40 296509).  The release will follow soon.

Please note that from 3.5.0 onwards, clang, llvm and lldb require C++11
support to build; see UPDATING for more information.

Also note that as of 4.0.0, lld should be able to link the base system
on amd64 and aarch64.  See the WITH_LLD_IS_LLD setting in src.conf(5).
Though please be aware that this is work in progress.

Release notes for llvm, clang and lld will be available here:
<http://releases.llvm.org/4.0.0/docs/ReleaseNotes.html>
<http://releases.llvm.org/4.0.0/tools/clang/docs/ReleaseNotes.html>
<http://releases.llvm.org/4.0.0/tools/lld/docs/ReleaseNotes.html>

Thanks to Ed Maste, Jan Beich, Antoine Brodin and Eric Fiselier for
their help.

Relnotes:	yes
Exp-run:	antoine
PR:		215969, 216008

MFC r314708:

For now, revert r287232 from upstream llvm trunk (by Daniil Fukalov):

  [SCEV] limit recursion depth of CompareSCEVComplexity

  Summary:
  CompareSCEVComplexity goes too deep (50+ on a quite a big unrolled
  loop) and runs almost infinite time.

  Added cache of "equal" SCEV pairs to earlier cutoff of further
  estimation. Recursion depth limit was also introduced as a parameter.

  Reviewers: sanjoy

  Subscribers: mzolotukhin, tstellarAMD, llvm-commits

  Differential Revision: https://reviews.llvm.org/D26389

This commit is the cause of excessive compile times on skein_block.c
(and possibly other files) during kernel builds on amd64.

We never saw the problematic behavior described in this upstream commit,
so for now it is better to revert it.  An upstream bug has been filed
here: https://bugs.llvm.org/show_bug.cgi?id=32142

Reported by:	mjg

MFC r314795:

Reapply r287232 from upstream llvm trunk (by Daniil Fukalov):

  [SCEV] limit recursion depth of CompareSCEVComplexity

  Summary:
  CompareSCEVComplexity goes too deep (50+ on a quite a big unrolled
  loop) and runs almost infinite time.

  Added cache of "equal" SCEV pairs to earlier cutoff of further
  estimation. Recursion depth limit was also introduced as a parameter.

  Reviewers: sanjoy

  Subscribers: mzolotukhin, tstellarAMD, llvm-commits

  Differential Revision: https://reviews.llvm.org/D26389

Pull in r296992 from upstream llvm trunk (by Sanjoy Das):

  [SCEV] Decrease the recursion threshold for CompareValueComplexity

  Fixes PR32142.

  r287232 accidentally increased the recursion threshold for
  CompareValueComplexity from 2 to 32.  This change reverses that
  change by introducing a separate flag for CompareValueComplexity's
  threshold.

The latter revision fixes the excessive compile times for skein_block.c.

MFC r314907 | mmel | 2017-03-08 12:40:27 +0100 (Wed, 08 Mar 2017) | 7 lines

Unbreak ARMv6 world.

The new compiler_rt library imported with clang 4.0.0 have several fatal
issues (non-functional __udivsi3 for example) with ARM specific instrict
functions. As temporary workaround, until upstream solve these problems,
disable all thumb[1][2] related feature.

MFC r315016:

Update clang, llvm, lld, lldb, compiler-rt and libc++ to 4.0.0 release.
We were already very close to the last release candidate, so this is a
pretty minor update.

Relnotes:	yes

MFC r316005:

Revert r314907, and pull in r298713 from upstream compiler-rt trunk (by
Weiming Zhao):

  builtins: Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA.

  Summary:
  Value of __ARM_ARCH_ISA_THUMB isn't based on the actual compilation
  mode (-mthumb, -marm), it reflect's capability of given CPU.

  Due to this:
   - use  __tbumb__ and __thumb2__ insteand of __ARM_ARCH_ISA_THUMB
   - use '.thumb' directive consistently  in all affected files
   - decorate all thumb functions using
     DEFINE_COMPILERRT_THUMB_FUNCTION()

  ---------
  Note: This patch doesn't fix broken Thumb1 variant of __udivsi3 !

  Reviewers: weimingz, rengolin, compnerd

  Subscribers: aemerson, dim

  Differential Revision: https://reviews.llvm.org/D30938

Discussed with:	mmel

1 files changed, 718 insertions, 917 deletions

diff --git a/contrib/llvm/tools/lldb/source/Host/common/File.cpp b/contrib/llvm/tools/lldb/source/Host/common/File.cpp
index 89587a9..4eb9ae1 100644
--- a/contrib/llvm/tools/lldb/source/Host/common/File.cpp
+++ b/contrib/llvm/tools/lldb/source/Host/common/File.cpp
@@ -34,1028 +34,829 @@
 using namespace lldb;
 using namespace lldb_private;
 
-static const char *
-GetStreamOpenModeFromOptions (uint32_t options)
-{
-    if (options & File::eOpenOptionAppend)
-    {
-        if (options & File::eOpenOptionRead)
-        {
-            if (options & File::eOpenOptionCanCreateNewOnly)
-                return "a+x";
-            else
-                return "a+";
-        }
-        else if (options & File::eOpenOptionWrite)
-        {
-            if (options & File::eOpenOptionCanCreateNewOnly)
-                return "ax";
-            else
-                return "a";
-        }
-    }
-    else if (options & File::eOpenOptionRead && options & File::eOpenOptionWrite)
-    {
-        if (options & File::eOpenOptionCanCreate)
-        {
-            if (options & File::eOpenOptionCanCreateNewOnly)
-                return "w+x";
-            else
-                return "w+";
-        }
-        else
-            return "r+";
-    }
-    else if (options & File::eOpenOptionRead)
-    {
-        return "r";
-    }
-    else if (options & File::eOpenOptionWrite)
-    {
-        return "w";
-    }
-    return NULL;
+static const char *GetStreamOpenModeFromOptions(uint32_t options) {
+  if (options & File::eOpenOptionAppend) {
+    if (options & File::eOpenOptionRead) {
+      if (options & File::eOpenOptionCanCreateNewOnly)
+        return "a+x";
+      else
+        return "a+";
+    } else if (options & File::eOpenOptionWrite) {
+      if (options & File::eOpenOptionCanCreateNewOnly)
+        return "ax";
+      else
+        return "a";
+    }
+  } else if (options & File::eOpenOptionRead &&
+             options & File::eOpenOptionWrite) {
+    if (options & File::eOpenOptionCanCreate) {
+      if (options & File::eOpenOptionCanCreateNewOnly)
+        return "w+x";
+      else
+        return "w+";
+    } else
+      return "r+";
+  } else if (options & File::eOpenOptionRead) {
+    return "r";
+  } else if (options & File::eOpenOptionWrite) {
+    return "w";
+  }
+  return NULL;
 }
 
 int File::kInvalidDescriptor = -1;
-FILE * File::kInvalidStream = NULL;
-
-File::File(const char *path, uint32_t options, uint32_t permissions) :
-    IOObject(eFDTypeFile, false),
-    m_descriptor (kInvalidDescriptor),
-    m_stream (kInvalidStream),
-    m_options (),
-    m_own_stream (false),
-    m_is_interactive (eLazyBoolCalculate),
-    m_is_real_terminal (eLazyBoolCalculate)
-{
-    Open (path, options, permissions);
-}
-
-File::File (const FileSpec& filespec,
-            uint32_t options,
-            uint32_t permissions) :
-    IOObject(eFDTypeFile, false),
-    m_descriptor (kInvalidDescriptor),
-    m_stream (kInvalidStream),
-    m_options (0),
-    m_own_stream (false),
-    m_is_interactive (eLazyBoolCalculate),
-    m_is_real_terminal (eLazyBoolCalculate)
+FILE *File::kInvalidStream = NULL;
 
-{
-    if (filespec)
-    {
-        Open (filespec.GetPath().c_str(), options, permissions);
-    }
+File::File(const char *path, uint32_t options, uint32_t permissions)
+    : IOObject(eFDTypeFile, false), m_descriptor(kInvalidDescriptor),
+      m_stream(kInvalidStream), m_options(), m_own_stream(false),
+      m_is_interactive(eLazyBoolCalculate),
+      m_is_real_terminal(eLazyBoolCalculate) {
+  Open(path, options, permissions);
 }
 
-File::~File()
+File::File(const FileSpec &filespec, uint32_t options, uint32_t permissions)
+    : IOObject(eFDTypeFile, false), m_descriptor(kInvalidDescriptor),
+      m_stream(kInvalidStream), m_options(0), m_own_stream(false),
+      m_is_interactive(eLazyBoolCalculate),
+      m_is_real_terminal(eLazyBoolCalculate)
+
 {
-    Close ();
+  if (filespec) {
+    Open(filespec.GetPath().c_str(), options, permissions);
+  }
 }
 
+File::~File() { Close(); }
 
-int
-File::GetDescriptor() const
-{
-    if (DescriptorIsValid())
-        return m_descriptor;
+int File::GetDescriptor() const {
+  if (DescriptorIsValid())
+    return m_descriptor;
 
-    // Don't open the file descriptor if we don't need to, just get it from the
-    // stream if we have one.
-    if (StreamIsValid())
-    {
+  // Don't open the file descriptor if we don't need to, just get it from the
+  // stream if we have one.
+  if (StreamIsValid()) {
 #if defined(LLVM_ON_WIN32)
-        return _fileno(m_stream);
+    return _fileno(m_stream);
 #else
-        return fileno(m_stream);
+    return fileno(m_stream);
 #endif
-    }
+  }
 
-    // Invalid descriptor and invalid stream, return invalid descriptor.
-    return kInvalidDescriptor;
-}
-
-IOObject::WaitableHandle
-File::GetWaitableHandle()
-{
-    return m_descriptor;
+  // Invalid descriptor and invalid stream, return invalid descriptor.
+  return kInvalidDescriptor;
 }
 
+IOObject::WaitableHandle File::GetWaitableHandle() { return m_descriptor; }
 
-void
-File::SetDescriptor (int fd, bool transfer_ownership)
-{
-    if (IsValid())
-        Close();
-    m_descriptor = fd;
-    m_should_close_fd = transfer_ownership;
+void File::SetDescriptor(int fd, bool transfer_ownership) {
+  if (IsValid())
+    Close();
+  m_descriptor = fd;
+  m_should_close_fd = transfer_ownership;
 }
 
-
-FILE *
-File::GetStream ()
-{
-    if (!StreamIsValid())
-    {
-        if (DescriptorIsValid())
-        {
-            const char *mode = GetStreamOpenModeFromOptions (m_options);
-            if (mode)
-            {
-                if (!m_should_close_fd)
-                {
-                    // We must duplicate the file descriptor if we don't own it because
-                    // when you call fdopen, the stream will own the fd
+FILE *File::GetStream() {
+  if (!StreamIsValid()) {
+    if (DescriptorIsValid()) {
+      const char *mode = GetStreamOpenModeFromOptions(m_options);
+      if (mode) {
+        if (!m_should_close_fd) {
+// We must duplicate the file descriptor if we don't own it because
+// when you call fdopen, the stream will own the fd
 #ifdef _WIN32
-                    m_descriptor = ::_dup(GetDescriptor());
+          m_descriptor = ::_dup(GetDescriptor());
 #else
-                    m_descriptor = dup(GetDescriptor());
+          m_descriptor = dup(GetDescriptor());
 #endif
-                    m_should_close_fd = true;
-                }
-
-                do
-                {
-                    m_stream = ::fdopen (m_descriptor, mode);
-                } while (m_stream == NULL && errno == EINTR);
-
-                // If we got a stream, then we own the stream and should no
-                // longer own the descriptor because fclose() will close it for us
-
-                if (m_stream)
-                {
-                    m_own_stream = true;
-                    m_should_close_fd = false;
-                }
-            }
+          m_should_close_fd = true;
+        }
+
+        do {
+          m_stream = ::fdopen(m_descriptor, mode);
+        } while (m_stream == NULL && errno == EINTR);
+
+        // If we got a stream, then we own the stream and should no
+        // longer own the descriptor because fclose() will close it for us
+
+        if (m_stream) {
+          m_own_stream = true;
+          m_should_close_fd = false;
         }
+      }
     }
-    return m_stream;
+  }
+  return m_stream;
 }
 
-void
-File::SetStream (FILE *fh, bool transfer_ownership)
-{
-    if (IsValid())
-        Close();
-    m_stream = fh;
-    m_own_stream = transfer_ownership;
+void File::SetStream(FILE *fh, bool transfer_ownership) {
+  if (IsValid())
+    Close();
+  m_stream = fh;
+  m_own_stream = transfer_ownership;
 }
 
-Error
-File::Open (const char *path, uint32_t options, uint32_t permissions)
-{
-    Error error;
-    if (IsValid())
-        Close ();
-
-    int oflag = 0;
-    const bool read = options & eOpenOptionRead;
-    const bool write = options & eOpenOptionWrite;
-    if (write)
-    {
-        if (read)
-            oflag |= O_RDWR;
-        else
-            oflag |= O_WRONLY;
-        
-        if (options & eOpenOptionAppend)
-            oflag |= O_APPEND;
-
-        if (options & eOpenOptionTruncate)
-            oflag |= O_TRUNC;
-
-        if (options & eOpenOptionCanCreate)
-            oflag |= O_CREAT;
-        
-        if (options & eOpenOptionCanCreateNewOnly)
-            oflag |= O_CREAT | O_EXCL;
-    }
-    else if (read)
-    {
-        oflag |= O_RDONLY;
+Error File::Open(const char *path, uint32_t options, uint32_t permissions) {
+  Error error;
+  if (IsValid())
+    Close();
+
+  int oflag = 0;
+  const bool read = options & eOpenOptionRead;
+  const bool write = options & eOpenOptionWrite;
+  if (write) {
+    if (read)
+      oflag |= O_RDWR;
+    else
+      oflag |= O_WRONLY;
+
+    if (options & eOpenOptionAppend)
+      oflag |= O_APPEND;
+
+    if (options & eOpenOptionTruncate)
+      oflag |= O_TRUNC;
+
+    if (options & eOpenOptionCanCreate)
+      oflag |= O_CREAT;
+
+    if (options & eOpenOptionCanCreateNewOnly)
+      oflag |= O_CREAT | O_EXCL;
+  } else if (read) {
+    oflag |= O_RDONLY;
 
 #ifndef _WIN32
-        if (options & eOpenOptionDontFollowSymlinks)
-            oflag |= O_NOFOLLOW;
+    if (options & eOpenOptionDontFollowSymlinks)
+      oflag |= O_NOFOLLOW;
 #endif
-    }
-    
+  }
+
 #ifndef _WIN32
-    if (options & eOpenOptionNonBlocking)
-        oflag |= O_NONBLOCK;
-    if (options & eOpenOptionCloseOnExec)
-        oflag |= O_CLOEXEC;
+  if (options & eOpenOptionNonBlocking)
+    oflag |= O_NONBLOCK;
+  if (options & eOpenOptionCloseOnExec)
+    oflag |= O_CLOEXEC;
 #else
-    oflag |= O_BINARY;
+  oflag |= O_BINARY;
 #endif
 
-    mode_t mode = 0;
-    if (oflag & O_CREAT)
-    {
-        if (permissions & lldb::eFilePermissionsUserRead)     mode |= S_IRUSR;
-        if (permissions & lldb::eFilePermissionsUserWrite)    mode |= S_IWUSR;
-        if (permissions & lldb::eFilePermissionsUserExecute)  mode |= S_IXUSR;
-        if (permissions & lldb::eFilePermissionsGroupRead)    mode |= S_IRGRP;
-        if (permissions & lldb::eFilePermissionsGroupWrite)   mode |= S_IWGRP;
-        if (permissions & lldb::eFilePermissionsGroupExecute) mode |= S_IXGRP;
-        if (permissions & lldb::eFilePermissionsWorldRead)    mode |= S_IROTH;
-        if (permissions & lldb::eFilePermissionsWorldWrite)   mode |= S_IWOTH;
-        if (permissions & lldb::eFilePermissionsWorldExecute) mode |= S_IXOTH;
-    }
+  mode_t mode = 0;
+  if (oflag & O_CREAT) {
+    if (permissions & lldb::eFilePermissionsUserRead)
+      mode |= S_IRUSR;
+    if (permissions & lldb::eFilePermissionsUserWrite)
+      mode |= S_IWUSR;
+    if (permissions & lldb::eFilePermissionsUserExecute)
+      mode |= S_IXUSR;
+    if (permissions & lldb::eFilePermissionsGroupRead)
+      mode |= S_IRGRP;
+    if (permissions & lldb::eFilePermissionsGroupWrite)
+      mode |= S_IWGRP;
+    if (permissions & lldb::eFilePermissionsGroupExecute)
+      mode |= S_IXGRP;
+    if (permissions & lldb::eFilePermissionsWorldRead)
+      mode |= S_IROTH;
+    if (permissions & lldb::eFilePermissionsWorldWrite)
+      mode |= S_IWOTH;
+    if (permissions & lldb::eFilePermissionsWorldExecute)
+      mode |= S_IXOTH;
+  }
+
+  do {
+#ifdef _MSC_VER
+    std::wstring wpath;
+    if (!llvm::ConvertUTF8toWide(path, wpath)) {
+      m_descriptor = -1;
+      error.SetErrorString("Error converting path to UTF-16");
+      return error;
+    }
+    ::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYNO, mode);
+#else
+    m_descriptor = ::open(path, oflag, mode);
+#endif
+  } while (m_descriptor < 0 && errno == EINTR);
+
+  if (!DescriptorIsValid())
+    error.SetErrorToErrno();
+  else {
+    m_should_close_fd = true;
+    m_options = options;
+  }
+
+  return error;
+}
+
+uint32_t File::GetPermissions(const FileSpec &file_spec, Error &error) {
+  if (file_spec) {
+    struct stat file_stats;
+    int stat_result = FileSystem::Stat(file_spec.GetCString(), &file_stats);
+    if (stat_result == -1)
+      error.SetErrorToErrno();
+    else {
+      error.Clear();
+      return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
+    }
+  } else
+    error.SetErrorString("empty file spec");
+  return 0;
+}
+
+uint32_t File::GetPermissions(Error &error) const {
+  int fd = GetDescriptor();
+  if (fd != kInvalidDescriptor) {
+    struct stat file_stats;
+    if (::fstat(fd, &file_stats) == -1)
+      error.SetErrorToErrno();
+    else {
+      error.Clear();
+      return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
+    }
+  } else {
+    error.SetErrorString("invalid file descriptor");
+  }
+  return 0;
+}
+
+Error File::Close() {
+  Error error;
+  if (StreamIsValid() && m_own_stream) {
+    if (::fclose(m_stream) == EOF)
+      error.SetErrorToErrno();
+  }
+
+  if (DescriptorIsValid() && m_should_close_fd) {
+    if (::close(m_descriptor) != 0)
+      error.SetErrorToErrno();
+  }
+  m_descriptor = kInvalidDescriptor;
+  m_stream = kInvalidStream;
+  m_options = 0;
+  m_own_stream = false;
+  m_should_close_fd = false;
+  m_is_interactive = eLazyBoolCalculate;
+  m_is_real_terminal = eLazyBoolCalculate;
+  return error;
+}
+
+void File::Clear() {
+  m_stream = nullptr;
+  m_descriptor = -1;
+  m_options = 0;
+  m_own_stream = false;
+  m_is_interactive = m_supports_colors = m_is_real_terminal =
+      eLazyBoolCalculate;
+}
+
+Error File::GetFileSpec(FileSpec &file_spec) const {
+  Error error;
+#ifdef LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED
+  if (IsValid()) {
+    char path[PATH_MAX];
+    if (::fcntl(GetDescriptor(), F_GETPATH, path) == -1)
+      error.SetErrorToErrno();
+    else
+      file_spec.SetFile(path, false);
+  } else {
+    error.SetErrorString("invalid file handle");
+  }
+#elif defined(__linux__)
+  char proc[64];
+  char path[PATH_MAX];
+  if (::snprintf(proc, sizeof(proc), "/proc/self/fd/%d", GetDescriptor()) < 0)
+    error.SetErrorString("cannot resolve file descriptor");
+  else {
+    ssize_t len;
+    if ((len = ::readlink(proc, path, sizeof(path) - 1)) == -1)
+      error.SetErrorToErrno();
+    else {
+      path[len] = '\0';
+      file_spec.SetFile(path, false);
+    }
+  }
+#else
+  error.SetErrorString("File::GetFileSpec is not supported on this platform");
+#endif
 
-    do
-    {
+  if (error.Fail())
+    file_spec.Clear();
+  return error;
+}
+
+off_t File::SeekFromStart(off_t offset, Error *error_ptr) {
+  off_t result = 0;
+  if (DescriptorIsValid()) {
+    result = ::lseek(m_descriptor, offset, SEEK_SET);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (StreamIsValid()) {
+    result = ::fseek(m_stream, offset, SEEK_SET);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (error_ptr) {
+    error_ptr->SetErrorString("invalid file handle");
+  }
+  return result;
+}
+
+off_t File::SeekFromCurrent(off_t offset, Error *error_ptr) {
+  off_t result = -1;
+  if (DescriptorIsValid()) {
+    result = ::lseek(m_descriptor, offset, SEEK_CUR);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (StreamIsValid()) {
+    result = ::fseek(m_stream, offset, SEEK_CUR);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (error_ptr) {
+    error_ptr->SetErrorString("invalid file handle");
+  }
+  return result;
+}
+
+off_t File::SeekFromEnd(off_t offset, Error *error_ptr) {
+  off_t result = -1;
+  if (DescriptorIsValid()) {
+    result = ::lseek(m_descriptor, offset, SEEK_END);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (StreamIsValid()) {
+    result = ::fseek(m_stream, offset, SEEK_END);
+
+    if (error_ptr) {
+      if (result == -1)
+        error_ptr->SetErrorToErrno();
+      else
+        error_ptr->Clear();
+    }
+  } else if (error_ptr) {
+    error_ptr->SetErrorString("invalid file handle");
+  }
+  return result;
+}
+
+Error File::Flush() {
+  Error error;
+  if (StreamIsValid()) {
+    int err = 0;
+    do {
+      err = ::fflush(m_stream);
+    } while (err == EOF && errno == EINTR);
+
+    if (err == EOF)
+      error.SetErrorToErrno();
+  } else if (!DescriptorIsValid()) {
+    error.SetErrorString("invalid file handle");
+  }
+  return error;
+}
+
+Error File::Sync() {
+  Error error;
+  if (DescriptorIsValid()) {
 #ifdef _WIN32
-        std::wstring wpath;
-        if (!llvm::ConvertUTF8toWide(path, wpath))
-        {
-            m_descriptor = -1;
-            error.SetErrorString("Error converting path to UTF-16");
-            return error;
-        }
-        ::_wsopen_s(&m_descriptor, wpath.c_str(), oflag, _SH_DENYNO, mode);
+    int err = FlushFileBuffers((HANDLE)_get_osfhandle(m_descriptor));
+    if (err == 0)
+      error.SetErrorToGenericError();
 #else
-        m_descriptor = ::open(path, oflag, mode);
-#endif
-    } while (m_descriptor < 0 && errno == EINTR);
+    int err = 0;
+    do {
+      err = ::fsync(m_descriptor);
+    } while (err == -1 && errno == EINTR);
 
-    if (!DescriptorIsValid())
-        error.SetErrorToErrno();
-    else
-    {
-        m_should_close_fd = true;
-        m_options = options;
-    }
-    
-    return error;
+    if (err == -1)
+      error.SetErrorToErrno();
+#endif
+  } else {
+    error.SetErrorString("invalid file handle");
+  }
+  return error;
 }
 
-uint32_t
-File::GetPermissions(const FileSpec &file_spec, Error &error)
-{
-    if (file_spec)
-    {
-        struct stat file_stats;
-        int stat_result = FileSystem::Stat(file_spec.GetCString(), &file_stats);
-        if (stat_result == -1)
-            error.SetErrorToErrno();
-        else
-        {
-            error.Clear();
-            return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
-        }
-    }
-    else
-        error.SetErrorString ("empty file spec");
-    return 0;
-}
+#if defined(__APPLE__)
+// Darwin kernels only can read/write <= INT_MAX bytes
+#define MAX_READ_SIZE INT_MAX
+#define MAX_WRITE_SIZE INT_MAX
+#endif
 
-uint32_t
-File::GetPermissions(Error &error) const
-{
-    int fd = GetDescriptor();
-    if (fd != kInvalidDescriptor)
-    {
-        struct stat file_stats;
-        if (::fstat (fd, &file_stats) == -1)
-            error.SetErrorToErrno();
-        else
-        {
-            error.Clear();
-            return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
-        }
-    }
-    else
-    {
-        error.SetErrorString ("invalid file descriptor");
-    }
-    return 0;
-}
+Error File::Read(void *buf, size_t &num_bytes) {
+  Error error;
 
+#if defined(MAX_READ_SIZE)
+  if (num_bytes > MAX_READ_SIZE) {
+    uint8_t *p = (uint8_t *)buf;
+    size_t bytes_left = num_bytes;
+    // Init the num_bytes read to zero
+    num_bytes = 0;
 
-Error
-File::Close ()
-{
-    Error error;
-    if (StreamIsValid() && m_own_stream)
-    {
-        if (::fclose (m_stream) == EOF)
-            error.SetErrorToErrno();
-    }
-    
-    if (DescriptorIsValid() && m_should_close_fd)
-    {
-        if (::close (m_descriptor) != 0)
-            error.SetErrorToErrno();
-    }
-    m_descriptor = kInvalidDescriptor;
-    m_stream = kInvalidStream;
-    m_options = 0;
-    m_own_stream = false;
-    m_should_close_fd = false;
-    m_is_interactive = eLazyBoolCalculate;
-    m_is_real_terminal = eLazyBoolCalculate;
-    return error;
-}
+    while (bytes_left > 0) {
+      size_t curr_num_bytes;
+      if (bytes_left > MAX_READ_SIZE)
+        curr_num_bytes = MAX_READ_SIZE;
+      else
+        curr_num_bytes = bytes_left;
 
-void
-File::Clear ()
-{
-    m_stream = nullptr;
-    m_descriptor = -1;
-    m_options = 0;
-    m_own_stream = false;
-    m_is_interactive = m_supports_colors = m_is_real_terminal = eLazyBoolCalculate;
-}
+      error = Read(p + num_bytes, curr_num_bytes);
 
-Error
-File::GetFileSpec (FileSpec &file_spec) const
-{
-    Error error;
-#ifdef LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED
-    if (IsValid ())
-    {
-        char path[PATH_MAX];
-        if (::fcntl(GetDescriptor(), F_GETPATH, path) == -1)
-            error.SetErrorToErrno();
-        else
-            file_spec.SetFile (path, false);
-    }
-    else 
-    {
-        error.SetErrorString("invalid file handle");
-    }
-#elif defined(__linux__)
-    char proc[64];
-    char path[PATH_MAX];
-    if (::snprintf(proc, sizeof(proc), "/proc/self/fd/%d", GetDescriptor()) < 0)
-        error.SetErrorString ("cannot resolve file descriptor");
-    else
-    {
-        ssize_t len;
-        if ((len = ::readlink(proc, path, sizeof(path) - 1)) == -1)
-            error.SetErrorToErrno();
-        else
-        {
-            path[len] = '\0';
-            file_spec.SetFile (path, false);
-        }
+      // Update how many bytes were read
+      num_bytes += curr_num_bytes;
+      if (bytes_left < curr_num_bytes)
+        bytes_left = 0;
+      else
+        bytes_left -= curr_num_bytes;
+
+      if (error.Fail())
+        break;
     }
-#else
-    error.SetErrorString ("File::GetFileSpec is not supported on this platform");
+    return error;
+  }
 #endif
 
-    if (error.Fail())
-        file_spec.Clear();
-    return error;
+  ssize_t bytes_read = -1;
+  if (DescriptorIsValid()) {
+    do {
+      bytes_read = ::read(m_descriptor, buf, num_bytes);
+    } while (bytes_read < 0 && errno == EINTR);
+
+    if (bytes_read == -1) {
+      error.SetErrorToErrno();
+      num_bytes = 0;
+    } else
+      num_bytes = bytes_read;
+  } else if (StreamIsValid()) {
+    bytes_read = ::fread(buf, 1, num_bytes, m_stream);
+
+    if (bytes_read == 0) {
+      if (::feof(m_stream))
+        error.SetErrorString("feof");
+      else if (::ferror(m_stream))
+        error.SetErrorString("ferror");
+      num_bytes = 0;
+    } else
+      num_bytes = bytes_read;
+  } else {
+    num_bytes = 0;
+    error.SetErrorString("invalid file handle");
+  }
+  return error;
 }
 
-off_t
-File::SeekFromStart (off_t offset, Error *error_ptr)
-{
-    off_t result = 0;
-    if (DescriptorIsValid())
-    {
-        result = ::lseek (m_descriptor, offset, SEEK_SET);
-
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (StreamIsValid ())
-    {
-        result = ::fseek(m_stream, offset, SEEK_SET);
-        
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (error_ptr)
-    {
-        error_ptr->SetErrorString("invalid file handle");
-    }
-    return result;
-}
+Error File::Write(const void *buf, size_t &num_bytes) {
+  Error error;
 
-off_t
-File::SeekFromCurrent (off_t offset,  Error *error_ptr)
-{
-    off_t result = -1;
-    if (DescriptorIsValid())
-    {
-        result = ::lseek (m_descriptor, offset, SEEK_CUR);
-        
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (StreamIsValid ())
-    {
-        result = ::fseek(m_stream, offset, SEEK_CUR);
-        
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (error_ptr)
-    {
-        error_ptr->SetErrorString("invalid file handle");
-    }
-    return result;
-}
+#if defined(MAX_WRITE_SIZE)
+  if (num_bytes > MAX_WRITE_SIZE) {
+    const uint8_t *p = (const uint8_t *)buf;
+    size_t bytes_left = num_bytes;
+    // Init the num_bytes written to zero
+    num_bytes = 0;
 
-off_t
-File::SeekFromEnd (off_t offset, Error *error_ptr)
-{
-    off_t result = -1;
-    if (DescriptorIsValid())
-    {
-        result = ::lseek (m_descriptor, offset, SEEK_END);
-        
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (StreamIsValid ())
-    {
-        result = ::fseek(m_stream, offset, SEEK_END);
-        
-        if (error_ptr)
-        {
-            if (result == -1)
-                error_ptr->SetErrorToErrno();
-            else
-                error_ptr->Clear();
-        }
-    }
-    else if (error_ptr)
-    {
-        error_ptr->SetErrorString("invalid file handle");
-    }
-    return result;
-}
+    while (bytes_left > 0) {
+      size_t curr_num_bytes;
+      if (bytes_left > MAX_WRITE_SIZE)
+        curr_num_bytes = MAX_WRITE_SIZE;
+      else
+        curr_num_bytes = bytes_left;
 
-Error
-File::Flush ()
-{
-    Error error;
-    if (StreamIsValid())
-    {
-        int err = 0;
-        do
-        {
-            err = ::fflush (m_stream);
-        } while (err == EOF && errno == EINTR);
-        
-        if (err == EOF)
-            error.SetErrorToErrno();
-    }
-    else if (!DescriptorIsValid())
-    {
-        error.SetErrorString("invalid file handle");
-    }
-    return error;
-}
+      error = Write(p + num_bytes, curr_num_bytes);
 
+      // Update how many bytes were read
+      num_bytes += curr_num_bytes;
+      if (bytes_left < curr_num_bytes)
+        bytes_left = 0;
+      else
+        bytes_left -= curr_num_bytes;
 
-Error
-File::Sync ()
-{
-    Error error;
-    if (DescriptorIsValid())
-    {
-#ifdef _WIN32
-        int err = FlushFileBuffers((HANDLE)_get_osfhandle(m_descriptor));
-        if (err == 0)
-            error.SetErrorToGenericError();
-#else
-        int err = 0;
-        do
-        {
-            err = ::fsync (m_descriptor);
-        } while (err == -1 && errno == EINTR);
-        
-        if (err == -1)
-            error.SetErrorToErrno();
-#endif
-    }
-    else 
-    {
-        error.SetErrorString("invalid file handle");
+      if (error.Fail())
+        break;
     }
     return error;
-}
-
-#if defined (__APPLE__)
-// Darwin kernels only can read/write <= INT_MAX bytes
-#define MAX_READ_SIZE INT_MAX
-#define MAX_WRITE_SIZE INT_MAX
+  }
 #endif
 
-Error
-File::Read (void *buf, size_t &num_bytes)
-{
-    Error error;
-
-#if defined (MAX_READ_SIZE)
-    if (num_bytes > MAX_READ_SIZE)
-    {
-        uint8_t *p = (uint8_t *)buf;
-        size_t bytes_left = num_bytes;
-        // Init the num_bytes read to zero
-        num_bytes = 0;
-
-        while (bytes_left > 0)
-        {
-            size_t curr_num_bytes;
-            if (bytes_left > MAX_READ_SIZE)
-                curr_num_bytes = MAX_READ_SIZE;
-            else
-                curr_num_bytes = bytes_left;
-
-            error = Read (p + num_bytes, curr_num_bytes);
-
-            // Update how many bytes were read
-            num_bytes += curr_num_bytes;
-            if (bytes_left < curr_num_bytes)
-                bytes_left = 0;
-            else
-                bytes_left -= curr_num_bytes;
-
-            if (error.Fail())
-                break;
-        }
-        return error;
-    }
-#endif
+  ssize_t bytes_written = -1;
+  if (DescriptorIsValid()) {
+    do {
+      bytes_written = ::write(m_descriptor, buf, num_bytes);
+    } while (bytes_written < 0 && errno == EINTR);
+
+    if (bytes_written == -1) {
+      error.SetErrorToErrno();
+      num_bytes = 0;
+    } else
+      num_bytes = bytes_written;
+  } else if (StreamIsValid()) {
+    bytes_written = ::fwrite(buf, 1, num_bytes, m_stream);
+
+    if (bytes_written == 0) {
+      if (::feof(m_stream))
+        error.SetErrorString("feof");
+      else if (::ferror(m_stream))
+        error.SetErrorString("ferror");
+      num_bytes = 0;
+    } else
+      num_bytes = bytes_written;
+
+  } else {
+    num_bytes = 0;
+    error.SetErrorString("invalid file handle");
+  }
 
-    ssize_t bytes_read = -1;
-    if (DescriptorIsValid())
-    {
-        do
-        {
-            bytes_read = ::read (m_descriptor, buf, num_bytes);
-        } while (bytes_read < 0 && errno == EINTR);
-
-        if (bytes_read == -1)
-        {
-            error.SetErrorToErrno();
-            num_bytes = 0;
-        }
-        else
-            num_bytes = bytes_read;
-    }
-    else if (StreamIsValid())
-    {
-        bytes_read = ::fread (buf, 1, num_bytes, m_stream);
-
-        if (bytes_read == 0)
-        {
-            if (::feof(m_stream))
-                error.SetErrorString ("feof");
-            else if (::ferror (m_stream))
-                error.SetErrorString ("ferror");
-            num_bytes = 0;
-        }
-        else
-            num_bytes = bytes_read;
-    }
-    else 
-    {
-        num_bytes = 0;
-        error.SetErrorString("invalid file handle");
-    }
-    return error;
+  return error;
 }
-          
-Error
-File::Write (const void *buf, size_t &num_bytes)
-{
-    Error error;
-
-#if defined (MAX_WRITE_SIZE)
-    if (num_bytes > MAX_WRITE_SIZE)
-    {
-        const uint8_t *p = (const uint8_t *)buf;
-        size_t bytes_left = num_bytes;
-        // Init the num_bytes written to zero
-        num_bytes = 0;
-
-        while (bytes_left > 0)
-        {
-            size_t curr_num_bytes;
-            if (bytes_left > MAX_WRITE_SIZE)
-                curr_num_bytes = MAX_WRITE_SIZE;
-            else
-                curr_num_bytes = bytes_left;
-
-            error = Write (p + num_bytes, curr_num_bytes);
-
-            // Update how many bytes were read
-            num_bytes += curr_num_bytes;
-            if (bytes_left < curr_num_bytes)
-                bytes_left = 0;
-            else
-                bytes_left -= curr_num_bytes;
-
-            if (error.Fail())
-                break;
-        }
-        return error;
-    }
-#endif
 
-    ssize_t bytes_written = -1;
-    if (DescriptorIsValid())
-    {
-        do
-        {
-            bytes_written = ::write (m_descriptor, buf, num_bytes);
-        } while (bytes_written < 0 && errno == EINTR);
-
-        if (bytes_written == -1)
-        {
-            error.SetErrorToErrno();
-            num_bytes = 0;
-        }
-        else
-            num_bytes = bytes_written;
-    }
-    else if (StreamIsValid())
-    {
-        bytes_written = ::fwrite (buf, 1, num_bytes, m_stream);
-
-        if (bytes_written == 0)
-        {
-            if (::feof(m_stream))
-                error.SetErrorString ("feof");
-            else if (::ferror (m_stream))
-                error.SetErrorString ("ferror");
-            num_bytes = 0;
-        }
-        else
-            num_bytes = bytes_written;
-        
-    }
-    else 
-    {
-        num_bytes = 0;
-        error.SetErrorString("invalid file handle");
-    }
+Error File::Read(void *buf, size_t &num_bytes, off_t &offset) {
+  Error error;
 
-    return error;
-}
+#if defined(MAX_READ_SIZE)
+  if (num_bytes > MAX_READ_SIZE) {
+    uint8_t *p = (uint8_t *)buf;
+    size_t bytes_left = num_bytes;
+    // Init the num_bytes read to zero
+    num_bytes = 0;
 
+    while (bytes_left > 0) {
+      size_t curr_num_bytes;
+      if (bytes_left > MAX_READ_SIZE)
+        curr_num_bytes = MAX_READ_SIZE;
+      else
+        curr_num_bytes = bytes_left;
 
-Error
-File::Read (void *buf, size_t &num_bytes, off_t &offset)
-{
-    Error error;
-
-#if defined (MAX_READ_SIZE)
-    if (num_bytes > MAX_READ_SIZE)
-    {
-        uint8_t *p = (uint8_t *)buf;
-        size_t bytes_left = num_bytes;
-        // Init the num_bytes read to zero
-        num_bytes = 0;
-
-        while (bytes_left > 0)
-        {
-            size_t curr_num_bytes;
-            if (bytes_left > MAX_READ_SIZE)
-                curr_num_bytes = MAX_READ_SIZE;
-            else
-                curr_num_bytes = bytes_left;
-
-            error = Read (p + num_bytes, curr_num_bytes, offset);
-
-            // Update how many bytes were read
-            num_bytes += curr_num_bytes;
-            if (bytes_left < curr_num_bytes)
-                bytes_left = 0;
-            else
-                bytes_left -= curr_num_bytes;
-
-            if (error.Fail())
-                break;
-        }
-        return error;
+      error = Read(p + num_bytes, curr_num_bytes, offset);
+
+      // Update how many bytes were read
+      num_bytes += curr_num_bytes;
+      if (bytes_left < curr_num_bytes)
+        bytes_left = 0;
+      else
+        bytes_left -= curr_num_bytes;
+
+      if (error.Fail())
+        break;
     }
+    return error;
+  }
 #endif
 
 #ifndef _WIN32
-    int fd = GetDescriptor();
-    if (fd != kInvalidDescriptor)
-    {
-        ssize_t bytes_read = -1;
-        do
-        {
-            bytes_read = ::pread (fd, buf, num_bytes, offset);
-        } while (bytes_read < 0 && errno == EINTR);
-
-        if (bytes_read < 0)
-        {
-            num_bytes = 0;
-            error.SetErrorToErrno();
-        }
-        else
-        {
-            offset += bytes_read;
-            num_bytes = bytes_read;
-        }
-    }
-    else 
-    {
-        num_bytes = 0;
-        error.SetErrorString("invalid file handle");
-    }
+  int fd = GetDescriptor();
+  if (fd != kInvalidDescriptor) {
+    ssize_t bytes_read = -1;
+    do {
+      bytes_read = ::pread(fd, buf, num_bytes, offset);
+    } while (bytes_read < 0 && errno == EINTR);
+
+    if (bytes_read < 0) {
+      num_bytes = 0;
+      error.SetErrorToErrno();
+    } else {
+      offset += bytes_read;
+      num_bytes = bytes_read;
+    }
+  } else {
+    num_bytes = 0;
+    error.SetErrorString("invalid file handle");
+  }
 #else
-    long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
-    SeekFromStart(offset);
-    error = Read(buf, num_bytes);
-    if (!error.Fail())
-        SeekFromStart(cur);
+  long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
+  SeekFromStart(offset);
+  error = Read(buf, num_bytes);
+  if (!error.Fail())
+    SeekFromStart(cur);
 #endif
-    return error;
+  return error;
 }
 
-Error
-File::Read (size_t &num_bytes, off_t &offset, bool null_terminate, DataBufferSP &data_buffer_sp)
-{
-    Error error;
-    
-    if (num_bytes > 0)
-    {
-        int fd = GetDescriptor();
-        if (fd != kInvalidDescriptor)
-        {
-            struct stat file_stats;
-            if (::fstat (fd, &file_stats) == 0)
-            {
-                if (file_stats.st_size > offset)
-                {
-                    const size_t bytes_left = file_stats.st_size - offset;
-                    if (num_bytes > bytes_left)
-                        num_bytes = bytes_left;
-                        
-                    size_t num_bytes_plus_nul_char = num_bytes + (null_terminate ? 1 : 0);
-                    std::unique_ptr<DataBufferHeap> data_heap_ap;
-                    data_heap_ap.reset(new DataBufferHeap());
-                    data_heap_ap->SetByteSize(num_bytes_plus_nul_char);
-                        
-                    if (data_heap_ap.get())
-                    {
-                        error = Read (data_heap_ap->GetBytes(), num_bytes, offset);
-                        if (error.Success())
-                        {
-                            // Make sure we read exactly what we asked for and if we got
-                            // less, adjust the array
-                            if (num_bytes_plus_nul_char < data_heap_ap->GetByteSize())
-                                data_heap_ap->SetByteSize(num_bytes_plus_nul_char);
-                            data_buffer_sp.reset(data_heap_ap.release());
-                            return error;
-                        }
-                    }
-                }
-                else 
-                    error.SetErrorString("file is empty");
+Error File::Read(size_t &num_bytes, off_t &offset, bool null_terminate,
+                 DataBufferSP &data_buffer_sp) {
+  Error error;
+
+  if (num_bytes > 0) {
+    int fd = GetDescriptor();
+    if (fd != kInvalidDescriptor) {
+      struct stat file_stats;
+      if (::fstat(fd, &file_stats) == 0) {
+        if (file_stats.st_size > offset) {
+          const size_t bytes_left = file_stats.st_size - offset;
+          if (num_bytes > bytes_left)
+            num_bytes = bytes_left;
+
+          size_t num_bytes_plus_nul_char = num_bytes + (null_terminate ? 1 : 0);
+          std::unique_ptr<DataBufferHeap> data_heap_ap;
+          data_heap_ap.reset(new DataBufferHeap());
+          data_heap_ap->SetByteSize(num_bytes_plus_nul_char);
+
+          if (data_heap_ap.get()) {
+            error = Read(data_heap_ap->GetBytes(), num_bytes, offset);
+            if (error.Success()) {
+              // Make sure we read exactly what we asked for and if we got
+              // less, adjust the array
+              if (num_bytes_plus_nul_char < data_heap_ap->GetByteSize())
+                data_heap_ap->SetByteSize(num_bytes_plus_nul_char);
+              data_buffer_sp.reset(data_heap_ap.release());
+              return error;
             }
-            else
-                error.SetErrorToErrno();
-        }
-        else 
-            error.SetErrorString("invalid file handle");
-    }
-    else
-        error.SetErrorString("invalid file handle");
+          }
+        } else
+          error.SetErrorString("file is empty");
+      } else
+        error.SetErrorToErrno();
+    } else
+      error.SetErrorString("invalid file handle");
+  } else
+    error.SetErrorString("invalid file handle");
 
-    num_bytes = 0;
-    data_buffer_sp.reset();
-    return error;
+  num_bytes = 0;
+  data_buffer_sp.reset();
+  return error;
 }
 
-Error
-File::Write (const void *buf, size_t &num_bytes, off_t &offset)
-{
-    Error error;
-
-#if defined (MAX_WRITE_SIZE)
-    if (num_bytes > MAX_WRITE_SIZE)
-    {
-        const uint8_t *p = (const uint8_t *)buf;
-        size_t bytes_left = num_bytes;
-        // Init the num_bytes written to zero
-        num_bytes = 0;
-
-        while (bytes_left > 0)
-        {
-            size_t curr_num_bytes;
-            if (bytes_left > MAX_WRITE_SIZE)
-                curr_num_bytes = MAX_WRITE_SIZE;
-            else
-                curr_num_bytes = bytes_left;
-
-            error = Write (p + num_bytes, curr_num_bytes, offset);
-
-            // Update how many bytes were read
-            num_bytes += curr_num_bytes;
-            if (bytes_left < curr_num_bytes)
-                bytes_left = 0;
-            else
-                bytes_left -= curr_num_bytes;
-
-            if (error.Fail())
-                break;
-        }
-        return error;
+Error File::Write(const void *buf, size_t &num_bytes, off_t &offset) {
+  Error error;
+
+#if defined(MAX_WRITE_SIZE)
+  if (num_bytes > MAX_WRITE_SIZE) {
+    const uint8_t *p = (const uint8_t *)buf;
+    size_t bytes_left = num_bytes;
+    // Init the num_bytes written to zero
+    num_bytes = 0;
+
+    while (bytes_left > 0) {
+      size_t curr_num_bytes;
+      if (bytes_left > MAX_WRITE_SIZE)
+        curr_num_bytes = MAX_WRITE_SIZE;
+      else
+        curr_num_bytes = bytes_left;
+
+      error = Write(p + num_bytes, curr_num_bytes, offset);
+
+      // Update how many bytes were read
+      num_bytes += curr_num_bytes;
+      if (bytes_left < curr_num_bytes)
+        bytes_left = 0;
+      else
+        bytes_left -= curr_num_bytes;
+
+      if (error.Fail())
+        break;
     }
+    return error;
+  }
 #endif
 
-    int fd = GetDescriptor();
-    if (fd != kInvalidDescriptor)
-    {
+  int fd = GetDescriptor();
+  if (fd != kInvalidDescriptor) {
 #ifndef _WIN32
-        ssize_t bytes_written = -1;
-        do
-        {
-            bytes_written = ::pwrite (m_descriptor, buf, num_bytes, offset);
-        } while (bytes_written < 0 && errno == EINTR);
-
-        if (bytes_written < 0)
-        {
-            num_bytes = 0;
-            error.SetErrorToErrno();
-        }
-        else
-        {
-            offset += bytes_written;
-            num_bytes = bytes_written;
-        }
+    ssize_t bytes_written = -1;
+    do {
+      bytes_written = ::pwrite(m_descriptor, buf, num_bytes, offset);
+    } while (bytes_written < 0 && errno == EINTR);
+
+    if (bytes_written < 0) {
+      num_bytes = 0;
+      error.SetErrorToErrno();
+    } else {
+      offset += bytes_written;
+      num_bytes = bytes_written;
+    }
 #else
-        long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
-        error = Write(buf, num_bytes);
-        long after = ::lseek(m_descriptor, 0, SEEK_CUR);
+    long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
+    error = Write(buf, num_bytes);
+    long after = ::lseek(m_descriptor, 0, SEEK_CUR);
 
-        if (!error.Fail())
-            SeekFromStart(cur);
+    if (!error.Fail())
+      SeekFromStart(cur);
 
-        offset = after;
+    offset = after;
 #endif
-    }
-    else 
-    {
-        num_bytes = 0;
-        error.SetErrorString("invalid file handle");
-    }
-    return error;
+  } else {
+    num_bytes = 0;
+    error.SetErrorString("invalid file handle");
+  }
+  return error;
 }
 
 //------------------------------------------------------------------
 // Print some formatted output to the stream.
 //------------------------------------------------------------------
-size_t
-File::Printf (const char *format, ...)
-{
-    va_list args;
-    va_start (args, format);
-    size_t result = PrintfVarArg (format, args);
-    va_end (args);
-    return result;
+size_t File::Printf(const char *format, ...) {
+  va_list args;
+  va_start(args, format);
+  size_t result = PrintfVarArg(format, args);
+  va_end(args);
+  return result;
 }
 
 //------------------------------------------------------------------
 // Print some formatted output to the stream.
 //------------------------------------------------------------------
-size_t
-File::PrintfVarArg (const char *format, va_list args)
-{
-    size_t result = 0;
-    if (DescriptorIsValid())
-    {
-        char *s = NULL;
-        result = vasprintf(&s, format, args);
-        if (s != NULL)
-        {
-            if (result > 0)
-            {
-                size_t s_len = result;
-                Write (s, s_len);
-                result = s_len;
-            }
-            free (s);
-        }
-    }
-    else if (StreamIsValid())
-    {
-        result = ::vfprintf (m_stream, format, args);
-    }
-    return result;
-}
-
-mode_t
-File::ConvertOpenOptionsForPOSIXOpen (uint32_t open_options)
-{
-    mode_t mode = 0;
-    if (open_options & eOpenOptionRead && open_options & eOpenOptionWrite)
-        mode |= O_RDWR;
-    else if (open_options & eOpenOptionWrite)
-        mode |= O_WRONLY;
-    
-    if (open_options & eOpenOptionAppend)
-        mode |= O_APPEND;
-
-    if (open_options & eOpenOptionTruncate)
-        mode |= O_TRUNC;
-
-    if (open_options & eOpenOptionNonBlocking)
-        mode |= O_NONBLOCK;
-
-    if (open_options & eOpenOptionCanCreateNewOnly)
-        mode |= O_CREAT | O_EXCL;
-    else if (open_options & eOpenOptionCanCreate)
-        mode |= O_CREAT;
-
-    return mode;
-}
-
-void
-File::CalculateInteractiveAndTerminal ()
-{
-    const int fd = GetDescriptor();
-    if (fd >= 0)
-    {
-        m_is_interactive = eLazyBoolNo;
-        m_is_real_terminal = eLazyBoolNo;
+size_t File::PrintfVarArg(const char *format, va_list args) {
+  size_t result = 0;
+  if (DescriptorIsValid()) {
+    char *s = NULL;
+    result = vasprintf(&s, format, args);
+    if (s != NULL) {
+      if (result > 0) {
+        size_t s_len = result;
+        Write(s, s_len);
+        result = s_len;
+      }
+      free(s);
+    }
+  } else if (StreamIsValid()) {
+    result = ::vfprintf(m_stream, format, args);
+  }
+  return result;
+}
+
+mode_t File::ConvertOpenOptionsForPOSIXOpen(uint32_t open_options) {
+  mode_t mode = 0;
+  if (open_options & eOpenOptionRead && open_options & eOpenOptionWrite)
+    mode |= O_RDWR;
+  else if (open_options & eOpenOptionWrite)
+    mode |= O_WRONLY;
+
+  if (open_options & eOpenOptionAppend)
+    mode |= O_APPEND;
+
+  if (open_options & eOpenOptionTruncate)
+    mode |= O_TRUNC;
+
+  if (open_options & eOpenOptionNonBlocking)
+    mode |= O_NONBLOCK;
+
+  if (open_options & eOpenOptionCanCreateNewOnly)
+    mode |= O_CREAT | O_EXCL;
+  else if (open_options & eOpenOptionCanCreate)
+    mode |= O_CREAT;
+
+  return mode;
+}
+
+void File::CalculateInteractiveAndTerminal() {
+  const int fd = GetDescriptor();
+  if (fd >= 0) {
+    m_is_interactive = eLazyBoolNo;
+    m_is_real_terminal = eLazyBoolNo;
 #if defined(_WIN32)
-        if (_isatty(fd))
-        {
-            m_is_interactive = eLazyBoolYes;
-            m_is_real_terminal = eLazyBoolYes;
-        }
+    if (_isatty(fd)) {
+      m_is_interactive = eLazyBoolYes;
+      m_is_real_terminal = eLazyBoolYes;
+    }
 #else
-        if (isatty(fd))
-        {
-            m_is_interactive = eLazyBoolYes;
-            struct winsize window_size;
-            if (::ioctl (fd, TIOCGWINSZ, &window_size) == 0)
-            {
-                if (window_size.ws_col > 0)
-                {
-                    m_is_real_terminal = eLazyBoolYes;
-                    if (llvm::sys::Process::FileDescriptorHasColors(fd))
-                        m_supports_colors = eLazyBoolYes;
-                }
-            }
+    if (isatty(fd)) {
+      m_is_interactive = eLazyBoolYes;
+      struct winsize window_size;
+      if (::ioctl(fd, TIOCGWINSZ, &window_size) == 0) {
+        if (window_size.ws_col > 0) {
+          m_is_real_terminal = eLazyBoolYes;
+          if (llvm::sys::Process::FileDescriptorHasColors(fd))
+            m_supports_colors = eLazyBoolYes;
         }
-#endif
+      }
     }
+#endif
+  }
 }
 
-bool
-File::GetIsInteractive ()
-{
-    if (m_is_interactive == eLazyBoolCalculate)
-        CalculateInteractiveAndTerminal ();
-    return m_is_interactive == eLazyBoolYes;
+bool File::GetIsInteractive() {
+  if (m_is_interactive == eLazyBoolCalculate)
+    CalculateInteractiveAndTerminal();
+  return m_is_interactive == eLazyBoolYes;
 }
 
-bool
-File::GetIsRealTerminal ()
-{
-    if (m_is_real_terminal == eLazyBoolCalculate)
-        CalculateInteractiveAndTerminal();
-    return m_is_real_terminal == eLazyBoolYes;
+bool File::GetIsRealTerminal() {
+  if (m_is_real_terminal == eLazyBoolCalculate)
+    CalculateInteractiveAndTerminal();
+  return m_is_real_terminal == eLazyBoolYes;
 }
 
-bool
-File::GetIsTerminalWithColors ()
-{
-    if (m_supports_colors == eLazyBoolCalculate)
-        CalculateInteractiveAndTerminal();
-    return m_supports_colors == eLazyBoolYes;
+bool File::GetIsTerminalWithColors() {
+  if (m_supports_colors == eLazyBoolCalculate)
+    CalculateInteractiveAndTerminal();
+  return m_supports_colors == eLazyBoolYes;
 }
-