summaryrefslogtreecommitdiffstats
path: root/cddl/contrib/opensolaris
diff options
context:
space:
mode:
authormav <mav@FreeBSD.org>2014-05-10 15:21:37 +0000
committermav <mav@FreeBSD.org>2014-05-10 15:21:37 +0000
commitcfea4862aa9adab7aafc28b0ee56bfe6ce823d40 (patch)
tree2e3830f2fff2268206ec151767047172aa7d00a0 /cddl/contrib/opensolaris
parent9304f109703b4b2a6d6a9469559e8f59e236e502 (diff)
downloadFreeBSD-src-cfea4862aa9adab7aafc28b0ee56bfe6ce823d40.zip
FreeBSD-src-cfea4862aa9adab7aafc28b0ee56bfe6ce823d40.tar.gz
Comment out some pointless device open/close around reading device IDs.
FreeBSD ZFS port unlike OpenSolaris does not use device IDs, and does not implement respective devid_*() fuctions. It is pointless to open devices just to close them back immediately. MFC after: 2 weeks Sponsored by: iXsystems, Inc.
Diffstat (limited to 'cddl/contrib/opensolaris')
-rw-r--r--cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c2
-rw-r--r--cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c4
-rw-r--r--cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c4
3 files changed, 10 insertions, 0 deletions
diff --git a/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c b/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c
index 5ffd39a..374798b 100644
--- a/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c
+++ b/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c
@@ -512,6 +512,7 @@ make_leaf_vdev(const char *arg, uint64_t is_log)
verify(nvlist_add_uint64(vdev, ZPOOL_CONFIG_WHOLE_DISK,
(uint64_t)wholedisk) == 0);
+#ifdef have_devid
/*
* For a whole disk, defer getting its devid until after labeling it.
*/
@@ -546,6 +547,7 @@ make_leaf_vdev(const char *arg, uint64_t is_log)
(void) close(fd);
}
+#endif
return (vdev);
}
diff --git a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
index e53a8cd..868961d 100644
--- a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
+++ b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
@@ -94,6 +94,7 @@ typedef struct pool_list {
static char *
get_devid(const char *path)
{
+#ifdef have_devid
int fd;
ddi_devid_t devid;
char *minor, *ret;
@@ -113,6 +114,9 @@ get_devid(const char *path)
(void) close(fd);
return (ret);
+#else
+ return (NULL);
+#endif
}
diff --git a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
index 8dd24a7..02f0b96 100644
--- a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
+++ b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
@@ -3324,6 +3324,7 @@ devid_to_path(char *devid_str)
static char *
path_to_devid(const char *path)
{
+#ifdef have_devid
int fd;
ddi_devid_t devid;
char *minor, *ret;
@@ -3343,6 +3344,9 @@ path_to_devid(const char *path)
(void) close(fd);
return (ret);
+#else
+ return (NULL);
+#endif
}
/*
OpenPOWER on IntegriCloud