summaryrefslogtreecommitdiffstats
path: root/bin/sh
diff options
context:
space:
mode:
authorjilles <jilles@FreeBSD.org>2014-03-27 22:52:26 +0000
committerjilles <jilles@FreeBSD.org>2014-03-27 22:52:26 +0000
commitce55d2a4469eaa4ee8a72a8428ecd64d53a14db1 (patch)
tree3707c01f1bc7fd0c5e4df96dc6012035f0994684 /bin/sh
parente280748468fa2cf51d6430354e95942d8fc8a41c (diff)
downloadFreeBSD-src-ce55d2a4469eaa4ee8a72a8428ecd64d53a14db1.zip
FreeBSD-src-ce55d2a4469eaa4ee8a72a8428ecd64d53a14db1.tar.gz
sh: Fix memory leak when trying to set a read only variable.
MFC after: 1 week
Diffstat (limited to 'bin/sh')
-rw-r--r--bin/sh/var.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/bin/sh/var.c b/bin/sh/var.c
index 6c0685f..da13de7 100644
--- a/bin/sh/var.c
+++ b/bin/sh/var.c
@@ -325,8 +325,11 @@ setvareq(char *s, int flags)
mklocal(s);
vp = find_var(s, &vpp, &nlen);
if (vp != NULL) {
- if (vp->flags & VREADONLY)
+ if (vp->flags & VREADONLY) {
+ if ((flags & (VTEXTFIXED|VSTACK)) == 0)
+ ckfree(s);
error("%.*s: is read only", vp->name_len, s);
+ }
if (flags & VNOSET)
return;
INTOFF;
OpenPOWER on IntegriCloud