summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authored <ed@FreeBSD.org>2010-01-22 04:53:08 +0000
committered <ed@FreeBSD.org>2010-01-22 04:53:08 +0000
commite175594ed6eabbf2370dbe1493450a8ed3cd965d (patch)
tree9ab7eb28cc30e435838add5cebc5522933c1bfad
parent1f76b82e021e7b18c5283388ed1420165cc14eac (diff)
downloadFreeBSD-src-e175594ed6eabbf2370dbe1493450a8ed3cd965d.zip
FreeBSD-src-e175594ed6eabbf2370dbe1493450a8ed3cd965d.tar.gz
Remove comments about breaking the specification.
I've discussed this issue with the Austin Group and it will be fixed in future revisions of the specification. The issue was that ut_line fields weren't supposed to be valid for LOGIN_PROCESS entries, while getutxline() would try to match these records anyway. They also agreed on our way of implementing pututxline() without getutxid() (which other operating systems also do), but unfortunately they disagreed with our way of replacing DEAD_PROCESS entries, which is a pity. The current specification allows the utmpx database to become infinitely big over time. See also: http://austingroupbugs.net/view.php?id=213#c378
-rw-r--r--lib/libc/gen/utxdb.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/libc/gen/utxdb.c b/lib/libc/gen/utxdb.c
index 224d86b..49118ff 100644
--- a/lib/libc/gen/utxdb.c
+++ b/lib/libc/gen/utxdb.c
@@ -83,7 +83,6 @@ utx_to_futx(const struct utmpx *ut, struct futx *fu)
case LOGIN_PROCESS:
UTOF_ID(ut, fu);
UTOF_STRING(ut, fu, user);
- /* XXX: bug in the specification? Needed for getutxline(). */
UTOF_STRING(ut, fu, line);
UTOF_PID(ut, fu);
break;
@@ -156,7 +155,6 @@ futx_to_utx(const struct futx *fu)
case LOGIN_PROCESS:
FTOU_ID(fu, ut);
FTOU_STRING(fu, ut, user);
- /* XXX: bug in the specification? Needed for getutxline(). */
FTOU_STRING(fu, ut, line);
FTOU_PID(fu, ut);
break;
OpenPOWER on IntegriCloud