summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjhb <jhb@FreeBSD.org>2014-06-17 18:10:06 +0000
committerjhb <jhb@FreeBSD.org>2014-06-17 18:10:06 +0000
commitde01564f85dd2c8820a72db1ddf2f8d255ce5a95 (patch)
treeea824c0c40c8932c8b18fab28129f3863704ebf8
parent62a8e1478616b326b74025a31370799c935ce0e7 (diff)
downloadFreeBSD-src-de01564f85dd2c8820a72db1ddf2f8d255ce5a95.zip
FreeBSD-src-de01564f85dd2c8820a72db1ddf2f8d255ce5a95.tar.gz
Don't bother clearing maps for static DMA allocations to NULL. Instead,
leave them as purely opaque values that are only set by bus_dmamem_alloc().
-rw-r--r--sys/arm/at91/if_ate.c1
-rw-r--r--sys/dev/ahci/ahci.c2
-rw-r--r--sys/dev/ata/ata-dma.c1
-rw-r--r--sys/dev/de/if_de.c2
-rw-r--r--sys/dev/mvs/mvs.c2
-rw-r--r--sys/dev/nfe/if_nfe.c3
-rw-r--r--sys/dev/nxge/xge-osdep.h1
-rw-r--r--sys/dev/vxge/vxge-osdep.h1
8 files changed, 0 insertions, 13 deletions
diff --git a/sys/arm/at91/if_ate.c b/sys/arm/at91/if_ate.c
index 100b7be..6b2eabc 100644
--- a/sys/arm/at91/if_ate.c
+++ b/sys/arm/at91/if_ate.c
@@ -671,7 +671,6 @@ ate_deactivate(struct ate_softc *sc)
bus_dmamem_free(sc->rx_tag, sc->rx_buf[i],
sc->rx_map[i]);
sc->rx_buf[i] = NULL;
- sc->rx_map[i] = NULL;
}
bus_dma_tag_destroy(sc->rx_tag);
}
diff --git a/sys/dev/ahci/ahci.c b/sys/dev/ahci/ahci.c
index df504c0..0691b77 100644
--- a/sys/dev/ahci/ahci.c
+++ b/sys/dev/ahci/ahci.c
@@ -1394,14 +1394,12 @@ ahci_dmafini(device_t dev)
bus_dmamap_unload(ch->dma.rfis_tag, ch->dma.rfis_map);
bus_dmamem_free(ch->dma.rfis_tag, ch->dma.rfis, ch->dma.rfis_map);
ch->dma.rfis_bus = 0;
- ch->dma.rfis_map = NULL;
ch->dma.rfis = NULL;
}
if (ch->dma.work_bus) {
bus_dmamap_unload(ch->dma.work_tag, ch->dma.work_map);
bus_dmamem_free(ch->dma.work_tag, ch->dma.work, ch->dma.work_map);
ch->dma.work_bus = 0;
- ch->dma.work_map = NULL;
ch->dma.work = NULL;
}
if (ch->dma.work_tag) {
diff --git a/sys/dev/ata/ata-dma.c b/sys/dev/ata/ata-dma.c
index ee41c60..56332a1 100644
--- a/sys/dev/ata/ata-dma.c
+++ b/sys/dev/ata/ata-dma.c
@@ -132,7 +132,6 @@ ata_dmafini(device_t dev)
bus_dmamap_unload(ch->dma.work_tag, ch->dma.work_map);
bus_dmamem_free(ch->dma.work_tag, ch->dma.work, ch->dma.work_map);
ch->dma.work_bus = 0;
- ch->dma.work_map = NULL;
ch->dma.work = NULL;
}
if (ch->dma.work_tag) {
diff --git a/sys/dev/de/if_de.c b/sys/dev/de/if_de.c
index 71448ab..147b404 100644
--- a/sys/dev/de/if_de.c
+++ b/sys/dev/de/if_de.c
@@ -4473,7 +4473,6 @@ tulip_busdma_freering(tulip_ringinfo_t *ri)
}
if (ri->ri_descs != NULL) {
bus_dmamem_free(ri->ri_ring_tag, ri->ri_descs, ri->ri_ring_map);
- ri->ri_ring_map = NULL;
ri->ri_descs = NULL;
}
if (ri->ri_ring_tag != NULL) {
@@ -4558,7 +4557,6 @@ tulip_busdma_cleanup(tulip_softc_t * const sc)
if (sc->tulip_setupbuf != NULL) {
bus_dmamem_free(sc->tulip_setup_tag, sc->tulip_setupbuf,
sc->tulip_setup_map);
- sc->tulip_setup_map = NULL;
sc->tulip_setupbuf = NULL;
}
if (sc->tulip_setup_tag != NULL) {
diff --git a/sys/dev/mvs/mvs.c b/sys/dev/mvs/mvs.c
index 8ad85a8..dd5bb32 100644
--- a/sys/dev/mvs/mvs.c
+++ b/sys/dev/mvs/mvs.c
@@ -402,7 +402,6 @@ mvs_dmafini(device_t dev)
bus_dmamem_free(ch->dma.workrp_tag,
ch->dma.workrp, ch->dma.workrp_map);
ch->dma.workrp_bus = 0;
- ch->dma.workrp_map = NULL;
ch->dma.workrp = NULL;
}
if (ch->dma.workrp_tag) {
@@ -414,7 +413,6 @@ mvs_dmafini(device_t dev)
bus_dmamem_free(ch->dma.workrq_tag,
ch->dma.workrq, ch->dma.workrq_map);
ch->dma.workrq_bus = 0;
- ch->dma.workrq_map = NULL;
ch->dma.workrq = NULL;
}
if (ch->dma.workrq_tag) {
diff --git a/sys/dev/nfe/if_nfe.c b/sys/dev/nfe/if_nfe.c
index 806a4ee..729b134 100644
--- a/sys/dev/nfe/if_nfe.c
+++ b/sys/dev/nfe/if_nfe.c
@@ -1410,7 +1410,6 @@ nfe_free_rx_ring(struct nfe_softc *sc, struct nfe_rx_ring *ring)
bus_dmamem_free(ring->rx_desc_tag, desc, ring->rx_desc_map);
ring->desc64 = NULL;
ring->desc32 = NULL;
- ring->rx_desc_map = NULL;
}
if (ring->rx_desc_tag != NULL) {
bus_dma_tag_destroy(ring->rx_desc_tag);
@@ -1464,7 +1463,6 @@ nfe_free_jrx_ring(struct nfe_softc *sc, struct nfe_jrx_ring *ring)
bus_dmamem_free(ring->jrx_desc_tag, desc, ring->jrx_desc_map);
ring->jdesc64 = NULL;
ring->jdesc32 = NULL;
- ring->jrx_desc_map = NULL;
}
if (ring->jrx_desc_tag != NULL) {
@@ -1626,7 +1624,6 @@ nfe_free_tx_ring(struct nfe_softc *sc, struct nfe_tx_ring *ring)
bus_dmamem_free(ring->tx_desc_tag, desc, ring->tx_desc_map);
ring->desc64 = NULL;
ring->desc32 = NULL;
- ring->tx_desc_map = NULL;
bus_dma_tag_destroy(ring->tx_desc_tag);
ring->tx_desc_tag = NULL;
}
diff --git a/sys/dev/nxge/xge-osdep.h b/sys/dev/nxge/xge-osdep.h
index e8f4aba..2f70983 100644
--- a/sys/dev/nxge/xge-osdep.h
+++ b/sys/dev/nxge/xge-osdep.h
@@ -406,7 +406,6 @@ xge_os_dma_free(pci_dev_h pdev, const void *vaddr, int size,
XGE_OS_MEMORY_CHECK_FREE(p_dmah->dma_viraddr, size);
bus_dmamem_free(p_dmah->dma_tag, p_dmah->dma_viraddr, p_dmah->dma_map);
bus_dma_tag_destroy(p_dmah->dma_tag);
- p_dmah->dma_map = NULL;
p_dmah->dma_tag = NULL;
p_dmah->dma_viraddr = NULL;
return;
diff --git a/sys/dev/vxge/vxge-osdep.h b/sys/dev/vxge/vxge-osdep.h
index f358c91..66caaeb 100644
--- a/sys/dev/vxge/vxge-osdep.h
+++ b/sys/dev/vxge/vxge-osdep.h
@@ -615,7 +615,6 @@ vxge_dma_free(pci_dev_h pdev, const void *vaddr, u_long size,
bus_dmamem_free(p_dmah->dma_tag, p_dmah->dma_vaddr, p_dmah->dma_map);
bus_dma_tag_destroy(p_dmah->dma_tag);
- p_dmah->dma_map = NULL;
p_dmah->dma_tag = NULL;
p_dmah->dma_vaddr = NULL;
}
OpenPOWER on IntegriCloud