diff options
author | ed <ed@FreeBSD.org> | 2016-06-01 20:45:21 +0000 |
---|---|---|
committer | ed <ed@FreeBSD.org> | 2016-06-01 20:45:21 +0000 |
commit | d9384217a1b33ae8e1f3c9f6eaf0cfbfd2dd9114 (patch) | |
tree | 3dca84308e48eb52bddfcccbc1ac4ecfb0a1dd01 | |
parent | fe5676baea3c38ee19776983fdc1cf22c4a7d928 (diff) | |
download | FreeBSD-src-d9384217a1b33ae8e1f3c9f6eaf0cfbfd2dd9114.zip FreeBSD-src-d9384217a1b33ae8e1f3c9f6eaf0cfbfd2dd9114.tar.gz |
Don't call setgrent() in an unportable way.
For FreeBSD 12, I'm considering updating setgrent() to have a function
prototype that conforms to POSIX. FreeBSD seems to be the only operating
system that lets setgrent() return an integer. It's also inconsistent
with setpwent().
It looks like our libcasper depends on setgrent() returning an integer.
Get rid of that.
Reviewed by: oshogbo
Differential Revision: https://reviews.freebsd.org/D6659
-rw-r--r-- | lib/libcasper/services/cap_grp/cap_grp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/libcasper/services/cap_grp/cap_grp.c b/lib/libcasper/services/cap_grp/cap_grp.c index d358cea..54a022f 100644 --- a/lib/libcasper/services/cap_grp/cap_grp.c +++ b/lib/libcasper/services/cap_grp/cap_grp.c @@ -703,7 +703,9 @@ grp_setgrent(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused, nvlist_t *nvlout __unused) { - return (setgrent() == 0 ? EFAULT : 0); + setgrent(); + + return (0); } static int |