summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorscottl <scottl@FreeBSD.org>2013-07-30 22:57:12 +0000
committerscottl <scottl@FreeBSD.org>2013-07-30 22:57:12 +0000
commitd13c0062851638685f23ad2a414ca3b0e71ba340 (patch)
treed9647feaaaa44c41d2ce4450a5c48b8d34e7edba
parentaac8087bead638965fd8df72ec05b082185fa599 (diff)
downloadFreeBSD-src-d13c0062851638685f23ad2a414ca3b0e71ba340.zip
FreeBSD-src-d13c0062851638685f23ad2a414ca3b0e71ba340.tar.gz
Add a 'surrender' mode to fsck_ffs. With the -S flag, once hard read errors
are encountered, the fsck will stop instead of wasting time chewing through possibly other errors. Obtained from: Netflix MFC after: 3 days
-rw-r--r--sbin/fsck_ffs/fsck.h1
-rw-r--r--sbin/fsck_ffs/fsutil.c13
-rw-r--r--sbin/fsck_ffs/main.c6
3 files changed, 18 insertions, 2 deletions
diff --git a/sbin/fsck_ffs/fsck.h b/sbin/fsck_ffs/fsck.h
index 45b242c..632d454 100644
--- a/sbin/fsck_ffs/fsck.h
+++ b/sbin/fsck_ffs/fsck.h
@@ -324,6 +324,7 @@ char skipclean; /* skip clean file systems if preening */
int fsmodified; /* 1 => write done to file system */
int fsreadfd; /* file descriptor for reading file system */
int fswritefd; /* file descriptor for writing file system */
+int surrender; /* Give up if reads fail */
ufs2_daddr_t maxfsblock; /* number of blocks in the file system */
char *blockmap; /* ptr to primary blk allocation map */
diff --git a/sbin/fsck_ffs/fsutil.c b/sbin/fsck_ffs/fsutil.c
index f177408..abc987a 100644
--- a/sbin/fsck_ffs/fsutil.c
+++ b/sbin/fsck_ffs/fsutil.c
@@ -549,7 +549,18 @@ blread(int fd, char *buf, ufs2_daddr_t blk, long size)
slowio_end();
return (0);
}
- rwerror("READ BLK", blk);
+
+ /*
+ * This is handled specially here instead of in rwerror because
+ * rwerror is used for all sorts of errors, not just true read/write
+ * errors. It should be refactored and fixed.
+ */
+ if (surrender) {
+ pfatal("CANNOT READ_BLK: %ld", (long)blk);
+ errx(EEXIT, "ABORTING DUE TO READ ERRORS");
+ } else
+ rwerror("READ BLK", blk);
+
if (lseek(fd, offset, 0) < 0)
rwerror("SEEK BLK", blk);
errs = 0;
diff --git a/sbin/fsck_ffs/main.c b/sbin/fsck_ffs/main.c
index d074447..1a1c03b 100644
--- a/sbin/fsck_ffs/main.c
+++ b/sbin/fsck_ffs/main.c
@@ -82,7 +82,7 @@ main(int argc, char *argv[])
sync();
skipclean = 1;
inoopt = 0;
- while ((ch = getopt(argc, argv, "b:Bc:CdEfFm:npryZ")) != -1) {
+ while ((ch = getopt(argc, argv, "b:Bc:CdEfFm:nprSyZ")) != -1) {
switch (ch) {
case 'b':
skipclean = 0;
@@ -142,6 +142,10 @@ main(int argc, char *argv[])
inoopt++;
break;
+ case 'S':
+ surrender = 1;
+ break;
+
case 'y':
yflag++;
nflag = 0;
OpenPOWER on IntegriCloud