summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpjd <pjd@FreeBSD.org>2012-11-27 10:22:40 +0000
committerpjd <pjd@FreeBSD.org>2012-11-27 10:22:40 +0000
commitc079174e145757091a244b3c818aa046d2e6b93e (patch)
treef06915591c05c31a4cb30e1119662eddc2c2f658
parent02c0badfc1d26f3d714ef3e9a609e883d83e5fff (diff)
downloadFreeBSD-src-c079174e145757091a244b3c818aa046d2e6b93e.zip
FreeBSD-src-c079174e145757091a244b3c818aa046d2e6b93e.tar.gz
Allow to use kill(2) in capability mode, but process can send a signal only
to himself. For example abort(3) at first tries to do kill(getpid(), SIGABRT) which was failing in capability mode, so the code was failing back to exit(1). Reviewed by: rwatson Obtained from: WHEEL Systems MFC after: 2 weeks
-rw-r--r--sys/kern/capabilities.conf5
-rw-r--r--sys/kern/kern_sig.c8
2 files changed, 13 insertions, 0 deletions
diff --git a/sys/kern/capabilities.conf b/sys/kern/capabilities.conf
index 82eeb07..11aad16 100644
--- a/sys/kern/capabilities.conf
+++ b/sys/kern/capabilities.conf
@@ -337,6 +337,11 @@ issetugid
kevent
##
+## Allow kill(2), as we allow the process to send signals only to himself.
+##
+kill
+
+##
## Allow message queue operations on file descriptors, subject to capability
## rights.
##
diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c
index 56597ea..a0b5809 100644
--- a/sys/kern/kern_sig.c
+++ b/sys/kern/kern_sig.c
@@ -1679,6 +1679,14 @@ sys_kill(struct thread *td, struct kill_args *uap)
struct proc *p;
int error;
+ /*
+ * A process in capability mode can send signals only to himself.
+ * The main rationale behind this is that abort(3) is implemented as
+ * kill(getpid(), SIGABRT).
+ */
+ if (IN_CAPABILITY_MODE(td) && uap->pid != td->td_proc->p_pid)
+ return (ECAPMODE);
+
AUDIT_ARG_SIGNUM(uap->signum);
AUDIT_ARG_PID(uap->pid);
if ((u_int)uap->signum > _SIG_MAXSIG)
OpenPOWER on IntegriCloud