summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkib <kib@FreeBSD.org>2007-07-03 17:43:56 +0000
committerkib <kib@FreeBSD.org>2007-07-03 17:43:56 +0000
commitb6f22ce3857da5dbc90fc2eaffa30d773b4e569f (patch)
treef3b6e66519731aa2948a47e3198d14d57b5c9820
parentc3c1199f3c47f28ef2dbb7f35e5ba9a44603f7a3 (diff)
downloadFreeBSD-src-b6f22ce3857da5dbc90fc2eaffa30d773b4e569f.zip
FreeBSD-src-b6f22ce3857da5dbc90fc2eaffa30d773b4e569f.tar.gz
Use make_dev_credf(MAKEDEV_REF) instead of make_dev() from snp clone handler.
Drain clone events and cdev destruction from the module unload handler. Debugging help and testing by: Peter Holm Approved by: re (kensmith)
-rw-r--r--sys/dev/snp/snp.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/sys/dev/snp/snp.c b/sys/dev/snp/snp.c
index 44a2d7a..e61191f 100644
--- a/sys/dev/snp/snp.c
+++ b/sys/dev/snp/snp.c
@@ -616,10 +616,9 @@ snp_clone(void *arg, struct ucred *cred, char *name, int namelen,
return;
i = clone_create(&snpclones, &snp_cdevsw, &u, dev, 0);
if (i)
- *dev = make_dev(&snp_cdevsw, unit2minor(u),
- UID_ROOT, GID_WHEEL, 0600, "snp%d", u);
+ *dev = make_dev_credf(MAKEDEV_REF, &snp_cdevsw, unit2minor(u),
+ NULL, UID_ROOT, GID_WHEEL, 0600, "snp%d", u);
if (*dev != NULL) {
- dev_ref(*dev);
(*dev)->si_flags |= SI_CHEAPCLONE;
}
}
@@ -640,7 +639,9 @@ snp_modevent(module_t mod, int type, void *data)
if (!LIST_EMPTY(&snp_sclist))
return (EBUSY);
EVENTHANDLER_DEREGISTER(dev_clone, eh_tag);
+ drain_dev_clone_events();
clone_cleanup(&snpclones);
+ destroy_dev_drain(&snp_cdevsw);
ldisc_deregister(snooplinedisc);
break;
default:
OpenPOWER on IntegriCloud