diff options
| author | dim <dim@FreeBSD.org> | 2016-09-07 19:17:03 +0000 |
|---|---|---|
| committer | dim <dim@FreeBSD.org> | 2016-09-07 19:17:03 +0000 |
| commit | ae885e1fdfebdb4a8e373a88a3cb35b8479dea67 (patch) | |
| tree | 9cced87be94872e9057d786d53d9a91199d9668a | |
| parent | 69478467da704cf56025f7ecec912611ab1e4e71 (diff) | |
| download | FreeBSD-src-ae885e1fdfebdb4a8e373a88a3cb35b8479dea67.zip FreeBSD-src-ae885e1fdfebdb4a8e373a88a3cb35b8479dea67.tar.gz | |
MFC r305360:
With clang 3.9.0, compiling cxgb results in the following warning:
sys/dev/cxgb/cxgb_sge.c:2873:44: error: implicit conversion from 'int'
to 'char' changes value from 128 to -128 [-Werror,-Wconstant-conversion]
*mtod(m, char *) = CPL_ASYNC_NOTIF;
~ ^~~~~~~~~~~~~~~
This is because CPL_ASYNC_NOTIF is 0x80, so the plain char argument is
wrapped to a negative value. Fix this by using uint8_t instead.
Reviewed by: np
Differential Revision: https://reviews.freebsd.org/D7772
| -rw-r--r-- | sys/dev/cxgb/cxgb_sge.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index 76d40d81..9981d00 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -2870,7 +2870,7 @@ process_responses(adapter_t *adap, struct sge_qset *qs, int budget) memcpy(mtod(m, char *), r, AN_PKT_SIZE); m->m_len = m->m_pkthdr.len = AN_PKT_SIZE; - *mtod(m, char *) = CPL_ASYNC_NOTIF; + *mtod(m, uint8_t *) = CPL_ASYNC_NOTIF; opcode = CPL_ASYNC_NOTIF; eop = 1; rspq->async_notif++; |
