summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrpaulo <rpaulo@FreeBSD.org>2009-07-10 15:28:33 +0000
committerrpaulo <rpaulo@FreeBSD.org>2009-07-10 15:28:33 +0000
commitade7784f4d82c8deaead607f93502350979b0052 (patch)
tree70be8e5e46972642080f053290fd6f9766d7bac5
parent3625089dba2270344045a4160c2da2544c90aab4 (diff)
downloadFreeBSD-src-ade7784f4d82c8deaead607f93502350979b0052.zip
FreeBSD-src-ade7784f4d82c8deaead607f93502350979b0052.tar.gz
For ic_opmode switch cases, provide a default label with a printf saying
this opmode is not supported. Approved by: re (kib)
-rw-r--r--sys/dev/ipw/if_ipw.c3
-rw-r--r--sys/dev/iwi/if_iwi.c3
-rw-r--r--sys/dev/iwn/if_iwn.c3
-rw-r--r--sys/dev/wpi/if_wpi.c3
4 files changed, 10 insertions, 2 deletions
diff --git a/sys/dev/ipw/if_ipw.c b/sys/dev/ipw/if_ipw.c
index 1c4e492..0b21758 100644
--- a/sys/dev/ipw/if_ipw.c
+++ b/sys/dev/ipw/if_ipw.c
@@ -2462,6 +2462,9 @@ ipw_config(struct ipw_softc *sc)
case IEEE80211_M_MONITOR:
data = htole32(IPW_MODE_MONITOR);
break;
+ default:
+ device_printf(sc->sc_dev, "unknown opmode %d\n", ic->ic_opmode);
+ return EINVAL;
}
DPRINTF(("Setting mode to %u\n", le32toh(data)));
error = ipw_cmd(sc, IPW_CMD_SET_MODE, &data, sizeof data);
diff --git a/sys/dev/iwi/if_iwi.c b/sys/dev/iwi/if_iwi.c
index a551448..1105425 100644
--- a/sys/dev/iwi/if_iwi.c
+++ b/sys/dev/iwi/if_iwi.c
@@ -2208,7 +2208,8 @@ iwi_get_firmware(struct iwi_softc *sc, enum ieee80211_opmode opmode)
&sc->fw_uc, "iwi_ucode_monitor");
break;
default:
- break;
+ device_printf(sc->sc_dev, "unknown opmode %d\n", opmode);
+ return EINVAL;
}
fp = sc->fw_fw.fp;
if (fp == NULL) {
diff --git a/sys/dev/iwn/if_iwn.c b/sys/dev/iwn/if_iwn.c
index b520d8d..51dea22 100644
--- a/sys/dev/iwn/if_iwn.c
+++ b/sys/dev/iwn/if_iwn.c
@@ -3916,7 +3916,8 @@ iwn_config(struct iwn_softc *sc)
IWN_FILTER_CTL | IWN_FILTER_PROMISC);
break;
default:
- break;
+ device_printf(sc->sc_dev, "unknown opmode %d\n", ic->ic_opmode);
+ return EINVAL;
}
sc->config.cck_mask = 0x0f; /* not yet negotiated */
sc->config.ofdm_mask = 0xff; /* not yet negotiated */
diff --git a/sys/dev/wpi/if_wpi.c b/sys/dev/wpi/if_wpi.c
index 4378164..af51f60 100644
--- a/sys/dev/wpi/if_wpi.c
+++ b/sys/dev/wpi/if_wpi.c
@@ -2818,6 +2818,9 @@ wpi_config(struct wpi_softc *sc)
sc->config.filter |= htole32(WPI_FILTER_MULTICAST |
WPI_FILTER_CTL | WPI_FILTER_PROMISC);
break;
+ default:
+ device_printf(sc->sc_dev, "unknown opmode %d\n", ic->ic_opmode);
+ return EINVAL;
}
sc->config.cck_mask = 0x0f; /* not yet negotiated */
sc->config.ofdm_mask = 0xff; /* not yet negotiated */
OpenPOWER on IntegriCloud