diff options
| author | cem <cem@FreeBSD.org> | 2016-05-19 17:54:14 +0000 |
|---|---|---|
| committer | cem <cem@FreeBSD.org> | 2016-05-19 17:54:14 +0000 |
| commit | a17cbcde0a6c0d655fca3d82799c8d1ad343e666 (patch) | |
| tree | 8d741137441533001ab4a3ee99af40033f842edf | |
| parent | c1e1576b4917cf816d29173d41daf4d06e781ae4 (diff) | |
| download | FreeBSD-src-a17cbcde0a6c0d655fca3d82799c8d1ad343e666.zip FreeBSD-src-a17cbcde0a6c0d655fca3d82799c8d1ad343e666.tar.gz | |
vm/vm_page.h: Fix trivial '-Wpointer-sign' warning
pq_vcnt, as a count of real things, has no business being negative. It is only
ever initialized by a u_int counter.
The warning came from the atomic_add_int() in vm_pagequeue_cnt_add().
Rectify the warning by changing the variable to u_int. No functional change.
Suggested by: Clang 3.3
Sponsored by: EMC / Isilon Storage Division
| -rw-r--r-- | sys/vm/vm_page.c | 4 | ||||
| -rw-r--r-- | sys/vm/vm_page.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 2f3b17f..0ea8d86 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -384,11 +384,11 @@ vm_page_domain_init(struct vm_domain *vmd) *__DECONST(char **, &vmd->vmd_pagequeues[PQ_INACTIVE].pq_name) = "vm inactive pagequeue"; - *__DECONST(int **, &vmd->vmd_pagequeues[PQ_INACTIVE].pq_vcnt) = + *__DECONST(u_int **, &vmd->vmd_pagequeues[PQ_INACTIVE].pq_vcnt) = &vm_cnt.v_inactive_count; *__DECONST(char **, &vmd->vmd_pagequeues[PQ_ACTIVE].pq_name) = "vm active pagequeue"; - *__DECONST(int **, &vmd->vmd_pagequeues[PQ_ACTIVE].pq_vcnt) = + *__DECONST(u_int **, &vmd->vmd_pagequeues[PQ_ACTIVE].pq_vcnt) = &vm_cnt.v_active_count; vmd->vmd_page_count = 0; vmd->vmd_free_count = 0; diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h index 4eb0050..0f0b330 100644 --- a/sys/vm/vm_page.h +++ b/sys/vm/vm_page.h @@ -215,7 +215,7 @@ struct vm_pagequeue { struct mtx pq_mutex; struct pglist pq_pl; int pq_cnt; - int * const pq_vcnt; + u_int * const pq_vcnt; const char * const pq_name; } __aligned(CACHE_LINE_SIZE); |
