summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoradrian <adrian@FreeBSD.org>2015-12-15 04:43:28 +0000
committeradrian <adrian@FreeBSD.org>2015-12-15 04:43:28 +0000
commit9c16fc858ecff582ba964a2d47de4d3640a8010c (patch)
treefb94882297779a8fe95e49f3811951c8b1941efc
parent9663eabafdb2a61f95097a65569590453ab1f5be (diff)
downloadFreeBSD-src-9c16fc858ecff582ba964a2d47de4d3640a8010c.zip
FreeBSD-src-9c16fc858ecff582ba964a2d47de4d3640a8010c.tar.gz
[arge] add a comment about needing mdio busses in order to use the interface.
This is a holdover from how reset is handled in the ARGE_MDIO world. You need to define the mdio bus device if you want to use the ethernet device or the arge setup path doesn't bring the MAC out of reset.
-rw-r--r--sys/mips/atheros/if_arge.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/sys/mips/atheros/if_arge.c b/sys/mips/atheros/if_arge.c
index be38167..6a22f3f 100644
--- a/sys/mips/atheros/if_arge.c
+++ b/sys/mips/atheros/if_arge.c
@@ -885,6 +885,11 @@ arge_attach(device_t dev)
/*
* Don't do this for the MDIO bus case - it's already done
* as part of the MDIO bus attachment.
+ *
+ * XXX TODO: if we don't do this, we don't ever release the MAC
+ * from reset and we can't use the port. Now, if we define ARGE_MDIO
+ * but we /don't/ define two MDIO busses, then we can't actually
+ * use both MACs.
*/
#if !defined(ARGE_MDIO)
/* Initialize the MAC block */
OpenPOWER on IntegriCloud