summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoravg <avg@FreeBSD.org>2010-05-31 09:08:44 +0000
committeravg <avg@FreeBSD.org>2010-05-31 09:08:44 +0000
commit8557da2a5752d74e202acdb26a40175c14303019 (patch)
treecc31f56ea62199cab16e59ce709016b32333a9dc
parentb70d66885e2662de149bb4cfc79ab714512295a3 (diff)
downloadFreeBSD-src-8557da2a5752d74e202acdb26a40175c14303019.zip
FreeBSD-src-8557da2a5752d74e202acdb26a40175c14303019.tar.gz
udf_readlink: fix malloc call with uninitialized size parameter
Found by: clang static analyzer MFC after: 4 days
-rw-r--r--sys/fs/udf/udf_vnops.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/fs/udf/udf_vnops.c b/sys/fs/udf/udf_vnops.c
index 3201000..ac00b20 100644
--- a/sys/fs/udf/udf_vnops.c
+++ b/sys/fs/udf/udf_vnops.c
@@ -904,9 +904,9 @@ udf_readlink(struct vop_readlink_args *ap)
vp = ap->a_vp;
node = VTON(vp);
len = le64toh(node->fentry->inf_len);
+ iov[0].iov_len = len;
buf = malloc(iov[0].iov_len, M_DEVBUF, M_WAITOK);
iov[0].iov_base = buf;
- iov[0].iov_len = len;
uio.uio_iov = iov;
uio.uio_iovcnt = 1;
uio.uio_offset = 0;
OpenPOWER on IntegriCloud