summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrwatson <rwatson@FreeBSD.org>2001-10-23 19:09:01 +0000
committerrwatson <rwatson@FreeBSD.org>2001-10-23 19:09:01 +0000
commit83a8501a7c9b936d3fdaf41c99f2d34d39e811f3 (patch)
tree7cc5998f541a1770fd3d5d2bf621247ee62e3cba
parent972de970f5b7d3a73530169659fe3b5f09a3204c (diff)
downloadFreeBSD-src-83a8501a7c9b936d3fdaf41c99f2d34d39e811f3.zip
FreeBSD-src-83a8501a7c9b936d3fdaf41c99f2d34d39e811f3.tar.gz
o vn_open() fails to call VOP_CLOSE() if vfs_object_create fails. Ideally
all successful calls to VOP_OPEN() might be reflected in a call to VOP_CLOSE(). For now, simply add a comment reflecting this problem; this should be fixed at some point.
-rw-r--r--sys/kern/vfs_vnops.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c
index 911bd58..70d84a6 100644
--- a/sys/kern/vfs_vnops.c
+++ b/sys/kern/vfs_vnops.c
@@ -188,6 +188,7 @@ restart:
*/
if (vn_canvmio(vp) == TRUE) {
if ((error = vfs_object_create(vp, td, cred)) != 0)
+ /* XXX: Should VOP_CLOSE() again here. */
goto bad;
}
OpenPOWER on IntegriCloud