summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpfg <pfg@FreeBSD.org>2016-07-13 15:51:58 +0000
committerpfg <pfg@FreeBSD.org>2016-07-13 15:51:58 +0000
commit65b21de4c4c18888963a56120f8c37a329df170d (patch)
tree562da60856c4694b7028b480b66cecc73ef208c1
parent71d697a5df7b0ac9b54df6a5578d15fbfe7e35a5 (diff)
downloadFreeBSD-src-65b21de4c4c18888963a56120f8c37a329df170d.zip
FreeBSD-src-65b21de4c4c18888963a56120f8c37a329df170d.tar.gz
MFC r302476:
ng_mppc(4):: basic code readability cleanups. In particular use __unreachable() to appease static analyzers. No functional change. CID: 1356591 Approved by: re (gjb)
-rw-r--r--sys/net/mppcc.c3
-rw-r--r--sys/net/mppcd.c2
2 files changed, 3 insertions, 2 deletions
diff --git a/sys/net/mppcc.c b/sys/net/mppcc.c
index 01ce3ff..8ec21ad 100644
--- a/sys/net/mppcc.c
+++ b/sys/net/mppcc.c
@@ -232,8 +232,9 @@ int MPPC_Compress(u_char **src, u_char **dst, u_long *srcCnt, u_long *dstCnt, ch
} else if (off < 8192) { /* 16-bit offset; 320 <= offset < 8192 */
putbits16(*dst, 0xc000|(off-320), 16, &olen, &l);
} else { /* NOTREACHED */
+ __unreachable();
rtn &= ~MPPC_OK;
- return rtn;
+ return (rtn);
}
/* Encode length of match. */
diff --git a/sys/net/mppcd.c b/sys/net/mppcd.c
index c1730e5..d8e663c 100644
--- a/sys/net/mppcd.c
+++ b/sys/net/mppcd.c
@@ -170,7 +170,7 @@ int MPPC_Decompress(u_char **src, u_char **dst, u_long *srcCnt, u_long *dstCnt,
rtn &= ~MPPC_OK;
return (rtn);
}
- } else { /* NOTREACHED */
+ } else { /* This shouldn't happen. */
rtn &= ~MPPC_OK;
return (rtn);
}
OpenPOWER on IntegriCloud