summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbde <bde@FreeBSD.org>2004-03-04 11:20:02 +0000
committerbde <bde@FreeBSD.org>2004-03-04 11:20:02 +0000
commit553ee2ccd0d578f07e91e02819531ac34761a5bd (patch)
tree040cba490994831c864e1769084e3859d99592c4
parentaf2fb1e490c82f97d39348f242ce1b1d033e9f6d (diff)
downloadFreeBSD-src-553ee2ccd0d578f07e91e02819531ac34761a5bd.zip
FreeBSD-src-553ee2ccd0d578f07e91e02819531ac34761a5bd.tar.gz
Don't manually optimize for 20 year old compilers by casting to u_int
to get a free check for negative ints. Rev.1.35 got my request to remove the cast mostly backwards.
-rw-r--r--sys/sys/filedesc.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/sys/sys/filedesc.h b/sys/sys/filedesc.h
index 512e0c0..4ee0399 100644
--- a/sys/sys/filedesc.h
+++ b/sys/sys/filedesc.h
@@ -163,8 +163,7 @@ static __inline struct file *
fget_locked(struct filedesc *fdp, int fd)
{
- /* u_int cast checks for negative descriptors. */
- return ((u_int)fd >= (u_int)fdp->fd_nfiles ? NULL : fdp->fd_ofiles[fd]);
+ return (fd < 0 || fd >= fdp->fd_nfiles ? NULL : fdp->fd_ofiles[fd]);
}
extern struct mtx fdesc_mtx;
OpenPOWER on IntegriCloud