diff options
| author | des <des@FreeBSD.org> | 2016-02-11 17:48:15 +0000 |
|---|---|---|
| committer | des <des@FreeBSD.org> | 2016-02-11 17:48:15 +0000 |
| commit | 4f0a0f622190b3b4949f1c9fb5364aeb443b3ffc (patch) | |
| tree | 206516a66375bcbad3a98b3480a86096e6465f81 | |
| parent | a94c4c08ceccfc7301f55a9d44fc669c60f3acd1 (diff) | |
| download | FreeBSD-src-4f0a0f622190b3b4949f1c9fb5364aeb443b3ffc.zip FreeBSD-src-4f0a0f622190b3b4949f1c9fb5364aeb443b3ffc.tar.gz | |
Fix double-free error: r289419 moved all error handling in http_connect()
to the end of the function, but did not remove a fetch_close() call which
was made redundant by the one in the shared error-handling code.
PR: 206774
Submitted by: Christian Heckendorf <heckendorfc@gmail.com>
MFC after: 3 days
| -rw-r--r-- | lib/libfetch/http.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index 206648d..ca522a6 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -1435,7 +1435,6 @@ http_connect(struct url *URL, struct url *purl, const char *flags) } if (strcasecmp(URL->scheme, SCHEME_HTTPS) == 0 && fetch_ssl(conn, URL, verbose) == -1) { - fetch_close(conn); /* grrr */ errno = EAUTH; fetch_syserr(); |
